[Bugsy]

Yes, now the grenade is passed to the take health and killed by functions so you can react directly instead of assigning the grenade type to a global variable and reacting to it in each function. That could get messy if there are a lot of grenade simultaneously thrown.

[EFFx]

Uh, thank you dude.

[Bugsy]

Originally Posted by EFFx The last thing, how can I call the 114 at get_pdata_int()? m_pGrenade ? PHP Code: get_pdata_int(toucher, 114)

https://forums.alliedmods.net/showpo...&postcount=175

114 is related to grenades events and a generic name would be : m_usEvent

• 0 : Flashbang : Since there is no event for that, value is null.
• 1 : HE grenade ; value by default returned from PRECACHE_EVENT( 1, "events/createexplo.sc" )
• 2 : Smoke grenade : value by default returned from PRECACHE_EVENT( 1, "events/createsmoke.sc" )

[EFFx]

Hey, can I do this?

PHP Code:

public plugin_precache()
{
    if(get_pcvar_num(PluginEnabled))
    {
        for(new i;i < sizeof EmitSounds;i++)
        {
            precache_sound(EmitSounds[i])
        }
    }
} 


Or a check is needed only on fwd_touch() ?

Edit: I got what you said

PHP Code:

    new bits = get_pdata_int(index, 114)
    if (bits & (1<<0))
        return CSW_HEGRENADE
    else if (bits & (1<<1))
        return CSW_SMOKEGRENADE
    else if (!bits)
        return CSW_FLASHBANG

    return 0 


Thats the code you were using to check what grenade has been threw.

[Bugsy]

Originally Posted by EFFx Hey, can I do this? PHP Code: public plugin_precache() {     if(get_pcvar_num(PluginEnabled))     {         for(new i;i < sizeof EmitSounds;i++)         {             precache_sound(EmitSounds[i])         }     } }  Or a check is needed only on fwd_touch() ? [/php] Thats the code you were using to check what grenade has been threw.

No, precache is called before init so your cvar pointer will be 0. You are better off letting precache get called..this way if the plugin is enabled during a game, it will begin working.

I see no harm in calling it on touch, but put the cvar check after you do the spam check.

[EFFx]

Wait, I didn't get it.

So, I shouldn't add a check on plugin_precache(), the players will be forced to precache the sounds but the cvar will be 0 and these sounds will not be used. But it makes sense when someone want to turn the cvar 1 and him don't need to reset the map for the plugin become working.

The check on fwd_touch will be executed so much times per second, and milions times per map, right?
You told me to put the cvar after the check, you meant this

PHP Code:

public fwd_touch(touched, toucher) 
{    
    new id = pev(toucher, pev_owner)
    
    if(gLastTouched[id] != touched)
    {
        if(!get_pcvar_num(PluginEnabled))
            return FMRES_IGNORED
            
        new iGrenadeBits = get_pdata_int(toucher, m_usEvent)
        
        if(!(iGrenadeBits & (1 << 0)))
        {
            takeHealth(touched, id, (iGrenadeBits & (1 << 1)) ? SmokeGrenade : Flashbang)
            gLastTouched[id] = touched
        }
    }
    return FMRES_IGNORED
} 


Right? But will not be the same? the fwd_touch() will be executed so much times yet.

[Bugsy]

fwd_touch() will get executed, there's no way around that without pausing/stopping the entire plugin.

The goal is to prevent as much code, especially natives, from getting called when the plugin is disabled. Your code looks ok, you just have to move gLastTouched[id] = touched outside of that if statement. Your current code would allow HE grenades to spam.

Edit: This will not work, gLastTouched[id] = touched will not get reached when the plugin is disabled.
Edit2: Fixed

PHP Code:

public fwd_touch(touched, toucher) 
{
    new id = pev(toucher, pev_owner)
    
    if ( gLastTouched[id] != touched )
    {
        if ( get_pcvar_num( PluginEnabled ) ) 
        {
            new iGrenadeBits = get_pdata_int(toucher, m_usEvent)
            
            if(!(iGrenadeBits & (1 << 0)))
            {
                takeHealth(touched, id, (iGrenadeBits & (1 << 1)) ? SmokeGrenade : Flashbang)
            }
        }
        
        gLastTouched[id] = touched
    }
    
    return FMRES_IGNORED
} 


[EFFx]

Yes, I was thinking to pause the plugin. But I'll continue adding the check only on fwd_touch().

Then the cvar check should be before of any native/code for prevent any native/code gets called, right?

Yes, my code allow HE Grenade to spam.

PHP Code:

public fwd_touch(touched, toucher) 
{    
    if(!get_pcvar_num(PluginEnabled))
        return FMRES_IGNORED

    new id = pev(toucher, pev_owner)
    
    if(gLastTouched[id] != touched)
    {    
        new iGrenadeBits = get_pdata_int(toucher, m_usEvent)
        
        if(!(iGrenadeBits & (1 << 0)))
        {
            takeHealth(touched, id, (iGrenadeBits & (1 << 1)) ? SmokeGrenade : Flashbang)
        }
    }
    gLastTouched[id] = touched
    return FMRES_IGNORED
} 


That's the final code?

[Bugsy]

No, look at my edited post.

Edit: Nevermind, either way a native is being called. May as well just check the cvar instead of pev_owner. So yes, your code is fine, just move gLastTouched[id] = touched above that closing bracket.

[EFFx]

Wait,

this

PHP Code:

if(!(iGrenadeBits & (1 << 0))) 


Is checking if the grenade bits isn't the HE grenade right?

So, cannot be like this?

PHP Code:

public fwd_touch(touched, toucher) 
{
    new iGrenadeBits = get_pdata_int(toucher, m_usEvent)
            
    if(!(iGrenadeBits & (1 << 0)))
    {
        new id = pev(toucher, pev_owner)
    
        if(gLastTouched[id] != touched)
        {
            if(get_pcvar_num(PluginEnabled)) 
            {
                takeHealth(touched, id, (iGrenadeBits & (1 << 1)) ? SmokeGrenade : Flashbang)
                gLastTouched[id] = touched
            }
        }
    }
    return FMRES_IGNORED
}