[zmd94]

New update!

v3.1 - [ADDED] Adding the ID of a task so that we can remove the task when the player that recieve the reward is being killed or disconnect from the server. v3.1 - [FIXED] Improve the readibility of the code (Credit to wbyokowo for helping). v3.1 - [ADDED] The information about the HP, amor and money limit in the cs_reward.cfg file.

[Jhob94]

Originally Posted by zmd94 By the way, what are the different between two of this: 1. PHP Code:  if(!is_user_alive(attacker) || attacker == victim)  2. PHP Code:  if(attacker == victim || !is_user_alive(attacker))  As I can see that you have used the second option.

To be honest, in this case it does not really matters. You must check always first the most important, the way that makes it have more sense. But here it doesnt seems like really matters.

[zmd94]

Originally Posted by Jhob94 To be honest, in this case it does really matters. You must check always first the most important, the way that makes it have more sense. But here it doesnt seems like really matters.

Alright.

[yokomo]

Originally Posted by zmd94 I appreciate it. I will update the code. ;) By the way, what are the different between two of this: 1. PHP Code:  if(!is_user_alive(attacker) || attacker == victim)  2. PHP Code:  if(attacker == victim || !is_user_alive(attacker))  As I can see that you have used the second option.

1. You call native first.
2. Native call on second check.

[zmd94]

I can see that. Yet, which one is better? Or it doesn't matter as Jhob94 said?

[Jhob94]

Originally Posted by zmd94 I can see that. Yet, which one is better? Or it doesn't matter as Jhob94 said?

You need to check whats more important first. But in this case they are the same, doesn't matters. But imagine that you have a global bool that you have to check. First you check that bool and only after check the bool you check the others. But this isn't even important, just to make plugin has sense.

[zmd94]

Originally Posted by Jhob94 You need to check whats more important first. But in this case they are the same, doesn't matters. But imagine that you have a global bool that you have to check. First you check that bool and only after check the bool you check the others. But this isn't even important, just to make plugin has sense.

Now, I got it.

The main point is we must check whats more important first. Yet, if they are the same, it is doesn't matters.;)

[Jhob94]

Originally Posted by zmd94 Now, I got it. The main point is we must check whats more important first. Yet, if they are the same, it is doesn't matters.;)

You just need to think what makes more sense to the server check first.

[HamletEagle]

I my opinion worring about such a little thing is useless. It won't make difference, but this is more like "keep good practice". You think what make more sense, but if you can't guess, just put it as you like.

[yokomo]

Ok to be clear.
this:

PHP Code:

if(attacker == victim || !is_user_alive(attacker)) return; 


is the same as:

PHP Code:

if(attacker == victim) return; //stop here no need to call next native
if(!is_user_alive(attacker)) return; 


Got my point? reduce 1 communication.