[TommyV]

Originally Posted by L. Duke Not sure, but ClientConnect() may be too early. I record the client info on "player_connect" event and then wait to hook them until they have spawned in game and are alive (i.e. I don't hook them in spectator mode, I wait until they join a team and spawn.) Looks like showdax is using ClientActive() succesfully, so maybe I should have tried that. EDIT: Read BAILOPAN's post (about the third one down) in this thread.

Well that explains my error, it worked when I moved it to ClientPutInServer, even without the manual hooks.

Thanks for all the help.

[c0ldfyr3]

SH_DECL_HOOK1_void(CBasePlayer, Touch, SH_NOATTRIB, 0, CBaseEntity *); 

SH_ADD_HOOK_MEMFUNC(CBasePlayer, Touch, pPlayer, &g_TouchCatcher, &TouchCatcher::Touch_handler, false);

You can't use it like that, you have to use manual hooking.

[TommyV]

Originally Posted by c0ldfyr3 You can't use it like that, you have to use manual hooking.

Why? It says you can in the SourceMM docs, and it works.

[showdax]

Originally Posted by TommyV Originally Posted by c0ldfyr3 You can't use it like that, you have to use manual hooking. Why? It says you can in the SourceMM docs, and it works.

You shouldn't try to hook something that you don't have valid header for, in that fashion. The player.h in the SDK differs from what's used in CS:S, DoD:S, et cetera, so the offsets derived from the class definition could be wrong.

[c0ldfyr3]

Originally Posted by TommyV Originally Posted by c0ldfyr3 You can't use it like that, you have to use manual hooking. Why? It says you can in the SourceMM docs, and it works.

Yes, the docs are older than the headers.
If you had been reading what we said earlier, they physically MOVED the functions around in the .h file.

So, when you hook Touch, it might work on YOUR windows machine, but try testing it on linux or even another windows machine and watch crash city from the front row.

The functions around Touch are as follows..

_ZNK11CBaseEntity8GetEnemyEv
_ZN11CBaseEntity3UseEPS_S0_8USE_TYPEf
_ZN11CBaseEntity10StartTouchEPS_
_ZN11CBasePlayer5TouchEP11CBaseEntity
_ZN11CBaseEntity8EndTouchEPS_
_ZN11CBaseEntity12StartBlockedEPS_
_ZN11CBaseEntity7BlockedEPS_
_ZN11CBaseEntity10EndBlockedEv

So, when you hook Touch, you could be hooking any one of the above, depending on where they moved each function from.
If you are hooking StartTouch but think you are hooking Touch, of course its going to fire everytime Touch does, but with a param of god only knows what.

Do yourself a favour and avoid the headaches, and start your project using manual hooks.

[TommyV]

Ok, I'll use manual hooks.

I'm only asking because it is very difficult to know what's what if you haven't been involved with plugins much and had to deal with fixing them when hl2 is updated. How do I know what is a valid header, why is it is ok to hook IServerGameDLL functions but not CBasePlayer functions? I guess the answer is you just have to know.

I was hoping that using sourcemm would bring some elegance and certainty to function hooking which is something I'm not experienced or comfortable with, but if valve are going to make sure the sdk doesn't match the real code then I guess there's nothing anyone can do about it

I'll stick to manual hooks and hope that someone is always good enough to update the offset lists for any classes I use because I wouldn't know where to start trying to get vtable offsets.

[c0ldfyr3]

There are enough of us that know how to get the vtable to post it if it changes.

As for questions #1, well, IServerGameDLL isnt a hacked include. Its a valid interface which Valve provided for your usage. CBaseEntity is not.

[BAILOPAN]

Originally Posted by TommyV I was hoping that using sourcemm would bring some elegance and certainty to function hooking which is something I'm not experienced or comfortable with

For interfaces you definitively know about, it does. Unfortunately some of more savory stuff in the HL2SDK is mod specific and you have no choice but to get into disassembling/reverse engineering.

Making virtual function hooking "easy" is only one goal of SourceHook. The other goal, of course, is to make it flexible and not crash ;) (i.e. letting many plugins hook the same thing cleanly).