[oplkill]

I trying to make multiply attributes for weapons, but when i do that clients just crashing in all way that i tryed to do.

I tryed to use standart tf2 attributes library and https://github.com/nosoop/SM-TFEconData/releases, but them both crashing clients.

Way 1

PHP Code:

int defIndixes[16];
float defValues[16];
int multiply = 100;
const int numWeaponSlots = 3;
int slot[numWeaponSlots] = {WeaponSlot_Primary, WeaponSlot_Secondary, WeaponSlot_Melee};

for (int i=0; i<numWeaponSlots; i++)
{
    int weapIndex = GetPlayerWeaponSlot(client, slot[i]);
    int numAttrs = TF2Attrib_GetStaticAttribs(GetItemDefinition(weapIndex), defIndixes, defValues);
    for (int b = 0; b < numAttrs; b++)
    {
        char typedescription[32];
        if ( TF2Econ_GetAttributeDefinitionString( defIndixes[b], "description_format", typedescription, 32 ) )
        {
            if ( StrEqual( typedescription, "value_is_additive" ) || StrEqual( typedescription, "value_is_percentage" ) && 
                defValues[b] < 100.0 ) //for some reason some values are not Float
            {       
                TF2Attrib_SetByDefIndex(weapIndex, defIndixes[b], defValues[b] * multiply);
            }
        }
    }
    if (numAttrs > 0)
        TF2Attrib_ClearCache(weapIndex);
} 


Way 2

PHP Code:

bool isCompatibleItem(char[] classname, int iItemDefinitionIndex)
{
    return StrContains(classname, "tf_weapon") != -1 ||
        StrEqual(classname, "saxxy") ||
        StrEqual(classname, "tf_wearable_demoshield") ||
        (StrEqual(classname, "tf_wearable") &&
        (iItemDefinitionIndex == 133 ||
        iItemDefinitionIndex == 444 ||
        iItemDefinitionIndex == 405 ||
        iItemDefinitionIndex == 608 ||
        iItemDefinitionIndex == 57 ||
        iItemDefinitionIndex == 231 ||
        iItemDefinitionIndex == 642));
}

public int TF2Items_OnGiveNamedItem_Post(int client, char[] classname, int itemDefinitionIndex, int itemLevel, int itemQuality, int entityIndex)
{
    int multiply = 100;
    if (!isCompatibleItem(classname, itemDefinitionIndex)
    || (itemQuality == 5 && itemDefinitionIndex != 266)
    || itemQuality == 8 || itemQuality == 10)
    {
        return;
    }

    int defIndixes[16];
    float defValues[16];
    int numAttrs = TF2Attrib_GetStaticAttribs(GetItemDefinition(entityIndex), defIndixes, defValues);

    for (int b = 0; b < numAttrs; b++)
    {
        char typedescription[32];
        if ( TF2Econ_GetAttributeDefinitionString( defIndixes[b], "description_format", typedescription, 32 ) )
        {
            if ( StrEqual( typedescription, "value_is_additive" ) || StrEqual( typedescription, "value_is_percentage" ) && defValues[b] < 100.0 )
            {       
                TF2Attrib_SetByDefIndex(entityIndex, defIndixes[b], defValues[b] * multiply);
            }
        }
    }
} 


What i do wrong?

[PC Gamer]

Did you update to the newer version?

https://github.com/nosoop/SM-TFEconData/issues/7

[oplkill]

em, yes, i using latest November 2 2020 version in release.
I updated gamedata to latest, but its still crashing clients. (not server!)
In server do not showing any error messages only that:

Entity 1 (class 'player') reported ENTITY_CHANGE_NONE but 'm_nPlayerCondEx3' changed. STEAMAUTH: Client Oplkill received failure code 6

Mostly crashing happening when i changing weapon in hands.(pressing 1/2/3 key)

[nosoop]

Printing which attributes are actually being modified is a good way to figure this out.

In particular, it looks like min_viewmodel_offset presents itself as additive, but string types aren't replicated across the client-server divide. Adding an additional check for attribute_type == "string" should resolve this.

There might be some other non-numeric types that need their own detection methods.

[oplkill]

Thanks for helping, i found solution!

PHP Code:

void SetAttributesMultiply(int client, int multiply)
{
    int defIndixes[16];
    float defValues[16];

    const int numWeaponSlots = 3;
    int slot[numWeaponSlots] = {WeaponSlot_Primary, WeaponSlot_Secondary, WeaponSlot_Melee};
 
    for (int i=0; i<numWeaponSlots; i++)
    {
        int weapIndex = GetPlayerWeaponSlot(client, slot[i]);
        if (!IsValidEntity(weapIndex))
            continue;
        int numAttrs = TF2Attrib_GetStaticAttribs(GetItemDefinition(weapIndex), defIndixes, defValues);
        for (int b = 0; b < numAttrs; b++)
        {
            if (defIndixes[b] == 817 || defIndixes[b] == 796) //just for sure
            {
                continue;
            }

            char typedescription[32];
            if ( TF2Econ_GetAttributeDefinitionString( defIndixes[b], "description_format", typedescription, 32 ) )
            {
                if (( StrEqual( typedescription, "value_is_additive" ) || StrEqual( typedescription, "value_is_percentage" )) && 
                        !StrEqual( typedescription, "string") && 
                        (defValues[b] < -0.01 || defValues[b] > 0.01) && defValues[b] < 100.0 && 
                        (defValues[b] < 0.98 || defValues[b] > 1.01))
                {       
                    TF2Attrib_SetByDefIndex(weapIndex, defIndixes[b], defValues[b] * multiply);
                }
            }
        }
        if (numAttrs > 0)
            TF2Attrib_ClearCache(weapIndex);
    }
} 


You need to call that function with "1", when player dead and round win, for preventing crashes.

PHP Code:

SetAttributesMultiply(client, 1);