Raised This Month: $51 Target: $400
 12% 

Galileo 1.1.290 (a feature rich map voting plugin)


Post New Thread Reply   
 
Thread Tools Display Modes
frAd
Member
Join Date: Apr 2014
Location: Philippines
Old 03-04-2015 , 08:19   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1501

I must say you are right Spirit, without iChat (I'm using it) it's working correctly. I'm glad you found the problem, but I would like to know if there is a fix between iChat and Galileo?
frAd is offline
Send a message via ICQ to frAd Send a message via AIM to frAd Send a message via Yahoo to frAd Send a message via Skype™ to frAd
GhostMan
Senior Member
Join Date: Jun 2012
Old 03-04-2015 , 08:46   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1502

There is countdown before map change. Sometimes map changes in a middle of countdown. It is very rare that countdown and map change is matching.
Maybe there is a way to "fix" it?
GhostMan is offline
Old 03-04-2015, 12:41
Brad
This message has been deleted by Brad. Reason: wrong
Old 03-04-2015, 12:44
Brad
This message has been deleted by Brad. Reason: wrong
Old 03-04-2015, 12:48
Brad
This message has been deleted by Brad. Reason: wrong
Old 03-04-2015, 12:54
frAd
This message has been deleted by Brad. Reason: response to deleted thread
Brad
AMX Mod X Team Member
Join Date: Jun 2004
Old 03-04-2015 , 13:13   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1503

Okay. First, thanks for the find, Spirit.

Galileo registers some commands in plugin_cfg() based on if the commands are enabled, which isn't known until that point. The problem is that all plugins' plugin_init() get called before any plugins' plugin_cfg() gets called. This essentially means that iChat has already deadended the chain of chat handlers before any plugins register, in their plugin_cfg(), that they want to handle chat.

I'd argue that this is a design flaw of iChat. Further, I believe it can be resolved by simply moving iChat's "say" handler register from plugin_init() to plugin_cfg().

To do that, in iChat.sma...

Delete the following two lines from plugin_init():
Code:
    register_clcmd( "say", "iChatHookSay", 0 );     register_clcmd( "say_team", "iChatHookSay", 1 );
Add the following code between plugin_init() and plugin_unpause():
Code:
public plugin_cfg() {     register_clcmd( "say", "iChatHookSay", 0 );     register_clcmd( "say_team", "iChatHookSay", 1 ); }

Please let me know if it works.
__________________
Brad is offline
Spirit_12
Veteran Member
Join Date: Dec 2012
Location: Toronto, CA
Old 03-04-2015 , 13:18   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1504

I don't use ichat, so won't be of much help, but I was playing with galileo code to add round based capabilities. Its not perfect, but I think I have something that might be usable.

Please let me know when you done with ichat issue, as I don't wanna cause confusion.
Spirit_12 is offline
Brad
AMX Mod X Team Member
Join Date: Jun 2004
Old 03-04-2015 , 13:20   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1505

Quote:
Originally Posted by GhostMan View Post
There is countdown before map change. Sometimes map changes in a middle of countdown. It is very rare that countdown and map change is matching.
Maybe there is a way to "fix" it?
This plugin only counts down, from 7 to 1, for pending votes, not for map changes. Presumably it's a different plugin you're running.
__________________

Last edited by Brad; 03-04-2015 at 13:21.
Brad is offline
Brad
AMX Mod X Team Member
Join Date: Jun 2004
Old 03-04-2015 , 13:22   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1506

Spirit, if you want to send it to me in a PM, I'll take a look at it. Can't promise anything more than a look though.
__________________
Brad is offline
frAd
Member
Join Date: Apr 2014
Location: Philippines
Old 03-04-2015 , 22:37   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1507

Quote:
Originally Posted by Brad View Post
Okay. First, thanks for the find, Spirit.

Galileo registers some commands in plugin_cfg() based on if the commands are enabled, which isn't known until that point. The problem is that all plugins' plugin_init() get called before any plugins' plugin_cfg() gets called. This essentially means that iChat has already deadended the chain of chat handlers before any plugins register, in their plugin_cfg(), that they want to handle chat.

I'd argue that this is a design flaw of iChat. Further, I believe it can be resolved by simply moving iChat's "say" handler register from plugin_init() to plugin_cfg().

To do that, in iChat.sma...

Delete the following two lines from plugin_init():
Code:
    register_clcmd( "say", "iChatHookSay", 0 );     register_clcmd( "say_team", "iChatHookSay", 1 );
Add the following code between plugin_init() and plugin_unpause():
Code:
public plugin_cfg() {     register_clcmd( "say", "iChatHookSay", 0 );     register_clcmd( "say_team", "iChatHookSay", 1 ); }

Please let me know if it works.
Sorry for the late response. It's working right now.
frAd is offline
Send a message via ICQ to frAd Send a message via AIM to frAd Send a message via Yahoo to frAd Send a message via Skype™ to frAd
mpasd
Junior Member
Join Date: Dec 2010
Old 03-05-2015 , 19:43   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1508

Hi, i found some bugs, while using galileo on my cs 1.6 kreedz server.

1. When player nominate maps, for example, ftw_deathzone and bkz_goldbhop_h, and then choose extend on the vote, those maps can be nominated again, and will appear in the vote twice... Sometimes there's a vote with 9 choices , and only 5 maps ...

2. When the map is extended by the vote, the time that player need to wait to type rtv again is increased by the same amount, so i set the wait time to 5 minutes, and when the map is extended it increases to 10 minutes, so after the vote players need to wait 10 more minutes to vote. Then if it's extended again, we have to wait 15 minutes , which is the same as the time the map was extended ... At least i think so, because, once, after a few extends i saw that we needed to wait for 30 minutes to rtv...

3. And the third one, and the biggest one is that sometimes, mostly once or twice a day , the vote just doesn't appear at all... We hear the voting coming, the text displays normally, and then nothing happens, it's says voting in progress, and then changes to the first map of the mapcycle ... In the error log i found 2 different errors:

Code:
L 03/01/2015 - 19:25:03: Invalid cellvector handle provided (8:-110:864)
L 03/01/2015 - 19:25:03: [AMXX] Displaying debug trace (plugin "galileo.amxx")
L 03/01/2015 - 19:25:03: [AMXX] Run time error 10: native error (native "ArrayGetString")
L 03/01/2015 - 19:25:03: [AMXX] [0] galileo.sma::map_nominate (line 1180)
L 03/01/2015 - 19:25:03: [AMXX] [1] galileo.sma::nomination_handleMatchChoice (line 1073)

and

Code:
L 03/02/2015 - 17:35:06: [AMXX] Displaying debug trace (plugin "galileo.amxx")
L 03/02/2015 - 17:35:06: [AMXX] Run time error 4: index out of bounds 
L 03/02/2015 - 17:35:06: [AMXX] [0] galileo.sma::vote_expire (line 1970)

That's all the bugs i found, if any of you solved this before, or have any idea how to solve it, i will appreciate any help... If you need the lines from the sma just ask, i'll post it asap ...

Last edited by mpasd; 03-05-2015 at 19:44.
mpasd is offline
Brad
AMX Mod X Team Member
Join Date: Jun 2004
Old 03-09-2015 , 15:54   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1509

Thank you, mpasd. I'll take a look and see what I can find.
__________________
Brad is offline
hN!
Junior Member
Join Date: Apr 2008
Old 03-15-2015 , 23:39   Re: Galileo 1.1.290 (a feature rich map voting plugin)
Reply With Quote #1510

Code:
L 03/16/2015 - 14:22:39: Start of error session.
L 03/16/2015 - 14:22:39: Info (map "de_dust2") (file "addons/amxmodx/logs/error_20150316.log")
L 03/16/2015 - 14:22:39: Invalid index 0 (count: 0)
L 03/16/2015 - 14:22:39: [AMXX] Displaying debug trace (plugin "galileo.amxx", version "1.1.290")
L 03/16/2015 - 14:22:39: [AMXX] Run time error 10: native error (native "ArrayGetString")
L 03/16/2015 - 14:22:39: [AMXX]    [0] galileo.sma::map_getNext (line 357)
L 03/16/2015 - 14:22:39: [AMXX]    [1] galileo.sma::srv_startEmptyCycle (line 2802)
Same here anyway around this? I also tried compiling with the latest dev
hN! is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 03:06.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode