[highcoder]

Originally Posted by OciXCrom Try moving the default knife on top. Are you using the latest version of the plugin? // Edit: nevermind, I saw what the problem is. Fixed. Download the new version (v2.1.1).

Thanks for your reply and update. I will try the plugin in the day.

[highcoder]

Originally Posted by OciXCrom Try moving the default knife on top. Are you using the latest version of the plugin? // Edit: nevermind, I saw what the problem is. Fixed. Download the new version (v2.1.1).

Thanks for your reply and update again. I tried the plugin and not see a problem with the flag. The first written knife to KnifeModels.ini is the default knife. Is this a problem? Because in the source file shown the default knife directory.

[OciXCrom]

It's not a problem. I would actually recommend you to leave the first knife to be the default one.

[highcoder]

Originally Posted by OciXCrom It's not a problem. I would actually recommend you to leave the first knife to be the default one.

There is no need to change the default knife directory in the source file. Is not it?

[warps013]

Hi OciXcrom, sweet coding there, I really liked it! I was hoping... is there a way to replace guns models to player models? I know it would be different since chooseteam, but I would like to choose player models from a menu away from choosteam

[OciXCrom]

Originally Posted by highcoder There is no need to change the default knife directory in the source file. Is not it?

Don't change anything in the .sma file.

[OciXCrom]

Originally Posted by warps013 Hi OciXcrom, sweet coding there, I really liked it! I was hoping... is there a way to replace guns models to player models? I know it would be different since chooseteam, but I would like to choose player models from a menu away from choosteam

Thanks. There's probably a plugin like that made already. You can search for it. I don't feel like doing it.

[highcoder]

Originally Posted by OciXCrom Don't change anything in the .sma file.

Okay, thanks for your reply and update. Have a nice day!

[HamletEagle]

1.

PHP Code:

switch(detect_knife_sound(szSample))
    {
        case SOUND_DEPLOY: if(g_eKnife[id][DEPLOY_SOUND][0]) { play_knife_sound(id, g_eKnife[id][DEPLOY_SOUND][0]); return FMRES_SUPERCEDE; }
        case SOUND_HIT: if(g_eKnife[id][HIT_SOUND][0]) { play_knife_sound(id, g_eKnife[id][HIT_SOUND][0]); return FMRES_SUPERCEDE; }
        case SOUND_HITWALL: if(g_eKnife[id][HITWALL_SOUND][0]) { play_knife_sound(id, g_eKnife[id][HITWALL_SOUND][0]); return FMRES_SUPERCEDE; }
        case SOUND_SLASH: if(g_eKnife[id][SLASH_SOUND][0]) { play_knife_sound(id, g_eKnife[id][SLASH_SOUND][0]); return FMRES_SUPERCEDE; }
        case SOUND_STAB: if(g_eKnife[id][STAB_SOUND][0]) { play_knife_sound(id, g_eKnife[id][STAB_SOUND][0]); return FMRES_SUPERCEDE; }
    } 


This is pretty bad for readability. Way too many things on one line. IMO writting code in one line is ok only when you have one single instruction, like:

PHP Code:

if(!something) return 


2.Consider using ItemDeploy instead of CurWeapon.
3.

PHP Code:

else if(equal(szKey, "DEPLOY_SOUND"))
{
    eKnife[HAS_CUSTOM_SOUND] = true
    copy(eKnife[DEPLOY_SOUND], charsmax(eKnife[DEPLOY_SOUND]), szValue)
    precache_sound(szValue)
}
else if(equal(szKey, "HIT_SOUND"))
{
    eKnife[HAS_CUSTOM_SOUND] = true
    copy(eKnife[HIT_SOUND], charsmax(eKnife[HIT_SOUND]), szValue)
    precache_sound(szValue)
}
else if(equal(szKey, "HITWALL_SOUND"))
{
    eKnife[HAS_CUSTOM_SOUND] = true
    copy(eKnife[HITWALL_SOUND], charsmax(eKnife[HITWALL_SOUND]), szValue)
    precache_sound(szValue)
}
else if(equal(szKey, "SLASH_SOUND"))
{
    eKnife[HAS_CUSTOM_SOUND] = true
    copy(eKnife[SLASH_SOUND], charsmax(eKnife[SLASH_SOUND]), szValue)
    precache_sound(szValue)
}
else if(equal(szKey, "STAB_SOUND"))
{
    eKnife[HAS_CUSTOM_SOUND] = true
    copy(eKnife[STAB_SOUND], charsmax(eKnife[STAB_SOUND]), szValue)
    precache_sound(szValue)
} 


could be shortened to something like this:

PHP Code:

else 
                    {
                        eKnife[HAS_CUSTOM_SOUND] = true
                        precache_sound(szValue)
                        
                        if(equal(szKey, "DEPLOY_SOUND"))
                        {
                            copy(eKnife[DEPLOY_SOUND], charsmax(eKnife[DEPLOY_SOUND]), szValue)
                        }
                        else if(equal(szKey, "HIT_SOUND"))
                        {
                            copy(eKnife[HIT_SOUND], charsmax(eKnife[HIT_SOUND]), szValue)
                        }
                        else if(equal(szKey, "HITWALL_SOUND"))
                        {
                            copy(eKnife[HITWALL_SOUND], charsmax(eKnife[HITWALL_SOUND]), szValue)
                        }
                        else if(equal(szKey, "SLASH_SOUND"))
                        {
                            copy(eKnife[SLASH_SOUND], charsmax(eKnife[SLASH_SOUND]), szValue)
                        }
                        else if(equal(szKey, "STAB_SOUND"))
                        {
                            copy(eKnife[STAB_SOUND], charsmax(eKnife[STAB_SOUND]), szValue)
                        }
                    }
                } 


to avoid duplicated code.
(could also use a switch and check for specific characters instead of using if and equal, but not very important)

Be consistent with naming conventions: you have things like play_knife_sound, detect_knife_sound and then things like ColorChat, PushKnife, etc. Use one style.

[OciXCrom]

Originally Posted by HamletEagle ...

1. The code would look quite duplicated if it's in multiple lines. I'd rather have it like this. I added some indendation to make it more readable.

2. Done.

3. Not exactly like that, because it doesn't need to precache a sound every time. I changed it however so it's no longer duplicated.

PHP Code:

static const szModelArg[] = "_MODEL"
static const szSoundArg[] = "_SOUND"

if(contain(szKey, szModelArg))
    precache_model(szValue)
else if(contain(szKey, szSoundArg))
{
    eKnife[HAS_CUSTOM_SOUND] = true
    precache_sound(szValue)
} 


4. Done.