[Jhob94]

This thread should be locked and pinned @ Tutorials

[georgik57]

while (is_user_alive(id)) hit(id, id1)

[Bugsy]

Perfect

PHP Code:

if ( something ) 
{
}
else
{
} 


Not perfect

PHP Code:

if ( something ) {
}
else {
} 


[Jhob94]

Originally Posted by Bugsy Perfect PHP Code: if ( something )  { } else { }  Not perfect PHP Code: if ( something ) { } else { }

Your first statement, without spaces. Personally I find it harder to read and takes more time to type it. On a big plugin it will make the difference if you are running against time.

[EFFx]

Originally Posted by Bugsy Perfect PHP Code: if ( something )  { } else { }  Not perfect PHP Code: if ( something ) { } else { }

Agreed. But for some reason when I write in php or javascript I always do the second way... my brain changes the style when I write in any other language that is not PAWN.

Originally Posted by Jhob94 Your first statement, without spaces. Personally I find it harder to read and takes more time to type it. On a big plugin it will make the difference if you are running against time.

Everybody has their own style but the goal is always trying to make your code as easy to read as possible. That is a good practice even for you to debug and find possible issues with the code, specially if it is or will be an open source in the future.

[georgik57]

Originally Posted by Bugsy Perfect PHP Code: if ( something )  { } else { }  Not perfect PHP Code: if ( something ) { } else { }

+++ Minus the spaces inside the condition 😁

[WATCH_D0GS UNITED]

This entire thread has been disproved with a single line of code:

? :

[Bugsy]

Originally Posted by Jhob94 Your first statement, without spaces. Personally I find it harder to read and takes more time to type it. On a big plugin it will make the difference if you are running against time.

Yeah, I started padding with spaces years ago, I find it cleaner but everyone has their own preference.

It's harder to read and more time to type when you have the opening bracket on its own line, or the spaces? I hate looking at code that is all compacted together -- the spaces make it easier for me to read, and the time difference is negligible once you're used to it.

Originally Posted by WATCH_D0GS UNITED This entire thread has been disproved with a single line of code: ? :

Yes and no. Ternary conditions should only be used when appropriate, not as a replacement for all if-else conditions. The goal/intent of using them should not be to reduce the number of lines of code.

[mlibre]

PHP Code:

    if(..)
        //..
    else
        //.. 


at first I thought that simplifying the code would "improve" it in some way, but the truth is that it doesn't. is the same. so now I simply try to respect coerence by making the code more readable; can you imagine making a zp in a single line, what happens if it generates an error. good luck finding it.

[Jhob94]

Originally Posted by mlibre PHP Code:     if(..)         //..     else         //..  at first I thought that simplifying the code would "improve" it in some way, but the truth is that it doesn't. is the same. so now I simply try to respect coerence by making the code more readable; can you imagine making a zp in a single line, what happens if it generates an error. good luck finding it.

It’s all about organization. I usually make private functions to reduce the amount of code, specially when it’s duplicated code. A lot of code, even if readable will make it harder. As long as you organize well the code and give proper names to stuff it becomes easy.