[Dr. McKay]

Originally Posted by Powerlord Make the variables in this static on the off chance that a plugin is already using variables with these names.

Wouldn't work since both InitDebugLog and LogDebug need access.

Originally Posted by Powerlord Check if char works for single characters instead of using an int. (int flagChar = '0'; looks weird to say the least).

bool FindFlagChar(AdminFlag flag, int &c)

Would need to use view_as<int> anyway. I agree that it's weird but it is what it is.

Originally Posted by Powerlord adminFlag should be optional. After all, if you don't include DEBUG_ADMIN_CONSOLE or DEBUG_ADMIN_CHAT, it isn't used. Perhaps use ADMFLAG_GENERIC as the default value for adminFlag?

Agreed. Fixing.

Originally Posted by Powerlord Adjust InitDebugLog to process multiple admin flags correctly or convert it to use AdminFlag types in its signature instead. Right now, the BitToFlag line looks like it's going to barf if I pass in ADMFLAG_KICK|ADMFLAG_BAN for example. This is perfectly acceptable to CheckCommandAccess and will only match if an admin has both flags.

Done.

[Powerlord]

Originally Posted by Dr. McKay Wouldn't work since both InitDebugLog and LogDebug need access.

static on a global variable should restrict it to just the same file... which as far as I know includes stocks. I admit I haven't tried it on stocks, though, only regular functions.

[Chdata]

Originally Posted by ddhoward PHP Code: // define NO_DEBUG before including this file to completely disable all debugging #if defined NO_DEBUG  stock void InitDebugLog(const char[] convarName, const char[] debugTag, int adminFlag) { }  stock bool LogDebug(const char[] format, any ...) { return false; }  #endinput #endif  That is already a feature.

No... that still compiles it into your plugin, just making it return false all the time and do nothing. NOP NOP NOP

Originally Posted by Dr. McKay Good catch. Fixed. Also added an override with the same name as the cvar. I don't think that would be possible with LogDebug's variable number of parameters.

#if !defined DEBUG
    stock DebugMsg(any:...){}
    //#define DebugMsg(%1)
    #endinput
#endif

I do it like this, but that still compiles the function with a function call everywhere.

You can just do

#define DebugMsg 0

or something like that, and then it won't compile in your final binary, but you'll see compiler warnings.

[splewis]

Thanks for making this. I've never found a good way to have solid debug logging, but I really like this.

[Chdata]

Also, way to return .sp/.inc file name / line / function name like in errorlogs?

[ddhoward]

Originally Posted by Chdata Also, way to return .sp/.inc file name / line / function name like in errorlogs?

I'm fairly certain that you'd have to include that information yourself through the text passed to LogDebug().

[TnTSCS]

Chdata - that would be an awesome feature

[friagram]

Irony

[Chdata]

There was stuff in PAWN like __LINE__ and __FILE__ but they removed it.

[Alienmario]

I've improved upon the original include.

- Added cvar [basename]_parts which controls additional information that will be printed. Time, line, and tick count can be printed. Unfurtunately, I don't know a way to obtain which include called the log function. Time format can be passed in InitDebugLog.
- Set the default location of the location cvar to server console