[egor1908]

I have installed SMAC Core and Command module. I verified it running, and joined my server afterwards.
I didn't expect this, but i was able to lag my own server with the commands, which the command module should block.

What am i doing wrong?

On the other hand, RCON Locker blocks them succesfully by adding a cheat flag to the commands.

Why isn't SMAC working then?

[GoD-Tony]

The command module should be blocking abusive commands and then kicking anyone attempting to spam further than that.

How can I reproduce this issue?

[egor1908]

Thanks for the fast reply. I forgot to mention, this is a L4D2 server.

1. Get a clean server.
2. Install sourcemod, latest Downtown with 11 slots, latest sockets, latest sdk hooks. Install confogl but do not run it. Just vanilla. There is nothing special in server.cfg.
3. Install the core+command module.
4. I wanted the commands to be blocked only, so i set smac_antispam_cmds to 0.
   Well, restart your server and try to lag it.

I could do it without problems, tho i see the commands in the block list, the first part of the source code.


At first, before i even installed the server, i merged a few modules together in one plugin:

Core (as the base to put the other plugins in) AutoTrigger detection Command Cvar Protection Eye Angles Test Rcon Protection Anti Speedhack

(see attachment for the final result i used on my server).
I used the source of the release version, latest includes. It compiled without warnings or errors from the second try, as i fixed a few mistakes i did.

The final result loaded totally fine, but it was late, so i decided not to check for anything except lag commands, because i have them bound to a key. I also changed the "true" parameter on ban action to "false" (in the command module) so it would just block them.
The commands worked.

I thought i merge plugins like a ****, so i thought i would give the compiled version from the sticky post a try. Before doing so, i did not remove the auto-generated cfg file, as it had the needed settings already. I restarted the server, and i could still lag it.

As the last thing, i removed myself from admins, as i thought this could give me immunity (i didn't read the source code, it was faster to remove myself and reboot) but still the same.

PS: The plugin is loading and shows up under loaded plugins, no error logs (i had some before related to an extra quotation sign in the admin file), so the logs work, but SMAC isn't giving me any errors.

[Visual77]

and which commands are you talking about excatly?

edit: also, why are you using an inofficial compiled all in one file? that's maybe the problem,
you've forgot to copy n paste parts and it dosn't work?

[egor1908]

The ones, which RCON Locker adds a cheat flag to. If you repeat them, they make server lag.
I can post them, but don't want it to go more public then it already has gone.

Right now i decided to use RCON Locker for a while, until i find out what was wrong with SMAC.

[GoD-Tony]

I tested blocking commands and it seems to work. For example, this will successfully block suicides:

smac_addcmd kill 0

Originally Posted by egor1908 I can post them, but don't want it to go more public then it already has gone.

Can you PM me the specific commands you were testing with and I'll look into it?

[Visual77]

Originally Posted by egor1908 I wanted the commands to be blocked only, so i set smac_antispam_cmds to 0.

Ask me if I'm wrong but dosn't the value 0 disable it totally? Have you tried setting it to 5 or 10, then bind the lag command to a key and try?

You seem to be running a custom compiled plugin which might be the problem.
Is the official version having the same problem?

[egor1908]

Originally Posted by Visual77 Ask me if I'm wrong but dosn't the value 0 disable it totally? Have you tried setting it to 5 or 10, then bind the lag command to a key and try?

No, i have not tried to increase it above 0.
Sort of a mistake, i am going to check the documentation and source code now. There are people playing on the server atm.

But then if i want people not to get banned for spamming commands, what should i set it to, 9999999?


GoD-Tony
Sent it.

Originally Posted by Visual77 You seem to be running a custom compiled plugin which might be the problem. Is the official version having the same problem?

Yes, i said i tried the official smx from the download thread too. (Core+module).


UPDATE:

g_hCvarCmdSpam = SMAC_CreateConVar("smac_antispam_cmds", "0", "Amount of commands allowed in one second before kick. (0 = Disabled)", FCVAR_PLUGIN, true, 0.0);

By the way, this is how it says in there. According to the description, only the kick should be disabled, not the whole command module.

L4D2 fixes are obsolete by the way, valve already fixed the pistol-spam thing.

[Visual77]

On L4D2 I have the spam cmd set to 8 with exceptions for these
and I only get a few kicks every day. Most of them are from people that have stuff binded like sm_laser, etc.
I'd recommend setting spam to either 8-15 because 30 most certainly does nothing.

SetTrieValue(g_hIgnoredCmds, "vocalize",			true);
SetTrieValue(g_hIgnoredCmds, "spec_next",		        true);
SetTrieValue(g_hIgnoredCmds, "spec_prev",		        true);

[GoD-Tony]

Originally Posted by egor1908 No, i have not tried to increase it above 0. Sort of a mistake, i am going to check the documentation and source code now. There are people playing on the server atm. But then if i want people not to get banned for spamming commands, what should i set it to, 9999999?

The default of 30 will solve your problem and only kick players that are really spamming.

Originally Posted by egor1908 GoD-Tony Sent it.

I'll look into it, thanks.