Raised This Month: $51 Target: $400
 12% 

Rcon locker / exploit fix


Post New Thread Reply   
 
Thread Tools Display Modes
-M-Jon
Member
Join Date: Dec 2009
Old 05-04-2010 , 05:09   Re: Rcon locker / exploit fix
Reply With Quote #371

Does this plugin provide any benefit for administrators whom are able to put the rcon password in their command line?
-M-Jon is offline
dataviruset
AlliedModders Donor
Join Date: Feb 2009
Location: Hong Kong
Old 05-04-2010 , 06:14   Re: Rcon locker / exploit fix
Reply With Quote #372

Quote:
Originally Posted by -M-Jon View Post
Does this plugin provide any benefit for administrators whom are able to put the rcon password in their command line?
Of course, this plugin is much more than just an rcon locker, it fixes several known exploits!
dataviruset is offline
dirka_dirka
Veteran Member
Join Date: Nov 2009
Old 05-05-2010 , 23:59   Re: Rcon locker / exploit fix
Reply With Quote #373

new version of hlsw came out so i tried a say command..
got invalid client 0 error

how about putting a if (!client) return; in that Cmd_Say routine.
dirka_dirka is offline
dataviruset
AlliedModders Donor
Join Date: Feb 2009
Location: Hong Kong
Old 05-06-2010 , 02:47   Re: Rcon locker / exploit fix
Reply With Quote #374

Wouldn't this be enough?

if (client != 0) {
// ...
}
dataviruset is offline
dirka_dirka
Veteran Member
Join Date: Nov 2009
Old 05-06-2010 , 10:35   Re: Rcon locker / exploit fix
Reply With Quote #375

its the same basically.. except it nests the entire action inside the check and skips to the end.. my suggestion just bypasses it all together.
dirka_dirka is offline
dataviruset
AlliedModders Donor
Join Date: Feb 2009
Location: Hong Kong
Old 05-06-2010 , 11:45   Re: Rcon locker / exploit fix
Reply With Quote #376

I beg your pardon?

I would say this is the solution... But I might have missed something.

PHP Code:
public Action:Cmd_Say(client, const String:command[], argc)
{
    if ( (
client != 0) && (IsFakeClient(client) || !IsClientInGame(client)) ) return Plugin_Stop;
    new 
String:fulltext[2048];
    
GetCmdArgString(fulltext,sizeof(fulltext));
    if (
StrContains(fulltext,"\r") != -|| StrContains(fulltext,"\n") != -1)
    {
        
ReplaceString(fulltext,sizeof(fulltext),"\r","");
        
ReplaceString(fulltext,sizeof(fulltext),"\n","");
        
LogMessage("Client '%L' tried to send a message with newlines.  Message was: %s",client,fulltext);
        
PrintToChat(client,"Newlines in messages are not permitted on this server.");
        return 
Plugin_Stop;
    }
    return 
Plugin_Continue;


Last edited by dataviruset; 05-06-2010 at 11:47. Reason: Posted too quickly :D
dataviruset is offline
lindo81
BANNED
Join Date: Feb 2010
Old 05-06-2010 , 11:47   Re: Rcon locker / exploit fix
Reply With Quote #377

it's gonna be good some of you to fix the plugins itself because most of us do not know what to do with this code
lindo81 is offline
Bacardi
Veteran Member
Join Date: Jan 2010
Location: mom's basement
Old 05-06-2010 , 14:33   Re: Rcon locker / exploit fix
Reply With Quote #378

Quote:
Originally Posted by dataviruset View Post
I beg your pardon?

I would say this is the solution... But I might have missed something.
Work great, 1 less errors <3

Tip, open rcon_lock.sp file and find line 305...
Bacardi is offline
dataviruset
AlliedModders Donor
Join Date: Feb 2009
Location: Hong Kong
Old 05-06-2010 , 14:43   Re: Rcon locker / exploit fix
Reply With Quote #379

Well, here's the file...
Attached Files
File Type: sp Get Plugin or Get Source (rcon_lock-dataviruset.sp - 279 views - 13.1 KB)
dataviruset is offline
devicenull
Veteran Member
Join Date: Mar 2004
Location: CT
Old 05-06-2010 , 17:45   Re: Rcon locker / exploit fix
Reply With Quote #380

I've been busy lately, and didn't get a chance to look at this until now. I've updated the plugin to fix the console say issue. New version is 0.6.6

The fix posted by datavirusset will prevent any sort of chat from rcon from working.
__________________
Various bits of semi-useful code in a bunch of languages: http://code.devicenull.org/
devicenull is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 07:40.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode