[Powerlord]

...and that would be because AddDependency only makes sure the other extension is loaded when it's called instead of what its documentation says it does.

The linked function is called directly by ShareSys::AddDependency in case you're wondering.

I guess the only way to actually track dependencies in an extension is to implement NotifyInterfaceDrop and make sure your dependencies don't suddenly get pulled out from under you.

[Powerlord]

Just a heads up: If you use DHooks, don't call DHookRemoveHookID in OnPluginEnd... SourceMod will auto-close those handles for you. If you do try to close them in OnPluginEnd, it can lead to server crashes when the server is shutting down.

Still looking into why SourceMod chokes on freeing DHooks handles if you manually unload the extension, though... (already think I fixed the SDKHooks unloading before DHooks crash on server shutdown)

[Powerlord]

OK, so now that Drifter merged those changes into his repository, I've made one last change before I posted it here... I changed the version number to 1.0.14-alpha.

Source Code is here (except the version number change in smsdk_confg.h)

Changes

• Fix memory leak where Listener objects were never deleted.
• Extension will now properly stop when one of its dependencies are unloaded (SDKTools or SDKHooks)
• The extension will no longer cause the server to crash when it unloads if SDKHooks was unloaded first. This commonly caused the server to crash when the server was shutdown.

Things not fixed:

• Manually unloading the extension will cause the server to crash. This is a bug in SourceMod's Handle system that is fixed in the SourceMod development versions (1.6.0).

[Morten]

Are there any examples of using the raw hook type in Dhooks? I'm trying to hook several functions in the CCSBOT class. I can find the offset and even signatures of the functions, but I'm not sure how to find the base address of the ccsbot class.

For instance:

new Address:addr = GameConfGetAddress(temp, "CSSBOT"); <- how do i find this? 
new offset = GameConfGetOffset(temp, "OnUpdate"); 
hUpdate = DHookCreate(offset, HookType_Raw, ReturnType_Void, ThisPointer_Ignore, OnUpdate); 
DHookRaw(hUpdate, true, addr, RemovalCB);

Any help would be appreciated :-)

Best regards
Morten

[Powerlord]

DHooks 1.0.13 (or 1.0.14 as I changed its version to) is crashing Team Fortress 2 on startup since yesterday's update. I haven't compiled a debug copy to find out what's going on with it yet. More information when I have it.

Edit: Ladies and Gentlemen, we have a Heisenbug. It doesn't crash when I recompile it for Debug.

Edit 2: Apparently my copy on my server somehow got corrupted despite working just fine yesterday.

[AeroAcrobat]

is it save to use 1.0.14-alpha and upgrade to sm stable 1.6?
Was reading this: https://forums.alliedmods.net/showpo...7&postcount=10

[KyleS]

Originally Posted by AeroAcrobat is it save to use 1.0.14-alpha and upgrade to sm stable 1.6? Was reading this: https://forums.alliedmods.net/showpo...7&postcount=10

There's a new version that is less tested but was rewritten from scratch. Most of the memory leaks and related issues should be solved.

https://bitbucket.org/Drifter321/dhooks2/overview

As to Powerlord's issue, it's most likely related to the software he's running. There are snapshot builds ~somewhere~.


EDIT: I've been running DHooks1 throughout the development of 1.6 and I'm totally fine (besides the known issues).

[Powerlord]

Originally Posted by KyleS As to Powerlord's issue, it's most likely related to the software he's running. There are snapshot builds ~somewhere~.

And yet, DHooks does have something to do with it as removing DHooks 1.0.14 makes my server stop crashing on shutdown. Having said that, using a debug version of dhooks doesn't give me any additional information as it doesn't appear in the backtrace.

Last I checked, there weren't any compiled versions of dhooks2 around anywhere.

Anyway, there may be issues compiling dhooks2 right now as apparently the include paths are currently missing an include (the AMTL includes?) and am-vector.h is required by sourcemod/public/jit/x86/macro-assembler-x86.h, which in turn is required by extension.cpp

Edit: And other fun Makefile bugs for the Linux version.

*sigh* the dhooks2 repo doesn't have an issue tracker, only the dhooks repo does.

[Powerlord]

Incidentally, even after updating DHooks to 2.0 and fixing the Linux compilation issues it had (and submitting a pull request with said fixes), and compiling it using clang instead of gcc, my server still crashes on shutdown in metamod if DHooks is loaded.

I may go into core.cfg and see if I can get a real stack trace by disabling some of the new 1.6 options.

[Powerlord]

Originally Posted by KyleS There's a new version that is less tested but was rewritten from scratch. Most of the memory leaks and related issues should be solved. https://bitbucket.org/Drifter321/dhooks2/overview As to Powerlord's issue, it's most likely related to the software he's running. There are snapshot builds ~somewhere~. EDIT: I've been running DHooks1 throughout the development of 1.6 and I'm totally fine (besides the known issues).

In that case, can you do me a favor and compile DHooks on Linux for me? Snapshot builds don't seem to exist anywhere... at least not ones that won't already crash on shutdown because SDKHooks tends to unload before DHooks does and then DHooks tries to use an SDKHooks pointer as it shuts down.

Having said that, the only plugins I've tried are ones that use GameRules hooks... PropHunt Redux and Respawn Wave Time Fix. If either are present, MetaMod crashes during shutdown. Perhaps it only happens with DHooks GameRules hooks?