Raised This Month: $12 Target: $400
 3% 

[New Plugin Submissions] Help needed


Post New Thread Reply   
 
Thread Tools Display Modes
OciXCrom
Veteran Member
Join Date: Oct 2013
Location: Macedonia
Old 04-07-2020 , 15:38   Re: [New Plugin Submissions] Help needed
Reply With Quote #11

https://forums.alliedmods.net/showthread.php?t=304948 - way too simple; nothing special.
https://forums.alliedmods.net/showthread.php?t=302969 - too many like this exist already; the code is nothing to get excited about.
https://forums.alliedmods.net/showthread.php?t=302333 - the plugin is removed.
https://forums.alliedmods.net/showthread.php?t=235101 - easily a better altenative combined with this.
https://forums.alliedmods.net/showthread.php?t=300752 - hardcoded; better alternative.
https://forums.alliedmods.net/showthread.php?t=301363 - trash.
https://forums.alliedmods.net/showthread.php?t=300646 - I don't see any plugin here.
https://forums.alliedmods.net/showthread.php?t=299193 - you linked a better alternative yourself.
https://forums.alliedmods.net/showthread.php?t=298600 - overall bad.
https://forums.alliedmods.net/showthread.php?t=295553 - hardcoded and poorly coded; a few alternatives already exist.
https://forums.alliedmods.net/showthread.php?t=285005 - overall bad coding.
https://forums.alliedmods.net/showthread.php?t=293915 - still a better alternative.
https://forums.alliedmods.net/showthread.php?t=293331 - SourceMod.
https://forums.alliedmods.net/showthread.php?t=289606 - good joke, but probably no place in the approved section for it.
https://forums.alliedmods.net/showthread.php?t=289555 - trash.
https://forums.alliedmods.net/showthread.php?t=289229 - redundant; non-English.
https://forums.alliedmods.net/showthread.php?t=287317 - download link not working.
https://forums.alliedmods.net/showthread.php?t=286935 - all changes from the original plugin are removed features, nothing new is added.
https://forums.alliedmods.net/showthread.php?t=197347 - another hardcoded XP system.
https://forums.alliedmods.net/showthread.php?t=285483 - trash.
https://forums.alliedmods.net/showthread.php?t=284888 - trash.
https://forums.alliedmods.net/showthread.php?t=279897 - one of the better alternatives.
https://forums.alliedmods.net/showthread.php?t=279723 - redundant.
https://forums.alliedmods.net/showthread.php?t=279734 - 404 plugin not found.
https://forums.alliedmods.net/showthread.php?t=279145 - what's the point of this?
https://forums.alliedmods.net/showthread.php?t=277249 - trash.
https://forums.alliedmods.net/showthread.php?t=272580 - seems like another silly menu.
https://forums.alliedmods.net/showthread.php?t=253046 - redundant and bad coding; team management plugins exist.
https://forums.alliedmods.net/showthread.php?t=262540 - hardcoded; there are entire shop APIs available (1, 2).
https://forums.alliedmods.net/showthread.php?t=260937 - better alternative.
https://forums.alliedmods.net/showthread.php?t=294300 - same as above; unapprove for now.
https://forums.alliedmods.net/showthread.php?t=255176 - not enough changes from original plugin.
https://forums.alliedmods.net/showthread.php?t=244268 - plugin is removed.
https://forums.alliedmods.net/showthread.php?t=220982 - same thing, more functionality.
https://forums.alliedmods.net/showthread.php?t=214206 - amx_default_access cvar?!
https://forums.alliedmods.net/showthread.php?t=235307 - redundant.
https://forums.alliedmods.net/showthread.php?t=179784 - this one has more options.

That's pretty much it for the obvious ones.
__________________

Last edited by OciXCrom; 04-07-2020 at 18:22.
OciXCrom is offline
Send a message via Skype™ to OciXCrom
+ARUKARI-
AlliedModders Donor
Join Date: Jul 2004
Location: Japan
Old 04-07-2020 , 21:34   Re: [New Plugin Submissions] Help needed
Reply With Quote #12

https://forums.alliedmods.net/showthread.php?t=317395 ReAPI
https://forums.alliedmods.net/showthread.php?t=312774 Non - Steam

https://forums.alliedmods.net/showthread.php?t=294778
https://forums.alliedmods.net/showthread.php?t=252101

=> https://forums.alliedmods.net/showthread.php?t=12106
I'm active now so I can support if needed.
__________________
GitHub
SteamWishlist

六四天安門事件

Last edited by +ARUKARI-; 04-12-2020 at 21:22.
+ARUKARI- is offline
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 04-08-2020 , 06:49   Re: [New Plugin Submissions] Help needed
Reply With Quote #13

There are probably 10-15 plugins left from all the lists, but on the bright side we cleaned 5 pages in no time.
I'll sort soon the remaining plugins too, they just need a bit more time invested in deciding what to do.
__________________

Last edited by HamletEagle; 04-08-2020 at 06:49.
HamletEagle is offline
thEsp
BANNED
Join Date: Aug 2017
Old 04-08-2020 , 09:56   Re: [New Plugin Submissions] Help needed
Reply With Quote #14

I will add a few more plugins if that is allowed:

1. https://forums.alliedmods.net/showthread.php?t=294858 - Redundant and hard-coded.
2. https://forums.alliedmods.net/showthread.php?t=321698 - Has 3 alternatives.
3. https://forums.alliedmods.net/showthread.php?t=281385 - Has many alternatives. Author is seemingly inactive.
4. https://forums.alliedmods.net/showthread.php?t=316698 - Can be done without ReApi.
5. https://forums.alliedmods.net/showthread.php?t=312395 - Already exists, pointless, inactive (?) author. It's pointless because a such simple plugin doesn't need ML system, nor configuration files.

p.s I publicly ask all admins of this holy & whole forum to raise Hamlet's forum access. AMXX shouldn't be ignored and overshadowed by or because of SM, if you get my point.

Last edited by thEsp; 04-08-2020 at 10:20. Reason: mistake
thEsp is offline
Napoleon_be
Veteran Member
Join Date: Jul 2011
Location: Belgium
Old 04-08-2020 , 10:16   Re: [New Plugin Submissions] Help needed
Reply With Quote #15

Quote:
Originally Posted by thEsp View Post
p.s I publicly ask all admins of this holy & whole forum to raise Hamlet's forum access. AMXX shouldn't be ignored and overshadowed by or because of SM, if you get my point.
^
__________________
Napoleon_be is offline
Send a message via Skype™ to Napoleon_be
OciXCrom
Veteran Member
Join Date: Oct 2013
Location: Macedonia
Old 04-08-2020 , 14:51   Re: [New Plugin Submissions] Help needed
Reply With Quote #16

After the obvious threads (the ones who fit one of the 7 criteria) have been dealt with, should we start focusing on other stuff?

Here are some additional easy-to-spot criteria I would take in mind when reviewing by today standards:
  • No multilingual support for in-game messages.
  • The settings are defined in the .sma file instead of using cvars/config files.
  • Using "magic numbers" instead of constants/charsmax/etc.

Not saying that such plugins should be unapproved right away, but you could leave a message in the thread saying that these things need to be changed and wait for a response from the author, giving him a set amount of days to make the changes.

There are many plugins like this, so this should speed up the process.
__________________

Last edited by OciXCrom; 04-08-2020 at 14:51.
OciXCrom is offline
Send a message via Skype™ to OciXCrom
HamletEagle
AMX Mod X Plugin Approver
Join Date: Sep 2013
Location: Romania
Old 04-09-2020 , 04:54   Re: [New Plugin Submissions] Help needed
Reply With Quote #17

@thEsp, again, please link to similar plugins.
For example, what are the alternatives for https://forums.alliedmods.net/showthread.php?t=321698 ?

@OciXCrom, let me deal with the rest of the threads first and then we'll see what we will do. One thing is for sure, we won't stop here.
__________________

Last edited by HamletEagle; 04-09-2020 at 04:55.
HamletEagle is offline
Mordekay
Squirrel of Fortune
Join Date: Apr 2006
Location: Germany
Old 04-09-2020 , 04:58   Re: [New Plugin Submissions] Help needed
Reply With Quote #18

Luckily someone already posted them in the first reply:
https://forums.alliedmods.net/showthread.php?p=610698
https://forums.alliedmods.net/showthread.php?p=754908
https://forums.alliedmods.net/showthread.php?p=618307
__________________

Mordekay is offline
thEsp
BANNED
Join Date: Aug 2017
Old 04-09-2020 , 05:33   Re: [New Plugin Submissions] Help needed
Reply With Quote #19

I do agree with Oci to an extent. Albeit I don't think every plugin that sends messages to players should have ML system support, plugins shouldn't be limited (hard-coded means something else) inside. That is if the plugin isn't short, of course.

For example, the plugin I sent you https://forums.alliedmods.net/showthread.php?t=294858 is totally limited to recompiling. That means, if you want to change something, you have to re-compile it. Some people have been sending bug reports and the author hasn't fixed them yet (he's inactive for quiet some time).

@Hamlet
I am sorry but I thought you'd already figure out the #1 post in that thread.

Last edited by thEsp; 04-09-2020 at 05:34.
thEsp is offline
OciXCrom
Veteran Member
Join Date: Oct 2013
Location: Macedonia
Old 04-09-2020 , 09:55   Re: [New Plugin Submissions] Help needed
Reply With Quote #20

https://forums.alliedmods.net/showthread.php?t=249160 - bad code; too simple to be approved.
https://forums.alliedmods.net/showthread.php?t=242344 - lacks (proper) description.
https://forums.alliedmods.net/showthread.php?t=249538 - the plugin has ~40 cvars, none of them are mentioned in the thread.
https://forums.alliedmods.net/showthread.php?t=271179 - not a standalone plugin; lacks description on how to run; non-English messages inside the plugin.
https://forums.alliedmods.net/showthread.php?t=187274 - more advanced version here.
https://forums.alliedmods.net/showthread.php?t=143645 - too simple; more advanced plugins exist (example).
https://forums.alliedmods.net/showthread.php?t=312786 - same as above.
https://forums.alliedmods.net/showthread.php?t=182799 - not enough changes from original code; most of them can be done with the default plugin; better alternative.
https://forums.alliedmods.net/showthread.php?t=244222 - doesn't look complex enough; usage of magic numbers; overall bad coding.
https://forums.alliedmods.net/showthread.php?t=280744 - joke plugin; looks like something that can give players a seizure
https://forums.alliedmods.net/showthread.php?t=279614 - not sure about this one; code looks very good and has many useful features, but we already have an approved knife plugin which when combined with this and this exceeds its possibilities by a lot and contains all of its features.
https://forums.alliedmods.net/showthread.php?t=285015 - looks too simple in comparison to other XP plugins.
https://forums.alliedmods.net/showthread.php?t=290169 - too simple; hardcoded and poorly coded.
https://forums.alliedmods.net/showthread.php?t=289440 - reduntant; more advanced plugins exist.
https://forums.alliedmods.net/showthread.php?t=279756 - trash.

@thEsp - although it's not something that will make the code itself better, it definitely helps reach more people that may not understand English; makes the end-user able to modify the messages without touching the .sma file and engages other people to easily contribute to the plugin.

I think we should have more strict standards like the ones I mentioned. Maybe even create a new thread with some general rules and requirements. I know there's one made back in 2005, but AMXX coding standards have changed a lot since then.
__________________

Last edited by OciXCrom; 04-09-2020 at 09:56.
OciXCrom is offline
Send a message via Skype™ to OciXCrom
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 04:02.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode