[eyal282]

So I don't like the fact that you can't delete lines from a file so I made this stock and plugin to fix it.

Example usage:

PHP Code:

new File[150];
get_localinfo("amxx_datadir", File, charsmax(File)); // This is equal to get_datadir without include.

formatex(File, charsmax(File), "%s/Test", File);

if(!dir_exists(File))
    mkdir(File); // Creates the directory.

formatex(File, charsmax(File), "%s/Test.txt", File);

// Use this to delete all empty lines.
delete_file_lines(File);

// Use this to delete lines 1, 3, 5.
delete_file_lines(File, {1, 3, 5})

// Use this to delete lines from array.
new Lines[5] = {1, 5, 7, 4, 2};
delete_file_lines(File, Lines); 


Explanation of arguments:

PHP Code:

// File[150] = File to delete lines from.
// Lines[] = Array with all lines to delete. Leave empty to remove empty lines.

// return -1 if deleting has failed, otherwise returns amount of lines deleted ( or zero lines ) 


Give thoughts on the snippet and lots of hating criticism.

Notes:

1. Because of AmxModX's limits, do not use files with lines with over 500 letters in them.
2. Do not use often as this stock is quite large in CPU usage.
3. I could not properly check the plugin, so if you find a bug notify me.

The stock:

Spoiler

PHP Code:


// File[150] = File to delete lines from.
// Lines[] = Array with all lines to delete. Leave empty to remove empty lines.

// return -1 if deleting has failed, otherwise returns amount of lines deleted ( or zero lines )
stock delete_file_lines(File[150], Lines[]=0)
{
    if(!file_exists(File))
        return -1;

    new Txt[5], strlenFile = strlen(File);
    new NumberOfTempFile = 1, LengthAtDot, FileEnd[15], TempFile[155];
    
    formatex(TempFile, charsmax(TempFile), File);
    for(new i = strlenFile;i >= 0;i--)
    {
        if(File[i] == '.')
        {
            for(new ii=0,e=i;e < strlenFile;ii++,e++)
            {
                FileEnd[ii] = File[e];
            }
            formatex(TempFile, i, File);
            LengthAtDot = i;
            
            break;
        }
    }
    
    add(TempFile, charsmax(TempFile), "1");
    add(TempFile, charsmax(TempFile), FileEnd);
    do
    {
        TempFile[LengthAtDot] = EOS;
        formatex(Txt, 4, "%i", NumberOfTempFile);
        add(TempFile, charsmax(File), Txt);
        add(TempFile, charsmax(File), FileEnd);
        NumberOfTempFile++;
    }
    while(file_exists(TempFile))
    
    if(file_exists(TempFile)) // Something went wrong.
        return -1;
    
    new FilePointer = fopen(File, "rt");
    new TempFilePointer = fopen(TempFile, "at+");
    
    if(!FilePointer || !TempFilePointer)
        return -1;
        
    new LinesDestroyed, CurrentLine, Text[2][500]; // Text[0] = original, Text[1] = copy
    new bool:StripSpaces = !Lines[0];
    new NextLine = StripSpaces ? 0 : Lines[0], LinesLength = StripSpaces ? 0 : strlen(Lines);

    while(fgets(FilePointer, Text[0], charsmax(Text[])))
    {        
        if(!StripSpaces && LinesLength == LinesDestroyed)
            break;
            
        CurrentLine++;
        
        formatex(Text[1], charsmax(Text[]), Text[0]);
        
        trim(Text[1]);
            
        if( ( !StripSpaces && CurrentLine == NextLine ) || ( StripSpaces && !Text[1] ) )
        {
            LinesDestroyed++;
            NextLine = StripSpaces ? 0 : Lines[LinesDestroyed];
            continue;
        }    

        fputs(TempFilePointer, Text[0]);

    }
        
    fclose(FilePointer);
    fclose(TempFilePointer);
    
    delete_file(File);
    
    if(!rename_file(TempFile, File, 1))
        return -1;
    
    return LinesDestroyed;
} 


[HamletEagle]

PHP Code:

stock RemoveLine(const FileName[], const Line[])
{
    new const TempFileName[] = "tempfile.ini"

    static ConfigDirPath[128]; 
    if(ConfigDirPath[0] == EOS)
    {
        get_configsdir(ConfigDirPath, charsmax(ConfigDirPath))
    }
    
    new FullPath[256]; 
    formatex(FullPath, charsmax(FullPath), "%s/%s", ConfigDirPath, FileName)

    new FilePointer = fopen(FullPath, "rt")
    if(FilePointer)
    {
        new TempFilePath[256]; 
        formatex(TempFilePath, charsmax(TempFilePath), "%s/%s", ConfigDirPath, TempFileName)
        
        new InputFilePointer = fopen(TempFilePath, "wt")
        if(InputFilePointer)
        {
            new FileData[128]
            while(!feof(FilePointer))
            {
                fgets(FilePointer, FileData, charsmax(FileData))
                trim(FileData)
                
                if(equal(FileData, Line))
                {
                    continue
                }
                
                fprintf(InputFilePointer, "%s^n", FileData)
            }
            
            fclose(InputFilePointer)
            fclose(FilePointer)

            delete_file(FullPath)
            rename_file(TempFilePath, FullPath, 1)
            
            return 1
        }
    }
    return 0
} 


I did something like this long time ago. Maybe you want to take a look at it. Right now it removes a specific line from file, but it can be edited to remove multiple lines by using a bi dimensional array.
I did not read your code, just rapidly looked at it and there may be things can be done a lot simpler.

[eyal282]

Originally Posted by HamletEagle PHP Code: stock RemoveLine(const FileName[], const Line[]) {     new const TempFileName[] = "tempfile.ini"     static ConfigDirPath[128];      if(ConfigDirPath[0] == EOS)     {         get_configsdir(ConfigDirPath, charsmax(ConfigDirPath))     }          new FullPath[256];      formatex(FullPath, charsmax(FullPath), "%s/%s", ConfigDirPath, FileName)     new FilePointer = fopen(FullPath, "rt")     if(FilePointer)     {         new TempFilePath[256];          formatex(TempFilePath, charsmax(TempFilePath), "%s/%s", ConfigDirPath, TempFileName)                  new InputFilePointer = fopen(TempFilePath, "wt")         if(InputFilePointer)         {             new FileData[128]             while(!feof(FilePointer))             {                 fgets(FilePointer, FileData, charsmax(FileData))                 trim(FileData)                                  if(equal(FileData, Line))                 {                     continue                 }                                  fprintf(InputFilePointer, "%s^n", FileData)             }                          fclose(InputFilePointer)             fclose(FilePointer)             delete_file(FullPath)             rename_file(TempFilePath, FullPath, 1)                          return 1         }     }     return 0 }  I did something like this long time ago. Maybe you want to take a look at it. Right now it removes a specific line from file, but it can be edited to remove multiple lines by using a bi dimensional array. I did not read your code, just rapidly looked at it and there may be things can be done a lot simpler.

If your temp file already exists, from my very low knowledge of new file edit system, something bad would happen. My code checks 10000 temp files for at least one that doesn't exist.

Isn't the end of file check already made in fgets?

[EFFx]

Oh it's gonna be a useful stock. Can't wait to use it, gj.

[fysiks]

I don't think that this one function merits a whole plugin with a single native. A stock would probably make more sense.

Also, you are corrupting the file's contents by using trim() on each line. When you are simply deleting a line, you should not modify any other data in that file.

[eyal282]

Originally Posted by fysiks I don't think that this one function merits a whole plugin with a single native. A stock would probably make more sense. Also, you are corrupting the file's contents by using trim() on each line. When you are simply deleting a line, you should not modify any other data in that file.

Without trim, every line is empty only if Text[1] == EOS which created problems for me.

[klippy]

You can do whatever with a copy of the string, but don't change the original.

[eyal282]

Originally Posted by KliPPy You can do whatever with a copy of the string, but don't change the original.

Done.

[fysiks]

formatex() requires that you don't use the output variable as an input. If you do use the same variable in both places, you must use format().

[HamletEagle]

If your temp file already exists, from my very low knowledge of new file edit system, something bad would happen. My code checks 10000 temp files for at least one that doesn't exist.

You are over thinking. But if you are so concerned about that, give it a more random name.

Isn't the end of file check already made in fgets?

I prefer to use feof, but it will work with fgets too.