[Audite]

Hi! I'm trying to create my own beacon plugin that checks how many T are left and if only 1 left then add beacon on the last T client.

public Action Event_PlayerDeath(Event event, const char[] name, bool dontBroadcast){
	for (int i = 1; i <= MaxClients; i++)
	{
		int iTeam;

		// Skip bots or non connected indexes.
		if (!IsClientConnected(i) || IsFakeClient(i))
			continue;

		iTeam = GetClientTeam(i);

		if(iTeam == CS_TEAM_T){
			//CHECK HOW MANY ALIVE, IF 1 LEFT PUT BEACON ON THE CLIENT
		}

	}
}

I'm using death hook for reason that if there is 1 player in T and 1 in CT it does not activate.

I'm completely new to sourcepawn and trying to figure stuff out Thanks in advance.

[Marttt]

Didn't test but would be something like this.

PHP Code:

    int aliveCTCount;
    int aliveTCount;
    int lastTClient;
    
    for (int client = 1; client <= MaxClients; client++)
    {
        if (!IsClientInGame(client))
            continue;
        
        if (IsFakeClient(client))
            continue;
        
        if (!IsPlayerAlive(client))
            continue;
        
        if (GetClientTeam(client) == CS_TEAM_CT)
        {
            aliveCTCount++;
        }
        else if (GetClientTeam(client) == CS_TEAM_T)
        {
            aliveTCount++;
            lastTClient = client;
        }
    }
    
    if (aliveCTCount == 1 && aliveTCount == 1)
    {
        PerformBeacon(lastTClient) //Your logic here
    } 


[Bacardi]

For readable code, above post is good example.



This example is just... with trick.

PHP Code:


public void OnPluginStart()
{
    HookEvent("player_death", player_death);
}

public void player_death(Event event, const char[] name, bool dontBroadcast)
{
    int lastT = -1;
    int CTcount = 0;
    int team;

    for(int i = 1; i <= MaxClients; i++)
    {
        if(!IsClientInGame(i))
            continue;
        
        team = GetClientTeam(i);
        
        if(team < 2 || !IsPlayerAlive(i))
            continue;



        if(team == 2)
        {
            if(lastT == -1)
            {
                // We store player index in variable, first time.
                lastT = i;
            }
            else
            {
                // When there are more than one T alive in team, this variable will get reset (-2)
                lastT = -2;
            }
        }
        else
        {
            CTcount++;
        }
    }

    if(lastT > 0 && CTcount > 1)
    {
        ServerCommand("sm_beacon #%i", GetClientUserId(lastT));
    }
} 


[Grey83]

Bacardi, we can improve the algorithm a little more:

PHP Code:

public void OnPluginStart()
{
    HookEvent("player_death", Event_Death, EventHookMode_PostNoCopy);
}

public void Event_Death(Event event, const char[] name, bool dontBroadcast)
{
    int lastT, CTcount;
    for(int i = 1, team; i <= MaxClients; i++) if(IsClientInGame(i) && (team = GetClientTeam(i)) > 1 && IsPlayerAlive(i))
    {
        if(team == 2)
        {
            if(!lastT) lastT = i;    // We store player index in variable, first time.
            else if(lastT) return;    // More than one alive terrorist. No more need checks.
        }
        else CTcount++;
    }

    if(CTcount > 1) ServerCommand("sm_beacon #%i", GetClientUserId(lastT));
} 


[Bacardi]

That for loop and if statement is wierdest thing I have seen in web

[Marttt]

Micro-optimizations like this don't bring many advantages.
Readability and a clean code, IMO - based IRL daily experience - should be a priority instead of the code lines amount, especially in a death hook event.
(unless you are in a big and repeatable loop)
But, EventHookMode_PostNoCopy was a good catch.
Anyway, all snippets are good examples of how to achieve what OP wants.

[Audite]

Thank you everyone. I got to see all the possible ways to do it! Thanks!