[Supremache]

Hi all,
I have question i trying to make a code for check vip members in the chat but i had a small issue when compared vips number with max array number as example:

PHP Code:

@OnVipsOnline( id )
{
    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iPlayer, iNum;
    formatex( szBuffer, charsmax( szBuffer ), "&x04Online:&x01 " );
    
    get_players( szPlayers, iNum , "ch" ); // iNum = it is max player numbers in the server if i used it any where in the loop it also return all players in the server

    for( new iIndex, i; i < iNum; i++  )
    {
        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) /* Check who has a vip flag */  ][ VIP ] & g_iSettings[ Access_OnlineList ] )
        { // i tried to compare iIndex with iNum and it work like adding symbol (,)  behinde all player names and another symbol (.) to the last player but work only when all players has that vip flag in the server so if anyone does not have that flag will add symbol (,) till if it was the last player
// I tried these ways but didn't work
            format( szBuffer, charsmax( szBuffer ), "%s%s%s", szBuffer, g_iPlayer[ iIndex ][ Name ], iNum < ( iPlayer = iIndex /* return the vip numbers */ ) ? ", " : "." );
            format( szBuffer, charsmax( szBuffer ), "%s%s%s", szBuffer, g_iPlayer[ iIndex ][ Name ], ( ( iPlayer = iIndex ) < iNum ? ( iIndex <= iNum < iIndex ) : ( iIndex <= iNum || iNum < iIndex ) ) ? ", " : "." );
            format( szBuffer, charsmax( szBuffer ), "%s%s%s", szBuffer, g_iPlayer[ iIndex ][ Name ], iNum == ( iPlayer = iIndex ) ? "." : ", " );
        }
    }
    
    if( !iPlayer )
    {
        add( szBuffer, charsmax( szBuffer ), "There are no vip's online." );
    }
    
    CC_SendMessage( id, szBuffer );
} 


I can do this with two loop but i think it's possible to do it with just one loop.

[jimaway]

new istrlen
for( new iIndex, i; i < iNum; i++  )
    {
        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) /* Check who has a vip flag */  ][ VIP ] & g_iSettings[ Access_OnlineList ] )
        { 
            istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s,",g_iPlayer[ iIndex ][ Name ]);
        }
    }
szBuffer[istrlen-1] = '.'

[Supremache]

Originally Posted by jimaway new istrlen for( new iIndex, i; i < iNum; i++  )     {         if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) /* Check who has a vip flag */  ][ VIP ] & g_iSettings[ Access_OnlineList ] )         {             istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s,",g_iPlayer[ iIndex ][ Name ]);         }     } szBuffer[istrlen-1] = '.'

It's not what i want, what i want is adding symbol ( , ) after vip names except for the last one without creating a double loop in the same function

[jimaway]

Originally Posted by Supremache what i want is adding symbol ( , ) after vip names except for the last one without creating a double loop in the same function

that's exactly what it does

[Supremache]

Originally Posted by jimaway that's exactly what it does

Yes, i was think adding strlen out the loop will do bug but it's work
Thanks you

PHP Code:

@OnVipsOnline( id )
{
    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iPlayer, iNum;
    formatex( szBuffer, charsmax( szBuffer ), "&x04Online:&x01 " );
    
    get_players( szPlayers, iNum , "ch" );

    for( new iIndex, i; i < iNum; i++ )
    {
        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )
        {  // ( iPlayer = iIndex ) is see this way is better than using this iPlayer++ 
            format( szBuffer, charsmax( szBuffer ), "%s%s, ", szBuffer, g_iPlayer[ ( iPlayer = iIndex ) ][ Name ] );
        }
    }

    if( iPlayer )
    {
        szBuffer[ strlen( szBuffer ) - 2 ] = '.' // Changed the strlen form -1 to -2 because i added a space 
    }
    else
    {
        add( szBuffer, charsmax( szBuffer ), "There are no vip's online." );
    }
    
    CC_SendMessage( id, szBuffer );
} 


[Natsheh]

Originally Posted by jimaway new istrlen for( new iIndex, i; i < iNum; i++  )     {         if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) /* Check who has a vip flag */  ][ VIP ] & g_iSettings[ Access_OnlineList ] )         {             istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s, ",g_iPlayer[ iIndex ][ Name ]);         }     } szBuffer[istrlen-2] = '.' szBuffer[istrlen-1] = EOS;

Duhhhhh !??!?

[Supremache]

Originally Posted by Natsheh Duhhhhh !??!?

what do you mean ?
szBuffer[istrlen-2] = '.' // it work like replace so i think i dont need to clear it !!

[Natsheh]

Originally Posted by Supremache what do you mean ? szBuffer[istrlen-2] = '.' // it work like replace so i think i dont need to clear it !!

I meant why you didn't use jimmy's code and instead you kept using your code, jimmy's code is more efficient and faster.

And also you don't need the iPlayer variable just check whether the buffer is empty or not, like this...

PHP Code:

if( szBuffer[0] != EOS )
    {
        szBuffer[ strlen( szBuffer ) - 2 ] = '.' // Changed the strlen form -1 to -2 because i added a space 
         CC_SendMessage(id, szBuffer);
    }
    else
    {
        CC_SendMessage( id, "There are no vip's online." );
    } 


[Shadows Adi]

Originally Posted by Supremache what do you mean ? szBuffer[istrlen-2] = '.' // it work like replace so i think i dont need to clear it !!

PHP Code:

new istrlen
for( new iIndex, i; i < iNum; i++  )
{
    if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) /* Check who has a vip flag */  ][ VIP ] & g_iSettings[ Access_OnlineList ] )
    { 
        istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s%s ", g_iPlayer[ iIndex ][ Name ], i == iNum -1 ? "" : ",");
    }
} 


[Natsheh]

Originally Posted by Shadows Adi PHP Code: new istrlen for( new iIndex, i; i < iNum; i++  ) {     if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) /* Check who has a vip flag */  ][ VIP ] & g_iSettings[ Access_OnlineList ] )     {          istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s%s ", g_iPlayer[ iIndex ][ Name ], i == iNum -1 ? "" : ",");     } }

This might not work because iNum might not be the last vip index.