[~Gh05t~]

Hi all,
i have a problem with a Panel in my Plugin. I Want to send a Panel to some particular players to let them select some options (NOT to all players!).
Here is my code:

PHP Code:

new Handle:g_hMyPanel = INVALID_HANDLE;

public displayPanel()
{
    buildMyPanel();
    for(new i = 1; i <= GetMaxClients(); i++)
    {
        if(isValidClient(i)) //some more checks here
        {
                SendPanelToClient(g_hMyPanel, i, Handler_MyPanel, DISPLAY_TIME);
        }
    }
    if(g_hMyPanel != INVALID_HANDLE) CloseHandle(g_hMyPanel);
}

buildMyPanel()
{
    g_hMyPanel = CreatePanel();
    SetPanelTitle(g_hMyPanel, "Title");

    DrawPanelText(g_hMyPanel, "Text...");
    DrawPanelText(g_hMyPanel, " ");
    
    DrawPanelItem(g_hMyPanel, "Item 1", ITEMDRAW_DEFAULT);
    DrawPanelItem(g_hMyPanel, "Item 2", ITEMDRAW_DEFAULT);
    DrawPanelItem(g_hMyPanel, "Item 3", ITEMDRAW_DEFAULT);

    SetPanelCurrentKey(g_hMyPanel, 10);
    DrawPanelItem(g_hMyPanel, "Exit", ITEMDRAW_CONTROL);
}

public Handler_MyPanel(Handle:menu, MenuAction:action, param1, param2) {...} 


When i run displayPanel() i get that error message:

L 10/26/2007 - 14:41:48: [SM] Native "CloseHandle" reported: Handle aa0019 is invalid (error 1)
L 10/26/2007 - 14:41:48: [SM] Displaying call stack trace for plugin "myplugin.smx":
L 10/26/2007 - 14:41:48: [SM]   [0]  Line 241, myplugin.sp::displayPanel()

That problem does only occur, if i add selectable PanelItems ("ITEMDRAW_DEFAULT") to the Panel. How can i solve that problem? Do i realy have to build an own panel for each client?

[ferret]

Do you close the panel in Handler_MyPanel?

[~Gh05t~]

no, i dont... should i?

[ferret]

No, if you did, that would definately be the problem. I don't have an answer right now, I haven't specificly used panels much, just Menus.

[BAILOPAN]

Can you paste the full code?

[~Gh05t~]

Sry, iam no full-time developer, had no time yesterday
Ive shordened it a bit, because my Code is very long, the menu is only a short part.
But the shortened code has the problem ive described above. I dont think that it is a Problem of the Panel itself, but of the direct following Panels while another panel is displayed.
Heres my Code

[ferret]

Couple of things:

#1) You don't need to find life state. You'll have to #include sdktools, but there is an "IsAlive()" native there, so that will save you a little effort.

#2) This is just an idea, but give it a try. Instead of doing this:

if(g_hMyPanel != INVALID_HANDLE) CloseHandle(g_hMyPanel);

At the end of displayPanel(), instead do it inside buildMyPanel(), just before you use CreatePanel();

Just an idea. I don't immediately see an issue with the way you've done it, but if you try that out, the panel will stay around until you need to change it.

[BAILOPAN]

FYI it's IsPlayerAlive() and was moved to core (clients.inc I believe) a week or two ago.