[bman87]

I don't know how to use arrays very well, it looks like using an ADT array would be a lot easier.

If we store the STEAMID string in the array and use the function FindStringInArray() to see if it does not return -1, then move the client to spectators.
Then we could use the RemoveFromArray() function on the index that FindStringInArray() returned

[bman87]

Thanks for the help olj!

This compiles, but not tested yet. Can't test it at work.. =/

PHP Code:

#include <sourcemod>

#define VERSION "1.0"

new Handle:g_adtArray;
new roundCount = 0;
new bool:g_isMapChange = false;

public Plugin:myinfo =
{
    name = "Remember Spectator Team",
    author = "B-man",
    description = "Remembers who was a spectator on map change",
    version = VERSION,
    url = "http://www.tchalo.com"
};

public OnPluginStart()
{
    HookEvent("round_end",Event_RoundEnd);
    g_adtArray = CreateArray(64);
}

public OnMapStart()
{
    roundCount = 0;    //Reset round count
    g_isMapChange = false;    //Server is not changing map
}

public OnMapEnd()
{
    g_isMapChange = true;    //Map is changing
}

public Event_RoundEnd(Handle:event, const String:name[], bool:dontBroadcast)
{
    roundCount++;
    
    decl String:steamID[64];
    
    if (roundCount == 2)
    {
        for (new i = 1; i <= MaxClients; i++)
        {
            if (GetClientTeam(i) == 1)    //finds spectators
            {
                new client = GetClientOfUserId(i)
                GetClientAuthString(client, steamID, 64);    //Gets the steamID
                PushArrayString(g_adtArray, steamID);        //Add the steamID string to the array
            }
        }
    }
}

public OnClientPostAdminCheck(client)
{
    decl String:steamID[64];
    GetClientAuthString(client, steamID, 64);    //Get steamID
    new arrayIndex = FindStringInArray(g_adtArray, steamID);    //Returns the index where steamID was found -1 if not found
    
    if (arrayIndex != -1)    //If the index is not -1
    {
        ChangeClientTeam(client, 1);        //change team to spectator
        RemoveFromArray(g_adtArray, arrayIndex);    //remove that person from the array
    }
}  

public OnClientDisconnect_Post(client)    //If everyone leaves, clear the array.
{
    if (GetClientCount(false) == 0 && !g_isMapChange)
    {
        ClearArray(g_adtArray);
    }
} 


[olj]

[quote=bman87;905419]Thanks for the help olj!

This compiles, but not tested yet. Can't test it at work.. =/

Well, it seems we all writing l4d plugins instead of actually WORKING. lol.

[olj]

Originally Posted by bman87 Is using GetClientUserId() is the best fuction? Notes: Retrieves a client's user id, which is an index incremented for every client that joins the server. Does that get incremented on a map change since the clients are reconnecting? GetClientAuthString() or GetClientSerial() might work better, much more unique than the user ID. I am assuming hooking round_end for adding the spectators to the array instead of OnMapEnd() would be more safe. Wait for the second round_end to fire for the map and store the spectators. OnClientPostAdminCheck() is a much better idea than hooking player_team. =)

As for user IDs , they dont change on map change. Thats why it is valid choice. And yes, round end/start is more safe, but i'm noob and dont know how to use "%" operator properly to tell if the round is 2nd. (% can be used to check if number is odd or even). Anyway i see you wrote your code, gj. Dont have time to look at it though or test it.

[bman87]

I just tested the plugin I posted and it did not work =(

[bman87]

This one may work. I think I found a bug. I will have to test later.

I added debugging info print outs, dont use on a pub server unless you comment out the PrintToChatAll() lines.

PHP Code:

#include <sourcemod>

#define VERSION "1.0"

new Handle:g_adtArray;
new roundCount = 0;
new bool:g_isMapChange = false;

public Plugin:myinfo =
{
    name = "Remember Spectator Team",
    author = "B-man",
    description = "Remembers who was a spectator on map change",
    version = VERSION,
    url = "http://www.tchalo.com"
};

public OnPluginStart()
{
    HookEvent("round_end",Event_RoundEnd);
    g_adtArray = CreateArray(ByteCountToCells(32));
}

public OnMapStart()
{
    roundCount = 0;    //Reset round count
    g_isMapChange = false;    //Server is not changing map
}

public OnMapEnd()
{
    g_isMapChange = true;    //Map is changing
}

public Event_RoundEnd(Handle:event, const String:name[], bool:dontBroadcast)
{
    roundCount++;
    PrintToChatAll("Round Count: %i", roundCount);
    
    if (roundCount == 2)
    {
        PrintToChatAll("Attempting to save spectators");
        for (new i = 1; i <= MaxClients; i++)
        {
            if (GetClientTeam(i) == 1)    //finds spectators
            {
                decl String:steamID[32];
                PrintToChatAll("Found a spectator!");
                new client = GetClientUserId(i)
                GetClientAuthString(client, steamID, sizeof(steamID));    //Gets the steamID
                PushArrayString(g_adtArray, steamID);        //Add the steamID string to the array
                PrintToChatAll("SteamID: %s", steamID);
            }
        }
    }
}

public OnClientPostAdminCheck(client)
{
    decl String:steamID[32];
    GetClientAuthString(client, steamID, sizeof(steamID));    //Get steamID
    new arrayIndex = FindStringInArray(g_adtArray, steamID);    //Returns the index where steamID was found -1 if not found
    PrintToChatAll("SteamID Checking: %s", steamID);
    PrintToChatAll("Array Index: %i", arrayIndex);
    
    if (arrayIndex != -1)    //If the index is not -1
    {
        PrintToChatAll("Attempting to change client team to spectator");
        ChangeClientTeam(client, 1);        //change team to spectator
        RemoveFromArray(g_adtArray, arrayIndex);    //remove that person from the array
    }
}  

public OnClientDisconnect_Post(client)    //If everyone leaves, clear the array.
{
    if (GetClientCount(false) == 0 && !g_isMapChange)
    {
        PrintToChatAll("Clearing Array");
        ClearArray(g_adtArray);
    }
} 


[olj]

GetClientAuthString(client, steamID, sizeof(steamID)); //Gets the steamID


This function require s client index - not user ID. Replace "client" with "i" there. (Talking about round_end event callback only. PostAdmincCheck function seems to be fine)

[bman87]

Thanks for the tip! I will try this later today

[bman87]

It works! I posted the plugin in the New Plugins forum.

[olj]

Nice. Born from a dream plugin