Raised This Month: $51 Target: $400
 12% 

[TF2] gScramble (Redux)


Post New Thread Reply   
 
Thread Tools Display Modes
reji
Junior Member
Join Date: Aug 2013
Location: Russia
Old 12-14-2013 , 04:26   Re: [TF2] gScramble (Redux)
Reply With Quote #61

Top players being autobalanced regardless of settings. Look at the line #2447 of gscramble.sp:
Code:
new Totalscore = GetEntProp(entity, Prop_Send, "m_iScore", _, client);
This should be:
Code:
new Totalscore = GetEntProp(entity, Prop_Send, "m_iScore", _, i);

Last edited by reji; 12-14-2013 at 04:53.
reji is offline
Donski
Senior Member
Join Date: Sep 2012
Old 12-14-2013 , 10:36   Re: [TF2] gScramble (Redux)
Reply With Quote #62

Quote:
Originally Posted by reji View Post
Are you using a latest version? Line numbers from the provided error trace does not correspond to a current source code.
Yes. I used the one that was posted on the first page. I had to disable it since it wasn't really working.
Donski is offline
Dr. McKay
Sir Dr. SourceMod Plugin Approver Esq. Ltd. M.D. PhD
Join Date: Aug 2011
Location: Atlantis
Old 12-14-2013 , 23:19   Re: [TF2] gScramble (Redux)
Reply With Quote #63

m_iScore is the player's number of kills. m_iTotalScore is the score displayed in the scoreboard.
__________________
Dr. McKay is offline
_david_
SourceMod Donor
Join Date: Apr 2013
Old 12-15-2013 , 09:05   Re: [TF2] gScramble (Redux)
Reply With Quote #64

Quote:
Originally Posted by reji View Post
Top players being autobalanced regardless of settings. Look at the line #2447 of gscramble.sp:
Code:
new Totalscore = GetEntProp(entity, Prop_Send, "m_iScore", _, client);
This should be:
Code:
new Totalscore = GetEntProp(entity, Prop_Send, "m_iScore", _, i);
Quote:
Originally Posted by Dr. McKay View Post
m_iScore is the player's number of kills. m_iTotalScore is the score displayed in the scoreboard.
/facepalm
i should stop doing things late at night, thanks for the help!

--

Code:
15-12-2013 (v3.0.18)
* Fixed a bug with getting topplayers (Thanks reji & Dr. McKay)
Attached Files
File Type: zip Gscramble (redux).zip (118.5 KB, 75 views)
File Type: sp Get Plugin or Get Source (gscramble.sp - 80 views - 80.7 KB)

Last edited by _david_; 12-18-2013 at 12:41.
_david_ is offline
Atreus
SourceMod Donor
Join Date: Apr 2005
Location: San Diego, CA
Old 12-16-2013 , 11:32   Re: [TF2] gScramble (Redux)
Reply With Quote #65

Just for the record, I'd REALLY love to see some of the major bugs in this fixed, and I'm willing to even pay to get some of them fixed (and make/keep those fixes public)! Is there anybody willing to join me in this endeavor, whether it be helping me with paying the coder(s) to fix it or a coder willing to work on it?

Here's the shortlist of things that are broken and/or needed:
  • protection for engineers/medics with at least one building/certain % of ubercharge from autobalance and autoscramble (high priority!)
  • the round timer is not always reset when a scramble occurs during setup for some reason
  • I *think* something is wrong with the Points per Minute scrambling algo. It just... doesn't seem to provide a balanced scramble almost ever. Random works better these days
  • At times, the AutoBalance just...stops working. there can be a 5 player deficit, and it just doesn't do anything and I have to use sm_forcebalance
  • Lastly, it would be lovely to have something that works similarly to the "If there's X time left in the round, don't actually scramble until the round ends" feature, but for payload carts! Something like, if the payload cart is more than X% to the final point, hold the scramble off

The first point is by far the most important. I'd really love to get this plugin working properly again!
Atreus is offline
Send a message via AIM to Atreus Send a message via MSN to Atreus
Donski
Senior Member
Join Date: Sep 2012
Old 12-16-2013 , 14:49   Re: [TF2] gScramble (Redux)
Reply With Quote #66

Quote:
Originally Posted by _david_ View Post
/facepalm
i should stop doing things late at night, thanks for the help!

--

Code:
15-12-2013 (v3.0.18)
* Fixed a bug with getting topplayers (Thanks reij & Dr. McKay)
I downloaded the zip file and installed it on the server, but it still says that the version is 3.0.16:

Code:
  Title: [TF2] gScramble (Redux) (Auto Managed team balancer/scrambler.)
  Author: David
  Version: 3.0.16
  URL: https://forums.alliedmods.net/showthread.php?t=219898
  Status: running
  Reloads: Map Change if Updated
  Timestamp: 08/02/2013 18:54:36
  Hash: 8d7fd4e412f53022d9737eddb4ce2ff4
The plugin version on the original post says 3.0.17, your changelog says 3.0.18 should be the latest, and the source file has Version 3.0.18. Should we manually compile?

EDIT: Nevermind, just had to manually compile the plugin since it wouldn't work with the forum's compiler. Hopefully this fixes the issues I've been experiencing earlier.

Last edited by Donski; 12-16-2013 at 14:52.
Donski is offline
AeroAcrobat
AlliedModders Donor
Join Date: Apr 2011
Location: lives in a circus
Old 12-16-2013 , 15:44   Re: [TF2] gScramble (Redux)
Reply With Quote #67

Quote:
Originally Posted by Donski View Post
I downloaded the zip file and installed it on the server, but it still says that the version is 3.0.16:
Good catch, thanks for informing!
__________________
AeroAcrobat is offline
Donski
Senior Member
Join Date: Sep 2012
Old 12-16-2013 , 16:26   Re: [TF2] gScramble (Redux)
Reply With Quote #68

Quote:
Originally Posted by AeroAcrobat View Post
Good catch, thanks for informing!
No problem, I had to double check because the previous guy said I might have had a different file installed on my server, what do you know I still had 3.0.13 lol.
Donski is offline
reji
Junior Member
Join Date: Aug 2013
Location: Russia
Old 12-16-2013 , 17:39   Re: [TF2] gScramble (Redux)
Reply With Quote #69

One more (rare) bug:
Code:
L 12/08/2013 - 17:56:56: [SM] Plugin encountered error 15: Array index is out of bounds
L 12/08/2013 - 17:56:57: [SM] Displaying call stack trace for plugin "gscramble.smx":
L 12/08/2013 - 17:56:57: [SM]   [0]  Line 1587, gscramble.sp::timer_Restore()
Random value from the uninitialized variable iIndex in Event_PlayerDisconnect() sometimes get written to the client cookie "team index".
Fixed gscramble.sp and the patch for 3.0.18 are below. Not tested yet but this is a simple change.

Code:
15-12-2013 (v3.0.18)
* Fixed a bug with getting topplayers (Thanks reij & Dr. McKay)
I'm glad I helped but my name is reji
Attached Files
File Type: sp Get Plugin or Get Source (gscramble.sp - 188 views - 80.7 KB)
File Type: patch team_index_cookie_fix.patch (2.5 KB, 164 views)

Last edited by reji; 12-17-2013 at 01:24.
reji is offline
Donski
Senior Member
Join Date: Sep 2012
Old 12-18-2013 , 09:36   Re: [TF2] gScramble (Redux)
Reply With Quote #70

Nvm.

Last edited by Donski; 12-18-2013 at 09:39.
Donski is offline
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 16:28.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode