[indraraj striker]

black screen for lannies
it is useful for gaming cafe!

Issue#1

its removing all ips suppose Player1 connected with 192.168.0.12 reponse = no bool Player2 connected with 192.168.0.12 response = bool true = black screen works Player3 connected with 192.168.0.12 respone = bool true = black screen works indra connected with 192.168.0.12 reponse = bool true = black screen works i am disconnected, it removes all ips now i am again connected with 192.168.0.12 response = no bool = no black screen but there are already two players playing with 192.168.0.12

Issue#2

sometime normal players gets black screen i don't know why

Question

how can i remove only disconnected user ip from Trie

Question

how can i compare first three octet of ip

Thanks

PHP Code:


#include <amxmodx>
#include <hamsandwich>

#define PLUGIN "Black screen for lannies"
#define VERSION "0.2"
#define AUTHOR "26-{indra}"

#define TASK_BLACK 1111

new Trie:g_IPs;
new bool:black_screen[33] = false;
new glo_screenfade;

public plugin_init() 
{
    register_plugin( PLUGIN, VERSION, AUTHOR );
    register_event( "DeathMsg", "death", "a" );
    RegisterHam( Ham_Spawn, "player", "Playerspawn", 1 );
    register_event("TextMsg", "spec_mode", "bd", "2&Spec_Mode")
    register_event("SendAudio", "end_round","a", "2=%!MRAD_terwin", "2=%!MRAD_ctwin");
    glo_screenfade = get_user_msgid("ScreenFade");
    g_IPs = TrieCreate();
}

public plugin_end()
    TrieDestroy(g_IPs);


public client_putinserver(id)
{
    static szIP[16], szName[33];
    get_user_ip(id, szIP, charsmax(szIP), 1);
    get_user_name(id, szName, charsmax(szName) );
    
    if (TrieKeyExists(g_IPs, szIP))
    {
        black_screen[id] = true;
        log_to_file( "LAN_IP.log", "Name : %s | IP: %s",szName,szIP);
    }
    else
        TrieSetCell(g_IPs, szIP, 1);
}


public client_disconnect(id)
{
    /*
    the issue is here
    its removing all ips suppose 
    Player1 connected with 192.168.0.12 reponse = no bool
    Player2 connected with 192.168.0.12  response = bool true = black screen
    Player3 connected with 192.168.0.12 respone = bool true = black screen
    indra connected with 192.168.0.12    reponse = bool true = black screen
    now i am disconnected, it removes all ips 
    now i am again connected with 192.168.0.12 response = no bool = no black screen
    but there are all already two players playing 192.168.0.12
    
    */
    
    static szIP[16];
    get_user_ip(id, szIP, charsmax(szIP), 1); 
    TrieDeleteKey(g_IPs, szIP); // needs to fix here 
    server_print("g_IPs : %s | %s",g_IPs,szIP)
    black_screen[id] = false;
    if(task_exists(TASK_BLACK))
        remove_task(id + TASK_BLACK);
}

public death()
{
    new id = read_data(2);
    if(black_screen[id])
    { 
        set_task(0.5,"show_black",id+TASK_BLACK, _,_, "b");
    }
}

public spec_mode(id)
{
    if (black_screen[id])
        client_cmd(id, "spec_mode 3");
    return PLUGIN_CONTINUE;
}


public show_black(id)
{
    id -= TASK_BLACK;
    if(black_screen[id])
    {
        message_begin(MSG_ONE , glo_screenfade, {0,0,0}, id)
        write_short(1<<12)
        write_short(1<<12)
        write_short(0x0004)
        write_byte(0)
        write_byte(0)
        write_byte(0)
        write_byte(255)
        message_end()
        set_hudmessage(0, 255, 0, -1.0, -1.0, 0, 6.0, 12.0);
        show_hudmessage(id, "[LAN] If You are not playing at Gaming Cafe with Same IP then reconnect.");
        client_cmd(id, "spec_mode 3");
    }
}

//resetting two times to fixed the issue at end round and spawn
public end_round()
{
    new players[32], pnum
    get_players(players, pnum)
    for(new i = 0; i < pnum; i++) 
    { 
        if(black_screen[i])
        {
            remove_task(i + TASK_BLACK);
            message_begin(MSG_ONE , glo_screenfade, {0,0,0}, i)
            write_short(1<<12)
            write_short(1<<12)
            write_short(0x0004)
            write_byte(0)
            write_byte(0)
            write_byte(0)
            write_byte(0)
            message_end()
        }
        
    }
}

public Playerspawn(id)
{
    if(black_screen[id])
    {
        message_begin(MSG_ONE , glo_screenfade, {0,0,0}, id)
        write_short(1<<12)
        write_short(1<<12)
        write_short(0x0004)
        write_byte(0)
        write_byte(0)
        write_byte(0)
        write_byte(0)
        message_end()
        remove_task(id + TASK_BLACK);
    }
} 


[fysiks]

2. Search. When looking for a function to delete a key from a trie, try searching the API (or better yet, the include file that is used for Tries) for a function that does that.
3. Store only what you need to compare. If doing less than a full IP, you'd need to do a counter for each matching subset which can easily be done with the data for that Trie key.

[indraraj striker]

2.

when first player is disconnected L 12/09/2017 - 126:08: IP 192.168.0.12 is deleted when second player is disconnected L 12/09/2017 - 126:08: the following IP 192.168.0.12 is already deleted

PHP Code:

get_user_ip(id, szIP, charsmax(szIP), 1); 
    if( TrieDeleteKey(g_IPs ,szIP))  // needs to fix here 
    {
       log_to_file("black_screen.log","IP %s is deleted",szIP);
    }
    else
    {
      log_to_file("black_screen.log","the following IP %s is already deleted",szIP);
    } 


this will remove his ip from trie am i right
TrieDeleteKey(g_IPs ,szIP)

and this will clear all the ip from trie am i right
TrieClear( g_IPs )

so i am using deletekey but why its removing all user ips from Trie
it should work like this
Player1 is connected with 192.168.0.12
Player2 is connected with 192.168.0.12
Player3 is connected with 192.168.0.12
Indra is connected with 192.168.0.12
now indra is disconnected
Deletekey should remove only ip address of indra not all ips
I am totally messed up -_- and i think i have to use TrieSetArray as i want to remove only specific user ip
3. i will search
Thanks

[fysiks]

I misspoke, you need to do the counting regardless of the number of IP digits you use. When someone connects, add their IP to the Trie with a value 1. When the next person connects, check if their IP already exists, if yes, get the value and add 1 (and set your flag).

This is a really simple implementation and won't properly handle all corner conditions.

Have you search the forums for this idea? It's been requested several times before.

[indraraj striker]

Originally Posted by fysiks I misspoke, you need to do the counting regardless of the number of IP digits you use. When someone connects, add their IP to the Trie with a value 1. When the next person connects, check if their IP already exists, if yes, get the value and add 1 (and set your flag). This is a really simple implementation and won't properly handle all corner conditions. Have you search the forums for this idea? It's been requested several times before.

if i add their ip in trie and dont remove when they disconnect it will create issue
what if i reconnect 3 times it will say this ip is already in trie and set bool is true

PHP Code:

    static szIP[16], szName[33];
    get_user_ip(id, szIP, charsmax(szIP), 1); //get his ip
    get_user_name(id, szName, charsmax(szName) );
    
    if (TrieKeyExists(g_IPs, szIP)) //if the ip is exist in trie
    {
        black_screen[id] = true;  //set this bool true
        log_to_file( "LAN_IP.log", "Name : %s | IP: %s",szName,szIP); //log purpose
    }
    else
        TrieSetCell(g_IPs, szIP, 1); // if the ip isnt exist in trie it will add 


i will search
Thanks anyway

[fysiks]

Clearly, you don't understand what I said. Also, after thinking about it, this method won't work reliably. You would need to loop through all players when a new player connects and check to see if they have a similar IP and set your boolean accordingly (for both the connecting player and all other players that had the similar IP.

Also,

Originally Posted by fysiks Have you search the forums for this idea? It's been requested several times before.

[indraraj striker]

fysiks okay
Thanks for the idea!