[HLM]

PHP Code:

public client_connect(id)
{
    server_print("someone connected")
    server_print("%d players with a bot limit of %d with a server capacity of %d",get_playersnum(1), get_cvar_num("fb_maxbots"), get_maxplayers())
    if(get_playersnum(1) > get_cvar_num("fb_maxbots"))
    {
        server_print("loop begin")
        new iPlayers[32],iNum = get_maxplayers()
        for(new i=1;i<iNum;i++) 
        {
            new x=iPlayers[i]
            server_print("iNum = %d",iNum)
            server_print("Attempting to kick %d", get_user_userid(x))
            server_cmd("kick #%d", x) get_user_userid(x))
            server_print("[SKYNET] Kicked #%d due to slot overflow",  get_user_userid(x))
            server_print("execcing...")
            server_exec()
            server_print("execced!")
            server_print("Breaking...")
            if(get_playersnum(1) <= get_cvar_num("fb_maxbots"))
                break;
            else
                server_print("ERROR! relooping (AFAIK)")
            

            /* Do something */ 
        }
        //server_cmd("bot ^"kickall^"")
        //server_cmd("kick #%d",get_user_userid(g_lastbot))
        
    }
} 


the problem is, it keeps looping and doing 0, I set it i to 1, so then obviously iPlayers[i] = 0, how do I go about resolving this?

[fysiks]

When you declare iPlayers[32] all 32 cells contain the value 0.

Use:

new iPlayers[32], iNum
get_players(iPlayers, iNum)
for(new i = 0; i < iNum; i++)
{
    // ...
}

[HLM]

That worked, thanks!


Final Outcome:

PHP Code:

new iPlayers[32], iNum
        get_players(iPlayers, iNum)
        for(new i = 0; i < iNum; i++) 
        {
            new x=iPlayers[i]
            if(is_user_bot(x))
            {
                server_print("iNum = %d",iNum)
                server_print("Attempting to kick %d", get_user_userid(x))
                server_cmd("kick #%d", get_user_userid(x))
                server_print("[SKYNET] Kicked #%d due to slot overflow",  get_user_userid(x))
                server_print("execcing...")
                server_exec()
                server_print("execced!")
                server_print("Breaking...")
                if(get_playersnum(1) <= get_cvar_num("fb_maxbots"))
                    break;
                else
                    server_print("ERROR! relooping (AFAIK)")
            }
            

            /* Do something */ 
        } 


[Arkshine]

new x ; declare the variable before the loop or with i : for ( new i = 0, x; ...

[Mini_Midget]

Originally Posted by Arkshine new x ; declare the variable before the loop or with i : for ( new i = 0, x; ...

Hmm... Can you explain why? I always tend to declare the new "id' variables inside the loop.

[Arkshine]

You ask why ? Each var is zeroed. It's quite obvious to create one time the var before the loop instead of x times is more efficient. If you can, don't create var in a loop.

[GXLZPGX]

Originally Posted by Mini_Midget Hmm... Can you explain why? I always tend to declare the new "id' variables inside the loop.

Since you may do it a lot depending on how many people are usually in your server, it's more efficient that everytime you loop, you're not creating new variables constantly. It's better that the variable is already created, so the plugin can constantly use that variable.

[ConnorMcLeod]

Use "d" flags in get_players so you collect only bots.

PHP Code:

get_players(iPlayers, iNum, "d")