[Napoleon_be]

Originally Posted by OciXCrom 8. log_amx("%s", szLine); => log_amx(szLine); Should this even be in the code? Pretty sure you forgot to remove it when testing. Just debug purposes in case anyone gets errors later on. Easier for me than explaining to people what to do. 10. Line 360: for(new i; i < ArraySize(aColorInfo); i++) { The array size won't ever change, so cache it in a global variable after reading the file. What do you mean with this? could you give me an example? I get the fact that the array size will never change, but why do i need to cache it?

Everything else is fixed and ready to get updated. Big thanks for your feedback already.

Also, i tried using this:

PHP Code:

 iMainMenu = menu_create("MAIN_MENU_HEADER", "MainMenuHandler", true); 


But it's not working, it's just showing "MAIN_MENU_HEADER"

[HamletEagle]

What do you mean with this? could you give me an example? I get the fact that the array size will never change, but why do i need to cache it?

for(initialization; condition; step)
In a loop, the condition is tested on each iteration.

Your condition is something like: i < ArraySize(). What happens is after each iteration the plugin has to call ArraySize in order to be able to compare it with "i".
If you cache it into a variable then you can use that in the loop condition and avoid calling the native for each step.

i = 0: execute your code, call ArraySize, compare with i, increment
i = 1: execute your code, call ArraySize, compare with i, increment
...
i = k: execute your code, call ArraySize, compare with i, increment
...

With caching:
i = 0: execute your code, compare variable with i, increment
i = 1: execute your code, compare variable with i, increment
...
i = k: execute your code, compare variable with i, increment
...

You don't need to do that for loops using sizeof and regular arrays, because their size is known at compile time.

[Napoleon_be]

Originally Posted by HamletEagle for(initialization; condition; step) In a loop, the condition is tested on each iteration. Your condition is something like: i < ArraySize(). What happens is after each iteration the plugin has to call ArraySize in order to be able to compare it with "i". If you cache it into a variable then you can use that in the loop condition and avoid calling the native for each step. i = 0: execute your code, call ArraySize, compare with i, increment i = 1: execute your code, call ArraySize, compare with i, increment ... i = k: execute your code, call ArraySize, compare with i, increment ... With caching: i = 0: execute your code, compare variable with i, increment i = 1: execute your code, compare variable with i, increment ... i = k: execute your code, compare variable with i, increment ... You don't need to do that for loops using sizeof and regular arrays, because their size is known at compile time.

PHP Code:

new iColorSize; 


PHP Code:

iColorSize = ArraySize(aColorInfo); 


PHP Code:

for(new i; i < iColorSize; i++) {

} 


Something like this? Tried it and it worked so i guess it's right.

[HamletEagle]

Looks fine.

[Napoleon_be]

Updated my post & attachments. Updated my code so far with the purpose to keep it's functionallity. OciXCrom's suggestion of creating menu's different didn't work, so i'll stick with the current method untill this get's cleared up.

[OciXCrom]

Originally Posted by Napoleon_be Everything else is fixed and ready to get updated. Big thanks for your feedback already. Also, i tried using this: PHP Code:  iMainMenu = menu_create("MAIN_MENU_HEADER", "MainMenuHandler", true);  But it's not working, it's just showing "MAIN_MENU_HEADER"

It's not working because you're using an older 1.8.3 build. Upgrade to the latest 1.9.

https://github.com/alliedmodders/amxmodx/pull/593

[Napoleon_be]

Originally Posted by OciXCrom It's not working because you're using an older 1.8.3 build. Upgrade to the latest 1.9. https://github.com/alliedmodders/amxmodx/pull/593

Well this should work no matter what version i use, is there something wrong with my version checks?

Server console logs

AMX Mod X 1.9.0.5263 (http://www.amxmodx.org)
Authors:
	David "BAILOPAN" Anderson, Pavol "PM OnoTo" Marko
	Felix "SniperBeamer" Geyer, Jonny "Got His Gun" Bergstrom
	Lukasz "SidLuke" Wlasinski, Christian "Basic-Master" Hammacher
	Borja "faluco" Ferrer, Scott "DS" Ehlert
Compiled: Oct 27 2019 16:23:56
Built from: https://github.com/alliedmodders/amxmodx/commit/15a14a0a
Build ID: 5263:15a14a0a
Core mode: JIT+ASM32

[Napoleon_be]

Update: v2.0.1 released. Check first post for update notes. I have temporarely removed the other ML Translations untill everything is updated. Only English & Dutch available at the moment.

[HamletEagle]

I understand you updated and added more features, but it is just a glow menu at the end of the day. Why should it be moved back to New Plugins and reviewed? I'd like to hear some arguments.

[Napoleon_be]

Originally Posted by HamletEagle I understand you updated and added more features, but it is just a glow menu at the end of the day. Why should it be moved back to New Plugins and reviewed? I'd like to hear some arguments.

The plugin will be more usefull once i add the AimGlow option. A lot of jailbreak servers need a plugin like this, and so far i haven't seen any approved ones yet that qualify this one.

Suggestions are always welcome, also cvar related, i think there should be more customizations. I'm also thinking of the ability to add colors by a console command.