[eyal282]

Originally Posted by HamletEagle It will be better to create only one task in plugin_init and loop all players inside it, than having 32 tasks at the same time. If you are not sure how to do that I'll show you. Edit: Unapproved until you make the changes.

You mean start of round? I made it because I also want to allow deathmatch spawn.

[HamletEagle]

Where do you see I said anything about round start? I said to start a task from plugin_init with flag b(so it never stops). Then, in that task use get_players to loop all players and do the same thing as you do now. The difference is that instead of 32 tasks, there will be only one.
Again, if you are not sure how to do that, I'll show you, even if it's just about moving a set_task to plugin_init and doing a loop.

[edon1337]

1. You should name the forwards properly, example HamBurger_Spawn should be something like fw_HamSpawn and HamBurger_Damage should be fw_HamTakeDamage for better readability.

2. Before removing a task make sure it exists, you never know.

3. In my opinion you should check for pev_valid == 2 first.

PHP Code:

id = get_pdata_cbase(Weapon, 41, 4); 


[eyal282]

Originally Posted by HamletEagle Where do you see I said anything about round start? I said to start a task from plugin_init with flag b(so it never stops). Then, in that task use get_players to loop all players and do the same thing as you do now. The difference is that instead of 32 tasks, there will be only one. Again, if you are not sure how to do that, I'll show you, even if it's just about moving a set_task to plugin_init and doing a loop.

Okay now I'm confused. Could you show me?

[Napoleon_be]

Originally Posted by edon1337 1. You should name the forwards properly, example HamBurger_Spawn should be something like fw_HamSpawn and HamBurger_Damage should be fw_HamTakeDamage for better readability. 2. Before removing a task make sure it exists, you never know. [/php]

1) As long as his prefixes are the same, it's okay for in my opinion. I can read it quiet well.

2) remove_task automaticly checks if a task exists, there's no need for an extra check. Would only be waste of cpu and unecessary checks.

[edon1337]

Originally Posted by Napoleon_be 1) As long as his prefixes are the same, it's okay for in my opinion. I can read it quiet well. 2) remove_task automaticly checks if a task exists, there's no need for an extra check. Would only be waste of cpu and unecessary checks.

1. Eh
2. Oh, didn't know.

[eyal282]

I updated it to be better, hoping it will be approved.

[HamletEagle]

Create the task in plugin_init, not in RoundStart. That way you no longer need to remove and create it each round.
If you wonder how to change the task time if you only set it in plugin init, it's easy. Check the cvar in the task public and if the value is different from the last value used call change_task native with new task time. Probably something like:

PHP Code:

new LastValue

public plugin_init()
{
    cTimer = register_cvar("amx_antisk_timer", "5")
    
    LastValue = get_pcvar_num(cTimer)
    set_task(1.0, "ShowTimer", TASKID_SK,_,_,"a", Timer=LastValue+1)
}

public ShowTimer()
{
    new CurrentValue = get_pcvar_num(cTimer)
    if(LastValue != CurrentValue)
    {
        change_task(TASKID_SK, CurrentValue)
    }
} 


PHP Code:

1 <= attacker <= 32 


Not all servers have 32 players. Either use get_maxplayers(but cache it and use that variable) or is_user_connected.

What's the point of using both TakeDamage and set_user_godmode? set_user_godmod is enough to block damage.

Do not create variables inside a loop, do it before.
In RemoveProtection use new instead of static.
I would like you to use real offset names, so people understand your code:

PHP Code:

const m_pPlayer = 41
get_pdata_cbase(Weapon, m_pPlayer , 4) 


[eyal282]

Originally Posted by HamletEagle Create the task in plugin_init, not in RoundStart. That way you no longer need to remove and create it each round. If you wonder how to change the task time if you only set it in plugin init, it's easy. Check the cvar in the task public and if the value is different from the last value used call change_task native with new task time. Probably something like: PHP Code: new LastValue public plugin_init() {     cTimer = register_cvar("amx_antisk_timer", "5")          LastValue = get_pcvar_num(cTimer)     set_task(1.0, "ShowTimer", TASKID_SK,_,_,"a", Timer=LastValue+1) } public ShowTimer() {     new CurrentValue = get_pcvar_num(cTimer)     if(LastValue != CurrentValue)     {         change_task(TASKID_SK, CurrentValue)     } }  PHP Code: 1 <= attacker <= 32  Not all servers have 32 players. Either use get_maxplayers(but cache it and use that variable) or is_user_connected. What's the point of using both TakeDamage and set_user_godmode? set_user_godmod is enough to block damage. Do not create variables inside a loop, do it before. In RemoveProtection use new instead of static. I would like you to use real offset names, so people understand your code: PHP Code: const m_pPlayer = 41 get_pdata_cbase(Weapon, m_pPlayer , 4)

A server needs to decide whether or not to block fall damage within spawn protection.

One question: can I change the task timer when it's time is over? Or should I use "b" flag? How does it work?

[HamletEagle]

Use flag b, then on cvar change just alter the time. I'm not sure to understand to what are you answering here:

A server needs to decide whether or not to block fall damage within spawn protection.