[GoD-Tony]

Originally Posted by lechoo I'm using the latest DHooks and 'Example/Test Plugin' from first post. The same problem like red4911. Any way to fix this?

Rename the "interface" and "this" variables to something else.

[Neuro Toxin]

Spoiler

#pragma semicolon 1
#include <sourcemod>
#include <sdktools>
#include <dhooks>

//int CCSPlayer::GiveNamedItem(char const*, int, CEconItemView*, bool)
Handle hGiveNamedItem;

public void OnPluginStart()
{
    int offset = 445; // change to 446 for linux
    
    hGiveNamedItem = DHookCreate(offset, HookType_Entity, ReturnType_Int, ThisPointer_CBaseEntity, OnGiveNamedItem);
    DHookAddParam(hGiveNamedItem, HookParamType_CharPtr, -1, DHookPass_ByRef);
    DHookAddParam(hGiveNamedItem, HookParamType_Int, -1, DHookPass_ByVal);
    DHookAddParam(hGiveNamedItem, HookParamType_Int, -1, DHookPass_ByRef);
    DHookAddParam(hGiveNamedItem, HookParamType_Bool, -1, DHookPass_ByVal);
}

public void OnMapStart()
{
    for (int client = 1; client < MaxClients; client++)
    {
        if (IsClientInGame(client))
            OnClientPutInServer(client);
    }
}

public void OnClientPutInServer(client)
{
    if (IsFakeClient(client))
        return;
    
    DHookEntity(hGiveNamedItem, true, client);
}

//CBaseEntity *GiveNamedItem(char const*, int, CEconItemView*, bool)
public MRESReturn OnGiveNamedItem(int client, Handle hReturn, Handle hParams)
{
    int entity = DHookGetReturn(hReturn);
    
    PrintToConsole(client, "----------==========> MRESReturn:OnGiveNamedItem(client=%d, entity=%d)", client, entity);
    return MRES_Ignored;
}

I cant get DHookGetReturn to give me an entity index for GiveNamedItem's return type.

If I create a hook with the return type of ReturnType_Int it get this:

----------==========> MRESReturn:OnGiveNamedItem(client=3, entity=164975072)
----------==========> MRESReturn:OnGiveNamedItem(client=3, entity=177344800)
----------==========> MRESReturn:OnGiveNamedItem(client=3, entity=177231552)
----------==========> MRESReturn:OnGiveNamedItem(client=3, entity=164039216)

Which looks like a pointer to me. So I naturally try ReturnType_CBaseEntity which crashes the server

I think the return type is CBaseEntity*. Is there anyway way for me to convert this into a entity index?

[Dr!fter]

It automatically returns you an index if you tell it its an entity (since sourcemod has no way of using CBaseEntity pointers). Not exactly sure why its crashing but you should make your returns all by value. Ive definetly hooked it before just fine, also second to last param should be marked as Unknown (unknown is simply internally any pointer) or you could use ObjectPtr (if you care to modify its data). Everything else looks right, ill have a better look later today

[Powerlord]

Shouldn't the third param be a HookParamType_ObjectPtr since it's a CEconItemView*?

Not sure if that would make a difference though.

Also, a stack trace would be handy as it'd tell us where the crash is.

[Dr!fter]

Originally Posted by Dr!fter second to last param should be marked as Unknown (unknown is simply internally any pointer) or you could use ObjectPtr (if you care to modify its data).

Originally Posted by Powerlord Shouldn't the third param be a HookParamType_ObjectPtr since it's a CEconItemView*? Not sure if that would make a difference though. Also, a stack trace would be handy as it'd tell us where the crash is.

You could use either unknown or ObjectPtr they are both just void *, defining it as a ObjectPtr allows you to use the natives to set/get object members. I assume he doesnt care about reading it, so unknown is fine.

[Powerlord]

Just an FYI, if you try to build this against SourceMod 1.8 (the current master branch) on Windows, it will error out with this message:

c:\Projects\SourceMod\dev\sourcemod\public\IShareSys.h(40) : fatal error C1083:
Cannot open include file: 'sp_vm_types.h': No such file or directory

Not sure if this is because sourcepawn is a submodule now or what.

[Dr. Greg House]

Did you fetch said sourcepawn submodule?

[Powerlord]

Originally Posted by Dr. Greg House Did you fetch said sourcepawn submodule?

Yes. In fact, I went back and did a new clone with the recursive option set just to make sure.

There are 6 files and 10 8 subdirectories in the sourcemod\sourcepawn directory.

[psychonic]

It's in sourcepawn/include now, instead of public/sourcepawn/ or wherever it was.

[Neuro Toxin]

What I'm trying to do is post hook GiveNamedItem so I can grab the client and weapon indices. At the end of the day I'm updating netprops based on item definition index which needs to be done directly after the GiveNamedItem call.

Tbh. I don't care about any params at all. I only care about the return.

I'm running windows csgo (I'm sure u guys figured this out).

How do I generate a crashdump? I have to add something to my command line?