Raised This Month: $12 Target: $400
 3% 

[Any] Map History (Updated 24-11-2013 @ 1.1.1)


Post New Thread Reply   
 
Thread Tools Display Modes
Avo
Senior Member
Join Date: Apr 2012
Old 12-08-2012 , 12:00   Re: [Any] Map History
Reply With Quote #11

Nice plugin, could be very helpful.

Could you add two little extra cvar :
- AdminOnly
- MapsNumber (between 1 and max define in .sp)

It would allow to configure it without touching the source. And add an AutoExecConfig of course.

Thanks a lot !
__________________
Avo is offline
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 12-08-2012 , 14:13   Re: [Any] Map History
Reply With Quote #12

Quote:
Originally Posted by Avo View Post
Nice plugin, could be very helpful.

Could you add two little extra cvar :
- AdminOnly
- MapsNumber (between 1 and max define in .sp)

It would allow to configure it without touching the source. And add an AutoExecConfig of course.

Thanks a lot !
There is already a "sm_maphistory" (or sm_history ?) feature function built-in Sourcemod; this was so people could publicly could know last maps. I don't see why not use that one if you want admin-only.

As for making a CVar for MapsNumber... yeah good idea.
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work
RedSword is offline
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 12-20-2012 , 05:07   Re: [Any] Map History (Updated 20-12-2012 @ 1.1.0)
Reply With Quote #13

Released 1.1.0 :
  • Added support for admin flag and override. See ConVars :
    • mh_lastmap_flag
    • mh_lastmap_override
    • mh_menu_flag
    • mh_menu_override
  • Plugin now creates its own config files (due too a lot of ConVar) with the other SM cfgs (/cfg/sourcemod/).
  • Added possibility to choose the number of maps dynamically we want via a ConVar. See mh_allow_menu_mapnumbershown.
  • Added anti-menu spam. See ConVar mh_allow_menu_delaymin.
  • Removed FCVAR_NOTIFY from non-version ConVars and removed FCVAR_REPLICATED from version ConVar.

Red
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work
RedSword is offline
KyleS
SourceMod Plugin Approver
Join Date: Jul 2009
Location: Segmentation Fault.
Old 10-29-2013 , 11:49   Re: [Any] Map History (Updated 20-12-2012 @ 1.1.0)
Reply With Quote #14

Why don't you leverage existing natives?

GetMapHistory already supports a lot of what you've done. It also looks like you've reinvented the admin overrides system with cvars Very puzzling!
KyleS is offline
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 10-29-2013 , 18:52   Re: [Any] Map History (Updated 20-12-2012 @ 1.1.0)
Reply With Quote #15

Quote:
Originally Posted by KyleS View Post
Why don't you leverage existing natives?

GetMapHistory already supports a lot of what you've done. It also looks like you've reinvented the admin overrides system with cvars Very puzzling!
... I didn't know... :$

I did check how it worked in game, but not on the coding side :\

EDIT : GetMapHistory requires "nextmap", which can be disabled ! (found a reason !)

It seems there "GetMapHistory" still works without the plugin (as it is .cpp based) :/

Do I have to recode everything :/ ?

RE-EDIT : Coding it using GetMapHistory would be less-performing, as it would do more string copy (SMNextMap-->szBuffer-->BiggerBufferForMenuItem; rather than globalCacheVar-->BiggerBufferForMenuItem; plus doing it when a client queries, rather than on map start).

RE-RE-EDIT : I guess I'll recode it using GetMapHistory and cache the menu OnMapStart or when a client with a different language join.
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work

Last edited by RedSword; 11-21-2013 at 01:44.
RedSword is offline
RedSword
SourceMod Plugin Approver
Join Date: Mar 2006
Location: Quebec, Canada
Old 11-24-2013 , 01:56   Re: [Any] Map History (Updated 24-11-2013 @ 1.1.1)
Reply With Quote #16

Released 1.1.1 :
  • Modified how the plugin works (+updated for approval) :
    • It now uses the internal Sourcemod map history,
    • This allows to show the load the plugin on the fly and access the map history.
  • New convar mh_showcurrentmap, allowing to show or not the current map when using sm_lastmaps. Default is 0 (not showing current map).
  • Menu is now loaded on map change, rather than when asked (tiny optimization)
__________________
My plugins :
Red Maze
Afk Bomb
RAWR (per player/rounds Awp Restrict.)
Kill Assist
Be Medic

You can also Donate if you appreciate my work
RedSword is offline
Peace-Maker
SourceMod Plugin Approver
Join Date: Aug 2008
Location: Germany
Old 12-31-2014 , 07:16   Re: [Any] Map History (Updated 24-11-2013 @ 1.1.1)
Reply With Quote #17

Looks fine. Except those permission convars. I guess you know better now ;)
__________________
Peace-Maker is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 08:47.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode