[ReFlexPoison]

I'm probably missing something pretty simple. I'm getting used to the new syntax and have been running into an issue with global variables, specifically with datapacks. I'm getting some errors.

PHP Code:

DataPack g_hMenuDataPack[MAXPLAYERS + 1];
func1(int iClient)
{
    if(g_hMenuDataPack[iClient] != null)
    {
        delete g_hMenuDataPack[iClient];
        g_hMenuDataPack[iClient] = null;
    }

    g_hMenuDataPack[iClient] = new DataPack();
    g_hMenuDataPack[iClient].WriteString(strPerk);
    g_hMenuDataPack[iClient].WriteCell(iPrice);
    g_hMenuDataPack[iClient].WriteCell(iDuration);
}

func2(int iClient)
{
    g_hMenuDataPack[iClient].Reset(); // This is where I get the "invalid datapack handle" error.
} 


[Neuro Toxin]

Have a look at this....

https://forums.alliedmods.net/showthread.php?t=270519

It doesn't really relate to your question

[Merudo]

This

if(g_hMenuDataPack[iClient] != null)
    {
        delete g_hMenuDataPack[iClient];
        g_hMenuDataPack[iClient] = null;
    }

Is equivalent to simply writing delete g_hMenuDataPack[iClient];

[Merudo]

You need to use ResetPack(g_hMenuDataPack[iClient]) instead of .Reset()

[Bacardi]

g_hMenuDataPack[iClient].Reset(false); // or true to clear data

Originally Posted by ReFlexPoison I'm probably missing something pretty simple. I'm getting used to the new syntax and have been running into an issue with global variables, specifically with datapacks. I'm getting some errors. PHP Code: DataPack g_hMenuDataPack[MAXPLAYERS + 1]; func1(int iClient) {     if(g_hMenuDataPack[iClient] != null)     {         delete g_hMenuDataPack[iClient];         g_hMenuDataPack[iClient] = null;     }     g_hMenuDataPack[iClient] = new DataPack();     g_hMenuDataPack[iClient].WriteString(strPerk);     g_hMenuDataPack[iClient].WriteCell(iPrice);     g_hMenuDataPack[iClient].WriteCell(iDuration); } func2(int iClient) {     g_hMenuDataPack[iClient].Reset(); // This is where I get the "invalid datapack handle" error. }

[Merudo]

Looks like a compiler bug to me.

g_hMenuDataPack[iClient].Reset() should return "error 092: number of arguments does not match definition", or .Reset() should have "false" as default argument.

[ReFlexPoison]

Originally Posted by Bacardi g_hMenuDataPack[iClient].Reset(false); // or true to clear data

Thanks for the quick response! Works well now.

[Powerlord]

Judging from the error you're seeing, g_hMenuDataPack[iClient] is null when you're trying to call Reset on it. Which would happen if you called func2 for a client before calling func1 for a client.

Originally Posted by Merudo Looks like a compiler bug to me. g_hMenuDataPack[iClient].Reset() should return "error 092: number of arguments does not match definition", or .Reset() should have "false" as default argument.

false is the default for Reset. In fact, the DataPack MethodMap tells Reset to use the ResetPack function rather than having its own implementation. Or at least that's what SourceMod 1.7 does, I haven't checked 1.8.

[Bacardi]

Originally Posted by Powerlord Judging from the error you're seeing, g_hMenuDataPack[iClient] is null when you're trying to call Reset on it. Which would happen if you called func2 for a client before calling func1 for a client. false is the default for Reset. In fact, the DataPack MethodMap tells Reset to use the ResetPack function rather than having its own implementation. Or at least that's what SourceMod 1.7 does, I haven't checked 1.8.

...I have just tested SourcePawn Compiler 1.7.3-dev+5302
But that error still appear even in same callback, when global variable is array. *Reset works when give parameter true or false

PHP Code:

DataPack g_hMenuDataPack[MAXPLAYERS + 1];
func1(int iClient)
{
    if(g_hMenuDataPack[iClient] != null)
    {
        delete g_hMenuDataPack[iClient];
        g_hMenuDataPack[iClient] = null;
    }

    g_hMenuDataPack[iClient] = new DataPack();
    g_hMenuDataPack[iClient].WriteString("asd");
    g_hMenuDataPack[iClient].WriteCell(123);
    g_hMenuDataPack[iClient].WriteCell(123);
    g_hMenuDataPack[iClient].Reset(); // Error
} 


But non-array works fine.

PHP Code:

DataPack g_hMenuDataPack;
func1(int iClient)
{
    if(g_hMenuDataPack != null)
    {
        delete g_hMenuDataPack;
        g_hMenuDataPack = null;
    }

    g_hMenuDataPack = new DataPack();
    g_hMenuDataPack.WriteString("asd");
    g_hMenuDataPack.WriteCell(123);
    g_hMenuDataPack.WriteCell(123);
    g_hMenuDataPack.Reset(); //Work
} 


*edit
maybe it not get default bool value from ResetPack function from methodmap or something