[Solved] Expression has no effect

eNNkds · **Author**

hello, i request some help to fix this... last 2 lines gives me the warning

scripting\zm.sma(933 -- 934) : warning 215: expression has no effect

Code:

public NewAppNum()
{
	// New Appear Need Num
	new AliveZombieCount
	for(new i=0;i<MAXPLAYERS+1;i++)
		if(g_isZombie[i] && g_isAlive[i]) AliveZombieCount ++
	g_iBossAppearNeedKill = AliveZombieCount + 1	
	if(AliveZombieCount > 4) g_iBossAppearNeedKill
	print_color(0, "This round the boss will appear after %d zombies die", g_iBossAppearNeedKill);
}

DJEarthQuake · 12-09-2022 , 14:03 Re: Expression has no effect

It looks like variable, g_iBossAppearNeedKill, was pasted in by mistake.

Code:

public NewAppNum()
{
    // New Appear Need Num
    new AliveZombieCount

    for(new i=0;i<MAXPLAYERS+1;i++)
    if(g_isZombie[i] && g_isAlive[i])
        AliveZombieCount ++

    g_iBossAppearNeedKill = AliveZombieCount + 1

    if(AliveZombieCount > 4)/*g_iBossAppearNeedKill*/
        print_color(0, "This round the boss will appear after %d zombies die", g_iBossAppearNeedKill);
}

Quote:

Originally Posted by eNNkds

hello, i request some help to fix this... last 2 lines gives me the warning

scripting\zm.sma(933 -- 934) : warning 215: expression has no effect

Code:

public NewAppNum()
{
	// New Appear Need Num
	new AliveZombieCount
	for(new i=0;i<MAXPLAYERS+1;i++)
		if(g_isZombie[i] && g_isAlive[i]) AliveZombieCount ++
	g_iBossAppearNeedKill = AliveZombieCount + 1	
	if(AliveZombieCount > 4) g_iBossAppearNeedKill
	print_color(0, "This round the boss will appear after %d zombies die", g_iBossAppearNeedKill);
}

fysiks · *Last edited by fysiks; 12-09-2022 at 19:36.*

It is highly recommended that people use braces for code blocks for things like for, while, if, else, etc structures. Doing this can actually help you find issues in your code and makes it more obvious what code is being executed when.

Also, adding vertical whitespace can also help.

PHP Code:


			
public NewAppNum()
{
    // New Appear Need Num
    new AliveZombieCount

    for(new i=0;i<MAXPLAYERS+1;i++)
    {
        if(g_isZombie[i] && g_isAlive[i])
        {
            AliveZombieCount ++
        }
    }

    g_iBossAppearNeedKill = AliveZombieCount + 1

    if(AliveZombieCount > 4)
    g_iBossAppearNeedKill // <-- Out of place!
    {
        print_color(0, "This round the boss will appear after %d zombies die", g_iBossAppearNeedKill);
    }
}

eNNkds · 12-11-2022 , 05:36 Re: Expression has no effect

Thank you for helping it's compile withouth warnings now!