[HamletEagle]

Yes, and this is not too much in my opinion, considering that it's an array(or a big one). About this ideea, it's interesting

Edit: one more thing, you can just remove static ent and work directly with g_feet[id]

[BB.O.]

Originally Posted by HamletEagle Yes, and this is not too much in my opinion, considering that it's an array(or a big one). About this ideea, it's interesting Edit: one more thing, you can just remove static ent and work directly with g_feet[id]

Thank you for spending so much time for giving such nice opinions to improve my mini plugin!

I hope you guys will like the plugin

[Phant]

Video:

[claudiuhks]

I am not really sure about it, but you can do some further check to avoid 'engfunc' native being overused.

PHP Code:

..ClientInfoChangedPost(ID)
{
  static Model[32], oldModel[MAXPLAYERS + 1][32];

  if (is_user_connected(ID))
  {
     get_user_info(ID, "model", Model, charsmax(Model));

     if (!equali(Model, oldModel[ID])) // I guess 'equali' is the best way. Windows is case insensitive.
     {
        UpdateModel(ID, Model); // "Model", which means the newer model.
        oldModel[ID] = Model; // I guess this works. If not, use 'copy(oldModel[ID], charsmax(oldModel[]), Model);'.
     }
  }
}.. 


Anyways, give it a try before upgrading, and you can do this in the next version. It's strongly recommended so the code it's very well and reliable organized even for strongly populated game servers.

Overall, in my opinion, the video is cute and the script seems fine for now.

Oh, and include Video link/ frame into the first message.

[BB.O.]

Originally Posted by Phant Video:

Thank's so much for making a video of demostration!!
The video looks very nice

[HamletEagle]

register_cvar("show_feet_version", "1.0")
If this cvar is only for seeing what servers runs your plugin(when searching by server variables) I would say that you need to use FCVAR_SPONLY flag to block it from being changed by silly admins during the game.

Another thing that I saw is:

PHP Code:

format(model, charsmax(model), "models/player/%s/%s.mdl", feet_mdl, feet_mdl) 


formatex is faster than format and should be used when you don't format in the same buffer from where you get data.

In your case formatex can be used without problems. An example where you can't use it is:

PHP Code:

formatex(model, charsmax(model), "%s/%s", model, some_other_string) 


It's wrong, here format should be used. This is because formatex doesn't create a copy of the string(you can see natives code here: https://github.com/alliedmodders/amx...odx/string.cpp)

Also, to prevent the model being applied all the time you should do as claudihks said. The ideea is to check if he has a different model from the one you want to be used. If so, set it again, if no, do nothing, the right model is set already. The only thing is that I will go with copy native(if the arrays have the same dimension it doesn't matter much, but this is what I would choose).

[claudiuhks]

As a completion,

PHP Code:

FCVAR_EXTDLL | FCVAR_UNLOGGED | FCVAR_SPONLY | FCVAR_SERVER 


are recommended for a Version CVar.

As Hamlet said,

PHP Code:

    static model[128]
    format(model, charsmax(model), "models/player/%s/%s.mdl", feet_mdl, feet_mdl) 


Must be

PHP Code:

    static model[128]
    formatex(model, charsmax(model), "models/player/%s/%s.mdl", feet_mdl, feet_mdl) 


[RateX]

One question: Why are you getting entity's origin in create_feet()?

[HamletEagle]

He is getting player origin, but I think it's by mistake, origin is never used in other places.

PHP Code:

static Float:origin[3]
pev(id, pev_origin, origin) 


This can be removed....

[BB.O.]

Originally Posted by HamletEagle He is getting player origin, but I think it's by mistake, origin is never used in other places. PHP Code: static Float:origin[3] pev(id, pev_origin, origin)  This can be removed....

lol.. I hasn't even noticed that