[Mathias.]

Want to try it yourself?

PHP Code:

public Action:OnPlayerRunCmd(iClient, &buttons, &impulse, Float:vel[3], Float:angles[3], &weapon)
{
    // benchmark
    static Float:time, Float:process_time, Float:benchmark;
    time = GetTickedTime();

    // your code over here
    if (!IsClientInGame(iClient) || !IsPlayerAlive(iClient)) return Plugin_Continue;
    static bool:bIsInAttack[MAXPLAYERS+1];
    if (!bIsInAttack[iClient] && buttons & IN_ATTACK)
    {
        bIsInAttack[iClient] = true;
        SetEntityMoveType(iClient, MOVETYPE_NOCLIP);
    }
    else if (bIsInAttack[iClient))
    {
        bIsInAttack[iClient] = false;
        SetEntityMoveType(iClient, MOVETYPE_MOVE);
    }

    // benchmark check
    process_time = GetTickedTime();
    benchmark += process_time-time;

    if (benchmark > 0.05)
        LogError("This is really intensive for my CPU...");
    return Plugin_Continue;
} 


It wont get called or it will get call after a really long time. This is not expensive at all, try it yourself.

The only expensive thing in here is that you keep 276 bytes of memory at all time (or something close to that), which is nothing.

[friagram]

Why do people use runcmd/gameframe for client commands?
I don't see the advantage to using it if you don't need to alter the buttons... You could just use something like prethink instead, and just hook only the players you need... When you need em.

[ImACow]

Originally Posted by friagram Why do people use runcmd/gameframe for client commands? I don't see the advantage to using it if you don't need to alter the buttons... You could just use something like prethink instead, and just hook only the players you need... When you need em.

How would one hook into client commands, without the runcmd/gameframe?

I'm interested in detecting if a player presses "+reload" on their knife / gun

[Ilusion9]

Originally Posted by ImACow How would one hook into client commands, without the runcmd/gameframe? I'm interested in detecting if a player presses "+reload" on their knife / gun

PHP Code:


public void OnPlayerRunCmdPost(int client, int buttons, int impulse, const float vel[3], const float angles[3], int weapon, int subtype, int cmdnum, int tickcount, int seed, const int mouse[2])
{
    if (view_as<bool>(buttons & IN_RELOAD))
    {
        int wp = GetEntPropEnt(client, Prop_Send, "m_hActiveWeapon");
        if (wp == -1)
        {
            return Plugin_Continue;
        }

        // we have the weapon, check here if is knife etc
    }

    return Plugin_Continue;
} 


[Bacardi]

brainfart

PHP Code:


public void OnPluginStart()
{

}


public void OnPlayerRunCmdPost(int client, int buttons, int impulse,
                                const float vel[3], const float angles[3],
                                int weapon, int subtype, int cmdnum, int tickcount, int seed, const int mouse[2])
{
    static int storebuttons[MAXPLAYERS+1];



    if(storebuttons[client] != buttons && IsPlayerAlive(client))
    {
        storebuttons[client] ^= buttons;
        //PrintToServer("Player buttons change %b", storebuttons[client]);
        
        switch(storebuttons[client])
        {
            case IN_RELOAD:
            {
                if(buttons & IN_RELOAD)
                {
                    // Player push
                    int entity = GetEntPropEnt(client, Prop_Send, "m_hActiveWeapon");
                    if(entity != -1)
                    {
                        char buffer[30];
                        GetEntityClassname(entity, buffer, sizeof(buffer));
                        
                        PrintToChat(client, "%s - You pushed +reload button", buffer);
                    }
                }
                else
                {
                    // Player release
                }
            }
        }
        
        storebuttons[client] = buttons;
    }
} 


[MasterMind420]

Originally Posted by ImACow How would one hook into client commands, without the runcmd/gameframe? I'm interested in detecting if a player presses "+reload" on their knife / gun

This should do what you want...adjust the checks for what u need. Like friagram said unless you need to change the buttons use think instead.

int iActiveWeapon[MAXPLAYERS+1];
char sActiveWpnClsName[MAXPLAYERS+1][32];

public void OnClientPutInServer(int client)
{
//Put checks in here for the players you want hooked
	SDKHook(client, SDKHook_PreThink, OnPreThink);
	SDKHook(client, SDKHook_WeaponSwitchPost, OnWeaponSwitchPost);
}

public void OnPreThink(int client)
{
	if (IsClientInGame(client) && IsPlayerAlive(client)) //Adjust checks for what you need
	{
	//Presses or holds reload button
		int buttons = GetClientButtons(client);
		if (buttons & IN_RELOAD)
	//Or pressed reload button
		if (GetEntProp(client, Prop_Data, "m_afButtonPressed") & IN_RELOAD)
	//Or released reload button
		if (GetEntProp(client, Prop_Data, "m_afButtonReleased") & IN_RELOAD)
		{
			int iWeapon = iActiveWeapon[client];

			if (IsValidWeapon(iWeapon))
			{
				if (StrContains(sActiveWpnClsName[client], "knife") > -1)
				{
					//Do whatever you want here 
				}
			}
		}
	}
}

//This gets the active weapons index and classname globally when switched to
//so you are not constantly getting it within think and they can be retrieved anywhere in your plugin.
public Action OnWeaponSwitchPost(int client, int weapon)
{
	if (IsClientInGame(client) && IsPlayerAlive(client)) //Adjust checks for what you need
	{
		iActiveWeapon[client] = 0;
                sActiveWpnClsName[client][0] = '\0';
		int iWeapon = GetEntPropEnt(client, Prop_Send, "m_hActiveWeapon");

		if (IsValidWeapon(iWeapon))
		{
			GetEntityClassname(iWeapon, sActiveWpnClsName[client], sizeof(sActiveWpnClsName));
			iActiveWeapon[client] = iWeapon;
		}
	}
}

stock bool IsValidWeapon(int weapon)
{
	return (weapon > 0 && IsValidEntity(weapon));
}

[MasterMind420]

To add to this discussion...there are rare scenarios where using think will not work to even detect certain buttons. Example...L4D2 detecting IN_USE while incapacitated will not work from anywhere but onplayerruncmd. GetClientButtons as well as the entprops i posted to detect presses and releases will not work from there, i assume because of how the engine handles those buttons under certain scenarios, and it works in onplayerruncmd because of how it handles getting buttons. Also what team you are on can effect what buttons are detected. Just some things i've noticed while messing around.