[versatile_bfg]

Hi,

Quick question, which way is better/faster to get a server command value?

For this example I want to get the mp_maxrounds integer and divide it by 2 so I know when it is half time.

PHP Code:

public OnPluginStart()
{
g_h_max_rounds = FindConVar ("mp_maxrounds");
}

CheckScores() //checked at end of every round
{
    if (GetScore() == (GetConVarInt(g_h_max_rounds))/2)// half time
    {
// code
        } 


or

PHP Code:

CheckScores() //checked at end of every round
{
    if (GetScore() == (GetConVarInt(FindConVar("mp_maxrounds"))/2)// half time
    {
// code
        } 


Or should I store it and HookConVarChange with it divided by 2?

PHP Code:

new maxrounds = 15;

public OnPluginStart()
{
HookConVarChange(FindConVar("mp_maxrounds"), OnMaxRoundChangeMP);
}

public OnMaxRoundChangeMP(Handle:cvar, const String:oldVal[], const String:newVal[])
{
    maxrounds = (GetConVarInt(FindConVar("mp_maxrounds"))/2);

    if (g_live)
    {
        CheckScores();
    }
}

CheckScores() //checked at end of every round
{
    if (GetScore() == maxrounds)// half time
    {
// code
        } 


Or is it a much of a muchness and the top way just looks cleaner?

Looking to remove a lot of convar's from one of my plugins back to the normal server commands.

[Root_]

Better way would be hooking events. AFAIK announce_phase_end is called when halftime is reached, and cs_intermission when the map ends.

[versatile_bfg]

Originally Posted by Root_ Better way would be hooking events. AFAIK announce_phase_end is called when halftime is reached, and cs_intermission when the map ends.

This isn't the only command I want. Also helps with scoring, OT and other stuff. Just using this part as an example to fix up the rest the same way.

[Powerlord]

FindConVar can be somewhat expensive, so it's recommended you just do it once and save the Handle it returns.

[versatile_bfg]

Originally Posted by Powerlord FindConVar can be somewhat expensive, so it's recommended you just do it once and save the Handle it returns.

Cheers. So top one is the go. =)