[Sanjay Singh]

can you guys tell me whats diff in both codes?
which one will be better to use.

Code1:

PHP Code:

public filereadtest(id)
{
    new file = fopen(filename,"r")
    if(file)
    {
        new data[128]
        while(fgets(file, data, 127))
        {
            parse(data, data, 127)
            server_cmd("say ^"%s^"", data);
        }
        fclose(file)
    }
} 


Code2:

PHP Code:

public filereadtest(id)
{
    new file = fopen(filename,"r")
    if(file)
    {
        new data[128]
        while(!feof(file))
        {
            fgets(file, data, 127)

            parse(data, data, 127)
            server_cmd("say ^"%s^"", data);
        }
        fclose(file)
    }
} 


[redivcram]

feof

returns whether the end of the file has been reached.

fgets

does the same by indexing each line every time its called (from which feof can determine) in the file and outputs its content by reference.

[Sanjay Singh]

Originally Posted by redivcram feof returns whether the end of the file has been reached. fgets does the same by indexing each line every time its called (from which feof can determine) in the file and outputs its content by reference.

so which will be better? fgets?

[redivcram]

In your case, feof is redundant, by how I've tried to explain both. So fgets.

[HamletEagle]

If you are asking which one is more efficient: IT DOES NOT MATTER.

[Bugsy]

I think the fgets() method gets the nod to efficiency. Would it ever be noticeable? no, but on paper it is more efficient.

[fysiks]

I remember someone posting that feof() shouldn't be used for the condition in a while loop like this for some low-level reason. I'd have to search around to see if I could find it again.

Found it: https://forums.alliedmods.net/showthread.php?t=310086

[Sanjay Singh]

Thanks