[tuty]

you can optimize your code.. and indent your code -.-

[Pontifex]

tuty
Why? What is the problem? Detailed description of the problem please

[Dragonshadow]

Hold on pont, I'm modifying it to show you what he means.

[bman87]

Can you make it so if the cvar is 0 it changes everything back to normal?

Thanks.

[Dragonshadow]

Originally Posted by bman87 Can you make it so if the cvar is 0 it changes everything back to normal? Thanks.

Shoot me a pm or make a post here with all the default glow values.

[bman87]

Originally Posted by Dragonshadow Shoot me a pm or make a post here with all the default glow values.

I don't know the default values. Also,

shouldnt

PHP Code:

public OnClientPutInServer(client)
    {    
    if (client)
        {
            if(GetConVarInt(MLGlow)==1) 


be

PHP Code:

public OnClientPutInServer(client)
    {    
    if (client)
        {
            if(GetConVarInt(MLGlow)>0) 


I have the ml_glow cvar set to 2 by default, it doesn't look like it will start the timers this way.

I agree that this code can be heavily optimized, I have disabled this plugin for now until this plugin is cleaned up.

[Pontifex]

Hold on pont, I'm modifying it to show you what he means.

What have you changed? Give the source =)
It is sometimes difficult to understand you. My English bad

Can you make it so if the cvar is 0 it changes everything back to normal?

Yes. Version 1.2 release. BUT load on the server will still remain!
This can be rectified if the move if (GetConVarInt (MLGlow) to the timer
But then that would change the colors you will need to restart the map.

[bman87]

Originally Posted by Pontifex What have you changed? Give the source =) It is sometimes difficult to understand you. My English bad Yes. Version 1.2 release. BUT load on the server will still remain!

Thanks! But you still use way to many IF statements, you only need to use 1.

PHP Code:

if (GetConVarInt(MLGlow) == DEFAULT)        ClientCommand(client, "cl_glow_item_far_b 1.0");
        if (GetConVarInt(MLGlow) == DEFAULT)        ClientCommand(client, "cl_glow_item_far_g 0.4");
        if (GetConVarInt(MLGlow) == DEFAULT)        ClientCommand(client, "cl_glow_item_far_r 0.3"); 


Should be

PHP Code:

if (GetConVarInt(MLGlow) == DEFAULT)
        {
            ClientCommand(client, "cl_glow_item_far_b 1.0");
            ClientCommand(client, "cl_glow_item_far_g 0.4");
            ClientCommand(client, "cl_glow_item_far_r 0.3");
        } 


[Pontifex]

The habit

[bman87]

Even better you can use a switch statement.

PHP Code:

switch (GetConVarInt(MLGlow))
        {
            case DEFAULT:
            {
                ClientCommand(client, "cl_glow_item_far_b 1.0");
                ClientCommand(client, "cl_glow_item_far_g 0.4");
                ClientCommand(client, "cl_glow_item_far_r 0.3");
            }
            case Q1:
            {
                ClientCommand(client, "cl_glow_item_far_r 0.5");
                ClientCommand(client, "cl_glow_item_far_g 1.0");
                ClientCommand(client, "cl_glow_item_far_b 0.0");
            }
            case D1:
            {
                ClientCommand(client, "cl_glow_item_far_r 0.0");
                ClientCommand(client, "cl_glow_item_far_b 1.0");
                ClientCommand(client, "cl_glow_item_far_g 0.6");
            }
        }