[A k c 3 n 7]

delet

[DevilBoy.eXe]

Gj mate!
But no credits... thanks X(
Replace this

       client_print(0, print_chat,"[CSGO] Jucatorul %s a primit +300$ pentru planatarea bombei",szName)
       client_print(0, print_chat, "[CSGO] Jucatorul %s a primit +500$ pentru dezamorsarea bombei ",szName)

with this

       client_print(0, print_chat,"[CSGO] Player %s has received +300$ for planting the bomb!",szName)
       client_print(0, print_chat, "[CSGO] Player %s has received +500$ for defusing the bomb! ",szName)

Or make a lang file

[A k c 3 n 7]

Originally Posted by DevilBoy.eXe Gj mate! But no credits... thanks X( Replace this client_print(0, print_chat,"[CSGO] Jucatorul %s a primit +300$ pentru planatarea bombei",szName) client_print(0, print_chat, "[CSGO] Jucatorul %s a primit +500$ pentru dezamorsarea bombei ",szName) with this client_print(0, print_chat,"[CSGO] Player %s has received +300$ for planting the bomb!",szName) client_print(0, print_chat, "[CSGO] Player %s has received +500$ for defusing the bomb! ",szName) Or make a lang file

edited, thanks

[Ayman Khaled]

Why is szName[33] is a global array ?

+ Here you don't need a loop since you have only 1 sound in these consts.

PHP Code:

for(i = 0 ; i < sizeof g_szDefSound ; i++)
        precache_sound(g_szDefSound[i]);

    for(i = 0 ; i < sizeof g_szPlantedSound ; i++)
        precache_sound(g_szPlantedSound[i]); 


A small typo here , wati - > wait

PHP Code:

public logevent_round_end(id) {

       client_cmd(0, "wati;stopsound")
} 


[A k c 3 n 7]

i think is better

PHP Code:

public plugin_precache() {

        precache_sound( "csgo/planting.wav")
        precache_sound( "csgo/planting2.wav")
        precache_sound( "csgo/defusing.wav")
        precache_sound( "csgo/CSGOPlanted.wav")
} 


and

PHP Code:

       new szName[33]
       get_user_name(id,szName,32)
       cs_set_user_money(id,cs_get_user_money(id)+300)
       client_print(0, print_chat,"[CSGO] Player %s has received +300$ for planting the bomb!",szName) 


PHP Code:

       new szName[33]   
       get_user_name(id,szName,32)
       cs_set_user_money(id,cs_get_user_money(id)+500)
       client_cmd(0, "spk radio/bombdef.wav")
       client_print(0, print_chat, "[CSGO] Player %s has received +500$ for defusing the bomb!",szName) 


[Natsheh]

oLd but good job you have tried

[aron9forever]

I'll give you some tips since you posted this here, though by the looks of what you put there you don't really know what you're doing. The plugin is full off unnecessary code, which makes me believe you copied a lot of the code from other sources that use an array of sounds and play one randomly (such as round end music).

Anyways, here goes:

1) Use suggestive variable names, the cvar pointer names make no sense
2) Do not use two-dimensional arrays for when you're only storing one sound name. g_szDefSound[] = "csgo/defusing.wav" is enough
3) Use the strings you just defined above in precache, eg precache_sound(g_szDefSound)
4) You should clamp the money you set to 16000. Your plugin will go over 16000.
5) Again, use the variable you just declared globally in your spk command. client_cmd(0, "spk %s", g_szDefSound). Also, I think the spk won't work on latest steam clients anymore. Just use emit the sound on id 0 to play it globally.
6) Indent the code properly! You have lots of tabs all over the place, there is no structure whatsoever to the code, don't ignore the loose indentation warnings from your compiler
7) Use charsmax instead of hardcoded values eg get_user_name(id,szName,32) -> get_user_name(id,szName,charsmax(szName))

Finally, you named this plugin csgo bomb sounds, but it also gives bonus money. Either specify this in the plugin description, or remove the money bonus from it.

[A k c 3 n 7]

@aron9forever, you right it's my first plugin i'm documented from more plugins and sites but i don't know all about this, and about gives money i think it's no big problem it's just one little code

[Ayman Khaled]

Originally Posted by aron9forever 4) You should clamp the money you set to 16000. Your plugin will go over 16000.

just a small question, if i wont the money go over 16k.
is this example true ?

PHP Code:

new PlayerMoney = cs_get_user_money ( id )
clamp(PlayerMoney, 0, 16000) 


[aron9forever]

Originally Posted by Ayman Khaled just a small question, if i wont the money go over 16k. is this example true ? PHP Code: new PlayerMoney = cs_get_user_money ( id ) clamp(PlayerMoney, 0, 16000)

that is correct, but you either need to save the return value of the clamp or use it directly

PHP Code:

new PlayerMoney = cs_get_user_money ( id )
new limitedMoney = clamp(PlayerMoney, 0, 16000) 


or simply

PHP Code:

cs_set_user_money(id, clamp(cs_get_user_money(id) + 500, 0, 16000)) 


this is only if u ever also substract money
if you're only going to add to it then you can just use max(newMoney, 16000) and it will set either newMoney or 16000 whichever is bigger