[bibu]

What would be the difference and which one should be used?

PHP Code:

    /* 1. Method */
    
    new szText[14], iTextLen
    read_args(szText, sizeof(szText) - 1)
    
    szText[sizeof(szText) - 1] = 0
    iTextLen = strlen(szText)
        
    szText[iTextLen - 1] = 0;

    new szArg1[4], szArg2[3], szArg3[6]
    parse(szText[1], szArg1, sizeof(szArg1) - 1, szArg2, sizeof(szArg2) - 1, szArg3, sizeof(szArg3) - 1)
    
    szArg1[sizeof(szArg1) - 1] = 0
    szArg2[sizeof(szArg2) - 1] = 0
    szArg3[sizeof(szArg3) - 1] = 0
    
    /* 2. Method */
    
    new szArgs[14], szArg1[4], szArg2[3], szArg3[6]
    read_args(szArgs, charsmax(szArgs))
    remove_quotes(szArgs)
    parse(szArgs, szArg1, charsmax(szArg1), szArg2, charsmax(szArg2), szArg3, charsmax(szArg3)) 


[anakin_cstrike]

i don't see why using 1st, pointless...

[bibu]

Originally Posted by bibu What would be the difference...

[Exolent[jNr]]

1. read_args() would return the length of the string, so that strlen() call is useless.

2. szText[sizeof(szText) - 1] = 0
That makes no sense, because it will always be 0 even without that assignment.
If you think about it, sizeof(szText) - 1 is the last index of the array, and we all know the last index of a string must be 0 to terminate it.

3. After some testing, I've found that read_args() does not always have quotes around the text.
It seems that it only does from messagemode commands (such as say).

Therefore, if you did want to go away from remove_quotes, you would do this:

    new szText[14], iStart
    new iTextLen = read_args(szText, sizeof(szText) - 1)
    
    if(iTextLen > 1 && szText[0] == '"' && szText[iTextLen - 1] == '"')
    {
        szText[iTextLen - 1] = 0
        iStart = 1
    }
    
    new szArg1[4], szArg2[3], szArg3[6]
    parse(szText[iStart], szArg1, sizeof(szArg1) - 1, szArg2, sizeof(szArg2) - 1, szArg3, sizeof(szArg3) - 1)
    
    szArg1[sizeof(szArg1) - 1] = 0
    szArg2[sizeof(szArg2) - 1] = 0
    szArg3[sizeof(szArg3) - 1] = 0

[bibu]

Originally Posted by Exolent[jNr] Therefore, if you did want to go away from remove_quotes, you would do this.

Or use 2. method since it is only for messagemode.

[Exolent[jNr]]

Originally Posted by bibu Or use 2. method since it is only for messagemode.

Not exactly.
If the command is sent with quotes around it (ie. amx_test "Some string with quotes around it") then it will have quotes around it.
So you should always check for quotes with read_args()/