[ainur]

good job

bravo ma alka

[M249-M4A1]

Pretty good work

[Zenith77]

Before this gets approved, I would recommend you do the following:

    pcvar[0] = register_cvar("afk_autocheck", "1");
    pcvar[1] = register_cvar("afk_ac_fastmachine", "0");
    pcvar[2] = register_cvar("afk_ac_time", "20");
    pcvar[3] = register_cvar("afk_ac_immunity", "1");
    pcvar[4] = register_cvar("afk_ac_maxafktime", "80");
    pcvar[5] = register_cvar("afk_ac_punish_type", "1");
    pcvar[6] = register_cvar("afk_menu", "1");
    pcvar[7] = register_cvar("afk_ac_bombtime", "20");

This is the first time I've ever seen anyone do this, lol. While there is nothing really wrong with it code wise, it's not the best thing to do. I strongly recommend you use readable variable names, that or have an enumeration for it. For example:

enum Cvars
{
     CVAR_AUTOCHECK = 0,
     CVAR_FASTMACHINE,
     CVAR_ACTIME
}

new pcvar[Cvars];
    
pcvar[CVAR_AUTOCHECK] = register_cvar("afk_autocheck", "1");
pcvar[CVAR_FASTMACHINE] = register_cvar("afk_ac_fastmachine", "0");
pcvar[CVAR_ACTIME] = register_cvar("afk_ac_time", "20");

Once again, this is for readability.

On line 107 you declare the array 'Buffer' with a size of 64 cells within the loop. Don't do this, instead declare it outside the loop as so:

new Buffer[64]
for (/* */)
{
     // etc
}

Do this for all other arrays to.

I see you're using the variable player_id within functions to avoid re-declaring them each time. This really isn't a big save on memory, and is bad practice. Use static variables instead within the functions.

That's about all I can see for now. Please make this changes, unless you can provide a reason for why not to them.

[Alka]

OK >.>, i've optimized the code, thanks zenith .
About variable player_id, i can't use it as static because i need it in "AfkSubMenu_Handler(...)" too ;)

Ah, okay. I'll check the code when I get home (at school now).

[koloyu]

Good job

- And what with player recording demo? In old version of Afk Kisss ( http://forums.alliedmods.net/showthread.php?t=14419 ) is ~demo ask ( http://forums.alliedmods.net/attachm...4&d=1133093627 - start line 283)- That's don't work now, but maybe you know how to fix it? ;] Thats really useful tool (imho).
- Maybe add to the cvar afk_menu "0- off, 1- on, 2- on only for admins"
- Add cvar afk_immunity_level (like ptb_immunity_level in http://forums.alliedmods.net/showthread.php?t=26598 ).
- Finnaly here is Polish Lang:

[pl]
AFK_SPEC = [%s]Gracz %s zostal przeniesiony do Spectatorow, poniewaz byl AFK dluzej niz %d sekund.
AFK_KICK = [%s]Gracz %s zostal wykopany, poniewaz byl AFK dluzej niz %d sekund.
AFK_KICK_RND = [%s]Losowy gracz ze Spectatorow zostal wykopany za bycie AFK.
AFK_MENU_DISABLED = [%s]Menu AFK jest wylaczone!
AFK_BOMB_TRANSFER = [%s]Bomba zostala przekazana innemu graczowi, poniewaz %s jest AFK.

[Alka]

Thanks for the translation...

Updated v1.1a
*afk_menu 0(Off) 1(All) 2(Admins).
*Immunity flag check at autocheck afk and spectators.
#define ADMIN_IMMUNITY_FLAG ADMIN_KICK
*If user is recording a demo will not be kicked from spectators,even if is a normal player.

About Afk spec check, is already included when someone is moved because is afk at spectators the players are checked.

[ConnorMcLeod]

You should kick spectator who have been AFK for the longest time instead of random, or add a cvar for chose.

[Mordekay]

german translation

[de]
AFK_SPEC = [%s]Spieler %s wurde zu den Spectators verschoben, weil er laenger als %d sek. AFK war.
AFK_KICK = [%s]Spieler %s wurde gekickt, weil er laenger als %d sek. AFK war.
AFK_KICK_RND = [%s]Ein Zufaellig ausgewaehlter Spectator wurde gekickt weil er AFK war.
AFK_MENU_DISABLED = [%s]Entschuldige, das AFK Menue ist abgeschaltet!
AFK_BOMB_TRANSFER = [%s]Spieler %s wurde gedroped & verschob die Bombe weil er AFK war.

[koloyu]

Found bug:
Plugin starts too quickly (starts when connecing- imho must start at player connected). So sometimes (with afk_ac_maxafktime 70) plugin kicks player a few seconds after he's connected (and reading motd/choosing team).

[manix]

Nice Alka

What happens when an AFK player is switched to spectator just before changelevel ? On next map, as AFK, he won't choose any team.

What about add an kick option for all players that don't join a side when they arrive on server ?