[Accelerator]

Faced a problem, and I do not understand what happened...

Signature:

/* CTerrorGameRules::GetVersusCompletion(CTerrorPlayer*) */
_ZN16CTerrorGameRules19GetVersusCompletionEP13CTerrorPlayer

When I try to get the value with the help of SDKTools, everything works fine:

#include <sourcemod>
#include <sdktools>

Handle GetFlowDistanceSDKCall = null;
public void OnPluginStart()
{
	StartPrepSDKCall(SDKCall_GameRules);
	if (!PrepSDKCall_SetSignature(SDKLibrary_Server, "\x55\x8B\xEC\x83\xEC\x2A\x53\x56\x8B\x75\x2A\x8B\xD9\x85\xF6\x2A\x2A\x2A\x2A\x2A\x2A\x8B\xCE", 23))
		PrepSDKCall_SetSignature(SDKLibrary_Server, "@_ZN16CTerrorGameRules19GetVersusCompletionEP13CTerrorPlayer", 0)
	PrepSDKCall_AddParameter(SDKType_CBasePlayer, SDKPass_Pointer);
	PrepSDKCall_SetReturnInfo(SDKType_PlainOldData, SDKPass_Plain);
	GetFlowDistanceSDKCall = EndPrepSDKCall();
	if (GetFlowDistanceSDKCall == null)
	{
		SetFailState("Unable to find the signature!");
	}
	
	RegConsoleCmd("sm_test", test);
}

public Action test(client, args)
{
	PrintToChatAll("%d", SDKCall(GetFlowDistanceSDKCall, client));
}

But when I try to do this in an extension, the server crashes when I call the function
Part of the code:

int VersusCompletion::GetVersusCompletion(int *client)
{
	void *pGameRules;
	if (!g_pSDKTools || !(pGameRules = g_pSDKTools->GetGameRules()))
	{
		g_pSM->LogError(myself, "Failed to find GameRules");
		return 0;
	}

	static int (*GetVersusCompletionFunc)(void *, CBaseEntity*);
	if(!GetVersusCompletionFunc) 
	{
		if( !g_pGameConf->GetMemSig("CTerrorGameRules_GetVersusCompletion", (void**)&GetVersusCompletionFunc) || !GetVersusCompletionFunc ) 
		{
			g_pSM->LogError(myself, "Can't resolve CTerrorGameRules_GetVersusCompletion signature");
			return 0;
		}
	}
	CBaseEntity *pPlayer = gamehelpers->ReferenceToEntity(client);
	if(!pPlayer) return 0;

	return GetVersusCompletionFunc(pGameRules, pPlayer);
}

I found out that this is happening, obviously, because of the substitution of pGameRules (g_pSDKTools->GetGameRules()), but without them the function is not working... I can not understand what I'm doing wrong...
On older versions of the sourcemod (1.6.2 and older) function worked fine, after moving to branch 1.7 and newer the server began to fall.
I ask help

[WildCard65]

try:

PHP Code:

class CTerrorGameRules;
class CTerrorPlayer;

/* In function int VersusCompletion::GetVersusCompletion(int *client) */
static int (CTerrorGameRules::*GetVersusCompletionFunc(CTerrorPlayer *);

/* Later in same function */
(static_cast<CTerrorGameRules *>(pGameRules)->*GetVersusCompletionFunc)(static_cast<CTerrorPlayer *>(pPlayer)); 


Also why are you passing a pointer instead of an integer to ReferenceToEntity, why is your client param a pointer anyway?

[Accelerator]

Originally Posted by WildCard65 Also why are you passing a pointer instead of an integer to ReferenceToEntity, why is your client param a pointer anyway?

My mistake

Tried:

class CTerrorGameRules;
class CTerrorPlayer;

int VersusCompletion::GetVersusCompletion(int client)
{
	void *pGameRules;
	if (!g_pSDKTools || !(pGameRules = g_pSDKTools->GetGameRules()))
	{
		g_pSM->LogError(myself, "Failed to find GameRules");
		return 0;
	}

	static int (CTerrorGameRules::*GetVersusCompletionFunc)(CTerrorPlayer *);
	if(!GetVersusCompletionFunc) 
	{
		if( !g_pGameConf->GetMemSig("CTerrorGameRules_GetVersusCompletion", (void**)&GetVersusCompletionFunc) || !GetVersusCompletionFunc ) 
		{
			g_pSM->LogError(myself, "Can't resolve CTerrorGameRules_GetVersusCompletion signature");
			return 0;
		}
	}
	CBaseEntity *pPlayer = gamehelpers->ReferenceToEntity(client);
	if(!pPlayer) return 0;

	return (static_cast<CTerrorGameRules *>(pGameRules)->*GetVersusCompletionFunc)(reinterpret_cast<CTerrorPlayer *>(pPlayer)); // reinterpret_cast - because 'error: invalid static_cast from type 'CBaseEntity*' to type 'CTerrorPlayer*'. 
}

===> Server crashed when function call
I also tried changing the CTerrorPlayer to CBasePlayer. The server is also falling.

[Accelerator]

I checked. On windows, everything works fine and with my old example, but on linux this all does not work.

[WildCard65]

By chance, when you declare the function pointer, try setting it to nullptr and see if it crashes still

[Accelerator]

I tried reinterpret_cast<CTerrorPlayer *>(pPlayer) -->> reinterpret_cast<CTerrorPlayer *>(nullptr). No crash. But the function then does not work (of course)

[WildCard65]

I meant:

PHP Code:

static int (CTerrorGameRules::*GetVersusCompletionFunc)(CTerrorPlayer *) = nullptr; 


[Accelerator]

Also tried. With this crash.

[Accelerator]

It seems that the player parameter (pPlayer) is incorrectly send. It seems that the data type is some other, but which one... But CTerrorPlayer is the same as CBaseEntity...
How can I get the CBasePlayer data type from SDKTools?

[asherkin]

The type of a pointer doesn't matter, your problem is calling conventions.
If you look at the source for my Connect extension there are some examples in there you can copy.