[reinert]

Hey, I've make native like get_user_skill, but it always returns 1... where is the problem ??

PHP Code:

get_user_skill(id)
{
    return ( (iKills[id] / iDeaths[id]) + (iHeadshots[id] / iKills[id]) * 32 );
} 


PHP Code:

client_printc(id, "\g[ RANK ]\n You've %d skill, %d kills,  %d deaths, %d headshots.", get_user_skill(id), iKills[id], iDeaths[id],  iHeadshots[id]) 


iKills = 6451
iDeaths = 4198
iHeadshots = 3216

(6451 / 4198) + (3216 / 6451) * 32 = ~17

Print output:

[ RANK ] You've 1 skill, 6451 kills, 4198 deaths, 3216 headshots

[ConnorMcLeod]

(6451 / 4198) + (3216 / 6451) * 32 = 1

6451 / 4192 = 1

3216 / 6451 = 0

0 * 32 = 0

1 + 0 = 1


/ is the entire division.
You should float the values, and round the result.


Or :

PHP Code:

get_user_skill(id)
{
    return ( (1000*iKills[id] / iDeaths[id]) + (1000*iHeadshots[id] / iKills[id]) * 32 ) / 1000;
} 


[reinert]

Thanks! SOLVED

[reinert]

Um I'm getting some errors in my logs, please help:

L 01/25/2011 - 19:10:02: [AMXX] Displaying debug trace (plugin "rank.amxx") L 01/25/2011 - 19:10:02: [AMXX] Run time error 11: divide L 01/25/2011 - 19:10:02: [AMXX] [0] rank.sma::get_user_skill (line 314) L 01/25/2011 - 19:10:02: [AMXX] [1] rank.sma::Save_MySql (line 283) L 01/25/2011 - 19:10:02: [AMXX] [2] rank.sma::client_disconnect (line 303)

line 314:

PHP Code:

return ( (1000*iKills[id] / iDeaths[id]) + (1000*iHeadshots[id] / iKills[id]) * 1954 ) / 1000; 


Line 283:

PHP Code:

format(szTemp,charsmax(szTemp),"UPDATE `rank` SET `name` = '%s', `kills` = '%d', `deaths` = '%d', `headshots` = '%d', `skill` = '%d' WHERE `rank`.`SteamID` = '%s';",szName, iKills[id], iDeaths[id], iHeadshots[id], get_user_skill(id), szSteamID); 


Line 303:

PHP Code:

public client_disconnect(id)
{
    Save_MySql(id); // <- 303
    iKills[id] = 0;
    iDeaths[id] = 0;
    iHeadshots[id] = 0;
    iBonus[id] = 0;
} 


[Exolent[jNr]]

Probably because you are dividing by 0.

[reinert]

So what shall I do ?

[Exolent[jNr]]

Check if variables equal 0 and do something different?

[reinert]

In which part should I check it ? Before saving or where ?

PHP Code:

if(iKills[id] != 0 || iDeaths[id] != 0)
{
   client_printc(id, "Your skill is", get_user_skill(id))
} 


[Exolent[jNr]]

Inside get_user_skill().

[reinert]

should I return false, yes ?