[Jcrr]

Hello, I'm making plugin that uses timers and I'm sitting here like 4 hours straight, and simply cannot kill timer...
Super simple description:
On player spawn > start timer
On player death > stop timer

Code:

PHP Code:

#pragma semicolon 1

#include <sourcemod>
#include <sdktools>
#include <cstrike>

Handle DelayTimer[MAXPLAYERS+1];
Handle ScoreTimer[MAXPLAYERS+1];

public OnPluginStart()
{
    HookEvent("player_death", OnPlayerDeath);
    HookEvent("player_spawn", OnPlayerSpawnEvent);
}

public Action:OnPlayerSpawnEvent(Handle:event, const String:name[], bool:dontBroadcast)
{
    new pClient = GetClientOfUserId(GetEventInt(event, "userid"));

    PrintToChat(pClient, "[DEBUG] START_DELAY");
    DelayTimer[pClient] = CreateTimer(30.0, delay, GetEventInt(event, "userid"), TIMER_REPEAT);
    ScoreTimer[pClient] = CreateTimer(15.9, getpoint, GetEventInt(event, "userid"), TIMER_REPEAT);
}

public OnPlayerDeath(Handle:event, const String:name[], bool:dontBroadcast)
{
    new pClient = GetClientOfUserId(GetEventInt(event, "userid"));
    PrintToChat(pClient, "[DEBUG] KILLTIMERS");
    KillTimer(DelayTimer[pClient]);
    KillTimer(ScoreTimer[pClient]);
    DelayTimer[pClient] = null;
    ScoreTimer[pClient] = null;
}

public Action:delay(Handle:timer, any:userid)
{
    new pClient = GetClientOfUserId(userid);
    PrintToChat(pClient, "[DEBUG] START_SCORING");
}

public Action:getpoint(Handle:timer, any:userid)
{
    //do stuff
} 


All debug messages are shown, but when player dies, timers are still running (they are not killed)...

Can you guys please help me out because i run out of ideas :/?

ps: i know about existence of this: "https://wiki.alliedmods.net/Timers_(SourceMod_Scripting)"

[Michael Shoe Maker]

In the call back set the timer Handle to null. Use delete instead of KillTimer:

PHP Code:

public Action:delay(Handle:timer, any:userid)
{
    new pClient = GetClientOfUserId(userid);
    PrintToChat(pClient, "[DEBUG] START_SCORING");

    DelayTimer[GetClientOfUserId(userid)] = null;
} 


PHP Code:

delete DelayTimer[pClient] 


[Jcrr]

Originally Posted by Michael Shoe Maker In the call back set the timer Handle to null. Use delete instead of KillTimer: PHP Code: public Action:delay(Handle:timer, any:userid) {     new pClient = GetClientOfUserId(userid);     PrintToChat(pClient, "[DEBUG] START_SCORING");     DelayTimer[GetClientOfUserId(userid)] = null; }  PHP Code: delete DelayTimer[pClient]

Can you be more precise? Because i can't find single thing related to "delete blahblah" in sourcemod

[nOProblem]

PHP Code:

#include <sourcemod>
#include <cstrike>
#include <sdktools>
#pragma semicolon 1
#pragma newdecls required


Handle delayTimer[MAXPLAYERS+1];
Handle scoreTimer[MAXPLAYERS+1];


public void OnPluginStart()
{
    HookEvent("player_spawn", PlayerSpawn);
    HookEvent("player_death", PlayerDeath);
}

public Action PlayerSpawn(Event event, const char[] name, bool dontBroadcast)
{
    int client = GetClientOfUserId(GetEventInt(event, "userid"));

    PrintToChat(client, "[DEBUG] START_DELAY");
    
    delayTimer[client] = CreateTimer(30.0, Delay, client, TIMER_REPEAT);
    scoreTimer[client] = CreateTimer(15.9, GetPoint, client, TIMER_REPEAT);
}

public Action Delay(Handle timer, any client)
{
    PrintToChat(client, "[DEBUG] START_SCORING");
    
    // do stuff here..
    
    
    delayTimer[client] = null;
    
    return Plugin_Stop;
}

public Action GetPoint(Handle timer, any client)
{
    // do stuff here..
    
    
    scoreTimer[client] = null;
    
    return Plugin_Stop;
}

public Action PlayerDeath(Event event, const char[] name, bool dontBroadcast)
{
    int client = GetClientOfUserId(GetEventInt(event, "userid"));
    
    PrintToChat(client, "[DEBUG] KILLTIMERS");
    
    if(delayTimer[client] != null)
    {
        CloseHandle(delayTimer[client]);
        delayTimer[client] = null;
    }
    
    if(scoreTimer[client] != null)
    {
        CloseHandle(scoreTimer[client]);
        scoreTimer[client] = null;
    }
}

public void OnClientDisconnect(int client)
{
    if(delayTimer[client] != null)
    {
        CloseHandle(delayTimer[client]);
        delayTimer[client] = null;
    }
    
    if(scoreTimer[client] != null)
    {
        CloseHandle(scoreTimer[client]);
        scoreTimer[client] = null;
    }
} 


This is just an example of how you could do it.. I added OnClientDisconnect, just for the safety..
The keyword "delete" is also an option, but better try it with this version, because "delete" is not documented for Timers..

[8guawong]

delete is the new syntax I think it = closehandle

[Jcrr]

nOProblem
I tried to do it like this way, but it wont work for 2 reasons:
1. In exactly your version, all timers work only once (1 time loop)
2. If i redo it to repeat the timers, this will happend:

When player will respawn before timer can check if it's null, they simply wont end, and there will be 2 timers running (they will stack). And in addition i tried to do it like this earlier.

Only option working for me, will be instakill any timer at any time.

[8guawong]

i think some1 had this problem before
its b/c player_spawn fire twice or something before they actually spawns
so check if client is alive or something before creating a timer

[Jcrr]

8guawong
I'm aware about first spawn twice timer start, it's very easy to solve, but still, it wont help with kill timers.
If player will die, and then timer will check if it should run, it's ok.
If player will die, timer won't check if it should run, because player will respawn, it's not ok.

Thats why i need method to instakill timer, so i won't rely on timers loop checks, timers variable checks and so on.

[8guawong]

do a start_timer[client] = true on player_spawn and start_timer[client] = false;

then in your timercallback do

if (!start_timer[client])
return Plugin_Stop;

XDDDD

[nOProblem]

nOProblem I tried to do it like this way, but it wont work for 2 reasons: 1. In exactly your version, all timers work only once (1 time loop) 2. If i redo it to repeat the timers, this will happend: When player will respawn before timer can check if it's null, they simply wont end, and there will be 2 timers running (they will stack). And in addition i tried to do it like this earlier. Only option working for me, will be instakill any timer at any time.

I actually don´t know, what your plugin should do, that´s why I can´t add some bools in the events.. and like 8guawong said, you have to add some bools to your plugin for sure..
Give us more information about your plugin.. What should it do? So we can help you a way better with the timers