[bmxican0091]

I am wanting to add a enable CVar to a plugin im editing, since im new to coding could someone please help me out with explenation and re-written code?

PHP Code:

/**
 * I did not create this plugin 
 * I am modifying it to add some features
 * Original plugin creator atom0s
 */
 
#pragma semicolon 1
 
#include <sourcemod>
#include <colors>
 
#define PLUGIN_VERSION "1.0"
 
new Handle:g_Cvarenabled = INVALID_HANDLE;
 
public Plugin:myinfo =
{
     name        = "*NEW* Simple Admin Message",
     author      = "atom0s",
     description = "Display a message to admins when they connect.",
     version     = PLUGIN_VERSION,
        url         = "http://www.sourcemod.net/"
};
 
public OnPluginStart( )
{
  CreateConVar("sm_simpleadminmsg_version", PLUGIN_VERSION, "Simple Admin Message version", FCVAR_PLUGIN|FCVAR_SPONLY|FCVAR_REPLICATED|FCVAR_NOTIFY);
}
 
public OnClientPostAdminCheck( client )
{
     new AdminId:aid = GetUserAdmin( client );
     if( aid != INVALID_ADMIN_ID )
     {
         CreateTimer(10, printMessage, client);
     }
}
 
public Action:printMessage(Handle:timer, any:client) {
        PrintToChat( client, "Welcome admin!" );
        PrintToChat( client, "Please use sm_admin to open the admin menu!" );
} 


[atom0s]

Heres the original with your question implemented:

PHP Code:

#pragma semicolon 1
#include <sourcemod>

public Plugin:myinfo =
{
    name        = "Simple Admin Message",
    author      = "atom0s",
    description = "Display a message to admins when they connect.",
    version     = "1.0.0",
    url         = "N/A"
};

new Handle:g_CvarPluginEnabled = INVALID_HANDLE;

public OnPluginStart( )
{
    CreateConVar( "simpleadminmsg_version", "1.0.0", "Simple Admin Message version.", FCVAR_PLUGIN|FCVAR_REPLICATED|FCVAR_NOTIFY);
    g_CvarPluginEnabled = CreateConVar( "simpleadminmsg_enabled", "1", "Admin message enable flag." );
}

public OnClientPostAdminCheck( client )
{
    // Don't continue if plugin is disabled.
    if( !GetConVarBool( g_CvarPluginEnabled ) )
        return;

    new AdminId:aid = GetUserAdmin( client );
    if( aid != INVALID_ADMIN_ID )
    {
        PrintToChat( client, "Welcome admin!" );
        PrintToChat( client, "Please use sm_admin to open the admin menu!" );
    }
} 


[bmxican0091]

Thanks for quick reply, so can i use the code like that on all plugins i want to add a Enable CVar to? Sorry im a bit of a noob with coding :S

PHP Code:

if( !GetConVarBool( g_CvarPluginEnabled ) )
    return; 


[atom0s]

The return may change depending on what the function you are exiting expects as a return. OnClientPostAdminCheck doesn't expect a return value, so simply using return; alone will leave the function gracefully.

However, in some cases you will have returns such as Action, bool, etc where you will need to return the specific type. In most cases it will either be Plugin_Continue or true for those return types, respectively.

[bmxican0091]

Thanks

[bmxican0091]

Im getting two errors when i compile, help pls?

PHP Code:

// simpleadminmsg.sp(38) : warning 217: loose indentation
// simpleadminmsg.sp(41) : warning 213: tag mismatch 


Here is my source code below:

PHP Code:

/**
 * I did not create this plugin 
 * I am modifying it to add some features
 * Original plugin creator atom0s
 */
 
#pragma semicolon 1
 
#include <sourcemod>
#include <colors>
 
#define PLUGIN_VERSION "1.0"
 
public Plugin:myinfo =
{
     name        = "*NEW* Simple Admin Message",
     author      = "atom0s",
     description = "Display a message to admins when they connect.",
     version     = PLUGIN_VERSION,
        url         = "http://www.sourcemod.net/"
};
 
new Handle:g_CvarPluginEnabled = INVALID_HANDLE;
 
public OnPluginStart( )
{
         CreateConVar("sm_simpleadminmsg_version", PLUGIN_VERSION, "Simple Admin Message version", FCVAR_PLUGIN|FCVAR_SPONLY|FCVAR_REPLICATED|FCVAR_NOTIFY);
         g_CvarPluginEnabled = CreateConVar( "sm_simpleadminmsg_enabled", "1", "Enables/Disables this plugin." );
}
 
public OnClientPostAdminCheck( client )
{
         if( !GetConVarBool( g_CvarPluginEnabled ) )
         return;
 
         new AdminId:aid = GetUserAdmin( client );
         if( aid != INVALID_ADMIN_ID )
         {
            CreateTimer(10, printMessage, client);
         }
}
 
public Action:printMessage(Handle:timer, any:client) {
        PrintToChat( client, "Welcome admin!" );
        PrintToChat( client, "Please use sm_admin to open the admin menu!" );
} 


[Bacardi]

Originally Posted by bmxican0091 Im getting two errors when i compile, help pls? PHP Code: // simpleadminmsg.sp(38) : warning 217: loose indentation // simpleadminmsg.sp(41) : warning 213: tag mismatch  ...

simpleadminmsg.sp(38) : warning 217: loose indentation
You maybe get these errors because you copy code from here forum post and paste to your source file *.sp.
Forum post change TAB-spaces to normal SPACE.

simpleadminmsg.sp(41) : warning 213: tag mismatch
If you look line 41, there have been given integer value instead float.
you can change it
CreateTimer(10.0, printMessage, client);

But these are little warnings, plugin should be work... or give more errors during game :P


I wonder why you have include #include <colors>, but you never use it in code.
Read more [INC] Colors (1.0.4)

[bmxican0091]

Originally Posted by Bacardi simpleadminmsg.sp(3 : warning 217: loose indentation You maybe get these errors because you copy code from here forum post and paste to your source file *.sp. Forum post change TAB-spaces to normal SPACE. simpleadminmsg.sp(41) : warning 213: tag mismatch If you look line 41, there have been given integer value instead float. you can change it CreateTimer(10.0, printMessage, client); But these are little warnings, plugin should be work... or give more errors during game I wonder why you have include #include <colors>, but you never use it in code. Read more [INC] Colors (1.0.4)

I have included colors because i am adding features, the plugin isnt finished yet, was just going to fix these errors first. Any ways thanks for the help