Question about modularizing code

8guawong · **Author**

trying to learn how to modularizing code
but having trouble
following is my code
i can't get "test2" or "test2 from main" to print only prints "hello"

main.sp

PHP Code:


			
#include <sourcemod>



#if !defined STANDALONE_BUILD

#include "module/test2.sp"

#endif



public OnPluginStart()

{

    HookEvent("player_jump", Event_PlayerJump);

    

#if !defined STANDALONE_BUILD

    Test2_OnPluginStart();

#endif



}



public Action:Event_PlayerJump(Handle:event, const String:name[], bool:dontBroadcast)

{

    new client = GetClientOfUserId(GetEventInt(event, "userid"));



    if(!IsClientInGame(client))

        return Plugin_Continue;

    PrintToChat(client, "hello");

    return Plugin_Continue;



    #if !defined STANDALONE_BUILD

        Test2_OnPlayerJump(client);

    #endif

        

    return Plugin_Continue;

}

test2.sp

PHP Code:


			
#if defined STANDALONE_BUILD

#include <sourcemod> //include sourcemod if compile by itself

#endif



#if defined STANDALONE_BUILD

public OnPluginStart() //use this if compile by itself

#else

public Test2_OnPluginStart() //use this if not compiled by itself

#endif

{

    PrintToServer("test2");

#if defined STANDALONE_BUILD

    HookEvent("player_jump", Test2_PlayerJump); //hook if compile by itself

#endif

}



#if defined STANDALONE_BUILD

public Action:Test2_PlayerJump(Handle:event, const String:name[], bool:dontBroadcast) //use this if compiled by itself

#else

public Test2_OnPlayerJump(client) //use this if not compiled by itself

#endif

{

    //use the follow code if compile by itself

    #if defined STANDALONE_BUILD

        new client = GetClientOfUserId(GetEventInt(event, "userid"));



        if(!IsClientInGame(client))

            return Plugin_Continue;

        PrintToChat(client, "test2");

    #endif

    PrintToChat(client, "test2 from main"); //use this if not compiled by itself

    

    #if defined STANDALONE_BUILD

        return Plugin_Continue;

    #endif

}

WildCard65 · *Last edited by WildCard65; 03-05-2015 at 21:59.*

One thing, you have unreachable code in main.sp's jump hook(being the bit calling test2's OnJump method).
Edit: Try below:
main.sp

PHP Code:


			
#include <sourcemod>
//#define STANDALONE_BUILD //Uncomment this if you want module test2 to become the main plugin.
#include "module/test2.sp"
#if !defined STANDALONE_BUILD
public OnPluginStart()
{
    HookEvent("player_jump", Event_PlayerJump);
    Test2_OnPluginStart();
}

public Action:Event_PlayerJump(Handle:event, const String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    if(!IsClientInGame(client))
        return Plugin_Continue;
    PrintToChat(client, "hello");
    Test2_OnPlayerJump(client);
    return Plugin_Continue;
}
#endif

test2.sp

PHP Code:


			
#if defined STANDALONE_BUILD
#include <sourcemod> //include sourcemod if compile by itself
#endif

#if defined STANDALONE_BUILD
public OnPluginStart() //use this if compile by itself
#else
public Test2_OnPluginStart() //use this if not compiled by itself
#endif
{
    PrintToServer("test2");
#if defined STANDALONE_BUILD
    HookEvent("player_jump", Test2_PlayerJump); //hook if compile by itself
#endif
}

#if defined STANDALONE_BUILD
public Action:Test2_PlayerJump(Handle:event, const String:name[], bool:dontBroadcast) //use this if compiled by itself
#else
public Test2_OnPlayerJump(client) //use this if not compiled by itself
#endif
{
    //use the follow code if compile by itself
    #if defined STANDALONE_BUILD
    new client = GetClientOfUserId(GetEventInt(event, "userid"));
    if(!IsClientInGame(client))
        return Plugin_Continue;
    PrintToChat(client, "test2");
    return Plugin_Continue;
    #else
    PrintToChat(client, "test2 from main"); //use this if not compiled by itself
    #endif
}

Lysis decompile of above code I posted:

PHP Code:


			
public Test2_OnPluginStart()
{
    PrintToServer("test2");
    return 0;
}

public Test2_OnPlayerJump(client)
{
    PrintToChat(client, "test2 from main");
    return 0;
}

public void:OnPluginStart()
{
    HookEvent("player_jump", Event_PlayerJump, EventHookMode:1);
    Test2_OnPluginStart();
    return void:0;
}

public Action:Event_PlayerJump(Handle:event, String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid", 0));
    if (!IsClientInGame(client))
    {
        return Action:0;
    }
    PrintToChat(client, "hello");
    Test2_OnPlayerJump(client);
    return Action:0;
}

8guawong · *Last edited by 8guawong; 03-05-2015 at 21:17.*

hey thanks! that worked after removing

Code:

return Plugin_Continue;

it works but my question is now why when i compile test2.sp by itself i get

PHP Code:


			
public Test2_OnPluginStart()
{
    PrintToServer("test2");
    return 0;
}

public Test2_OnPlayerJump(client)
{
    PrintToChat(client, "test2 from main");
    return 0;
}

when i'm expecting

PHP Code:


			
public void:OnPluginStart()
{
    HookEvent("player_jump", Test2_PlayerJump, EventHookMode:1);
    return 0;
}

public Action:Test2_PlayerJump(Handle:event, String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid", 0));
    if (!IsClientInGame(client))
    {
        return Action:0;
    }
    PrintToChat(client, "test2");
    return Action:0;
}

from lysis

WildCard65 · *Last edited by WildCard65; 03-05-2015 at 22:00.*

I get the following(with updated reply above with the define uncommented):

PHP Code:


			
public void:OnPluginStart()
{
    PrintToServer("test2");
    HookEvent("player_jump", Test2_PlayerJump, EventHookMode:1);
    return void:0;
}

public Action:Test2_PlayerJump(Handle:event, String:name[], bool:dontBroadcast)
{
    new client = GetClientOfUserId(GetEventInt(event, "userid", 0));
    if (!IsClientInGame(client))
    {
        return Action:0;
    }
    PrintToChat(client, "test2");
    return Action:0;
}

Edit: Reason your not getting your expected output with compiling test2 byitself cause of no define.

8guawong · 03-05-2015 , 22:14 Re: Question about modularizing code

Quote:

Originally Posted by WildCard65

I get the following(with updated reply above with the define uncommented):

PHP Code:


			
public void:OnPluginStart()

{

    PrintToServer("test2");

    HookEvent("player_jump", Test2_PlayerJump, EventHookMode:1);

    return void:0;

}



public Action:Test2_PlayerJump(Handle:event, String:name[], bool:dontBroadcast)

{

    new client = GetClientOfUserId(GetEventInt(event, "userid", 0));

    if (!IsClientInGame(client))

    {

        return Action:0;

    }

    PrintToChat(client, "test2");

    return Action:0;

}

Edit: Reason your not getting your expected output with compiling test2 byitself cause of no define.

ah thanks i knew it was something basic that i'm missing
i thought STANDALONE_BUILD was built into sourcemod

WildCard65 · 03-05-2015 , 22:22 Re: Question about modularizing code

Quote:

Originally Posted by 8guawong

ah thanks i knew it was something basic that i'm missing
i thought STANDALONE_BUILD was built into sourcemod

pretty sure it's not for SM plugins

8guawong · 03-05-2015 , 23:04 Re: Question about modularizing code

Quote:

Originally Posted by WildCard65

pretty sure it's not for SM plugins

doing some more testing, it seems like you can hook an event twice in one plugin??
i always thought it'll use the first hook

using example from above

main.php

PHP Code:


			
#include <sourcemod> 



#if !defined STANDALONE_BUILD 

#include "module/test2.sp" 

#endif 



public OnPluginStart() 

{ 

    HookEvent("player_jump", Event_PlayerJump); 

     

#if !defined STANDALONE_BUILD 

    Test2_OnPluginStart(); 

#endif 



} 



public Action:Event_PlayerJump(Handle:event, const String:name[], bool:dontBroadcast) 

{ 

    new client = GetClientOfUserId(GetEventInt(event, "userid")); 



    if(!IsClientInGame(client)) 

        return Plugin_Continue; 

    PrintToChat(client, "hello");          

    return Plugin_Continue; 

}

test2.php

PHP Code:


			
#if defined STANDALONE_BUILD 

public OnPluginStart() //use this if compile by itself 

#else 

public Test2_OnPluginStart() //use this if not compiled by itself 

#endif 

{ 

    PrintToServer("test2"); 

    HookEvent("player_jump", Test2_PlayerJump); //hook if compile by itself 

} 



public Action:Test2_PlayerJump(Handle:event, const String:name[], bool:dontBroadcast) //use this if compiled by itself 

{ 

     new client = GetClientOfUserId(GetEventInt(event, "userid")); 



    if(!IsClientInGame(client)) 

        return Plugin_Continue; 



    PrintToChat(client, "test2 from main"); //use this if not compiled by itself 

     

    return Plugin_Continue; 

}

is it bad to do this?

WildCard65 · 03-06-2015 , 06:52 Re: Question about modularizing code

First, let me explain how it works: HookEvent takes the input function and stores it in an internal function list that gets iterated on event fire. 2ndly, I have no idea if it's good or not.

friagram · 03-06-2015 , 07:22 Re: Question about modularizing code

using global forwards would be the easiest...