[PurposeLessx]

I made a plugin who works according to time. Is there any mistake here or how can I optimize it?

Spoiler

PHP Code:

// Using set_task(1.0, "controlclock", _, _, _, "b");

public controlclock();
{
    static ctime[3], btime[3];
    get_time("%H", ctime, charsmax(ctime));

    if(ctime[1] == '1' && ctime[2] == '1') // clock is 11.
    {
        get_time("%M", btime, charsmax(btime));
        if(btime[1] == '5' && btime[2] == '4' && equal(mapname, "jail_buyukisyan_dark"))
        {
            ClCmdVote11();
        }
        else if(btime[1] == '5' && btime[2] == '7' && equal(mapname, "jail_buyukisyan_dark"))
        {
            ClCmdVote12();
        }
    }
    else if(ctime[1] == '1' && ctime[2] == '2')
    {
        get_time("%M", btime, charsmax(btime));
        if(btime[1] == '0' && btime[2] == '0' && equal(mapname, "jail_buyukisyan_dark"))
        {
            ClCmdVote();
        }
    }
    else if(ctime[1] == '2' && ctime[1] == '1')
    {
        get_time("%M", btime, charsmax(btime));
        if(btime[1] == '5' && btime[2] == '5' && !equal(mapname, "jail_buyukisyan_dark"))
        {
            ClCmdVote13();
        }
    }        
    else if(ctime[1] == '2' && ctime[2] == '2')
    {
        get_time("%M", btime, charsmax(btime));
        if(btime[1] == '0' && btime[2] == '0' && !equal(mapname, "jail_buyukisyan_dark"))
        {
            format(nextmap, charsmax(nextmap), "jail_buyukisyan_dark");
            client_print_color(0, 0, "^1[^4%s^1] ^3Nextmap^1: ^4%s", tag, nextmap);
            set_pcvar_string(cvar_amx_nextmap, nextmap);
        }
    }
} 


[klippy]

Use time() so you don't have to work with strings. I don't know why people keep doing that, I've seen it many times over the years.

[maqi]

You are hardcoding and writing repetitive and inefficient code.

It could work, but the code you sent, In my opinion, is one big bad practice.

[PurposeLessx]

How I will use it?

PHP Code:

//static ctime[3], btime[3];
new ctime, btime;
time(ctime, btime);

if(ctime == 11) //if hours are 11

if(btime == 0) // if minute(s) is 0 


[maqi]

time() returns a unix timestamp, other than that, aarguments can be found here https://www.amxmodx.org/api/core/time

[PurposeLessx]

I don't understand in amxmodx.org. It's for not new codders I guess.

is it wrong?

PHP Code:

if(time(11)) // hours are 11? 


[maqi]

Yes its wrong, you were kinda fine the first time, arguments are variables to store info to.

[PurposeLessx]

So it's more optimized the first time?

[maqi]

Of course

[klippy]

Originally Posted by PurposeLessx How I will use it? PHP Code: //static ctime[3], btime[3]; new ctime, btime; time(ctime, btime); if(ctime == 11) //if hours are 11 if(btime == 0) // if minute(s) is 0

Yes, that is correct and is probably the best way to retrieve the current time in h/m/s as integers.