[Rirre]

- First:
I can't figure out a way to print a message to all players without getting an error.
This works:

int UTIL_TakeDamage( edict_t *pEdict, entvars_t *pevInflictor, entvars_t *pevAttacker, float flDamage, int bitsDamageType )
{
	if ( pEdict->v.health <= 0 )
	{
		CLIENT_PRINTF( pEdict, print_console, UTIL_VarArgs( "%s was killed by an %s\n",
			STRING( pEdict->v.netname ),
			STRING( pevAttacker->classname ) ) );
	}
}

But I need it to print to all players.
This one just crashing the server with SZ_GetSpace: Tried to write to an uninitialized sizebuf_t: ??? when I or anyone else gets killed:

int UTIL_TakeDamage( edict_t *pEdict, entvars_t *pevInflictor, entvars_t *pevAttacker, float flDamage, int bitsDamageType )
{
	if ( pEdict->v.health <= 0 )
	{
		for (int i = 1; i <= gpGlobals->maxClients; i++)
		{
			edict_t *pPlayer = INDEXENT(i);

			if( !pPlayer )
			{
				continue;
			}

			CLIENT_PRINTF( pPlayer, print_console, UTIL_VarArgs( "%s was killed by an %s\n",
				STRING( pEdict->v.netname ),
				STRING( pevAttacker->classname ) ) );
		}
	}
}

- Second:
Need some help with this to get a player's index and authid.
My (user)ID is 15 always, which is wrong. It's 1 as you can see yourself on the first line. And I have no idea what's happening with the authid.

int UTIL_TakeDamage( edict_t *pEdict, entvars_t *pevInflictor, entvars_t *pevAttacker, float flDamage, int bitsDamageType )
{
	if ( pEdict->v.health <= 0 )
	{
		UTIL_LogPrintf( "\"%s\" killed \"%s<%i><%s>\"\n",  
			STRING( pevAttacker->classname ),
			STRING( pEdict->v.netname ) ),
			GETPLAYERUSERID( pEdict ),
			GETPLAYERAUTHID( pEdict );
	}
}

Also, I'm pretty sure CS don't use pev->team for team assignment so I need one for both CS and other mods which use pev->team which I have no clue about how to do.

[Bos93]

First:

PHP Code:

#define IsValidPev(pEntity) (!FNullEnt(pEntity) && pEntity->pvPrivateData) 


PHP Code:

    for (int i = 1; i <= gpGlobals->maxClients; i++)
        {
            edict_t *pPlayer = INDEXENT(i);

            if( !IsValidPev( pPlayer ) )
                continue;
    
            CLIENT_PRINTF( pPlayer, print_console, UTIL_VarArgs( "%s was killed by an %s\n",
                STRING( pVictim->v.netname ),
                STRING( pevAttacker->classname ) ) );
    } 


Second:

UTIL_LogPrintf( "\"%s\" killed \"%s<%i><%s>\"\n", STRING( pevAttacker->classname ), STRING( pEdict->v.netname ) ), GETPLAYERUSERID( pEdict ), GETPLAYERAUTHID( pEdict );

->

UTIL_LogPrintf( "\"%s\" killed \"%s<%i><%s>\"\n", STRING( pevAttacker->classname ), STRING( pEdict->v.netname ), GETPLAYERUSERID( pEdict ), GETPLAYERAUTHID( pEdict ) );

[Rirre]

Thank you, appreciate it

Just the second one left now then.

[Bos93]

My message is updated

[Rirre]

Compiles fine without additional parentheses, if I add the additional parentheses:

Error: expected a ';'

[Bos93]

nooo

copypast

PHP Code:

UTIL_LogPrintf( "\"%s\" killed \"%s<%i><%s>\"\n", 
STRING( pevAttacker->classname ),
STRING( pEdict->v.netname ),
GETPLAYERUSERID( pEdict ),
GETPLAYERAUTHID( pEdict ) ); 


[Rirre]

Ah now I get it, where was a additional ')' after STRING( pEdict->v.netname ),
Thanks

[Bos93]

I highlighted with the red color version with the mistake, I hoped you understand

[claudiuhks]

For a much more logical method, you can check for health like that:

PHP Code:

if (!(ent->v.health > 0)) { }