[CoolJosh3k]

Might as well make a thread specifically for this issue...

When I try to force a tf_wearble weapon onto a player, the server crashes. tf_wearble is currently used for both solly and demo booties.

As well as crashing, I noticed various attempts to block that weapon, will give 2 secondary weapons. I quite often have both gunboats+shotgun(+rocket+shovel) as a result.

I presume this happens because there is an extra net prop associated with tf_wearable items, but I don't quite have the level of understanding to know.

[asherkin]

Please post some code.

[CoolJosh3k]

Sure, will this suffice?

PHP Code:

    if (class == TFClass_DemoMan)
    {
        slotid[0] = GetPlayerWeaponSlot(client, 0);
        /*
//////////    "tf_wearable" currently crashes server.
        if (slotid[0] == -1 && (GetConVarInt(disable_flags_demo) & 1) == 0)
        {
            new Handle:item = TF2Items_CreateItem(OVERRIDE_ALL | FORCE_GENERATION);
            TF2Items_SetClassname(item, "tf_wearable");
            TF2Items_SetItemIndex(item, def_dem_pri_itemid);
            TF2Items_SetQuality(item, 6);
            TF2Items_SetLevel(item, 1);
            TF2Items_SetNumAttributes(item, 2);
            TF2Items_SetAttribute(item, 0, 246, 2.0);
            TF2Items_SetAttribute(item, 1, 26, 25.0);
            slotid[0] = TF2Items_GiveNamedItem(client, item);
            EquipPlayerWeapon(client, slotid[0]);
            CloseHandle(item);
        }
//////////
        */
        slotid[1] = GetPlayerWeaponSlot(client, 1);
        if (slotid[1] == -1 && (GetConVarInt(disable_flags_demo) & 2) == 0)
        {
            new Handle:item = TF2Items_CreateItem(OVERRIDE_ALL | FORCE_GENERATION);
            TF2Items_SetClassname(item, "tf_weapon_pipebomblauncher");
            TF2Items_SetItemIndex(item, def_dem_sec_itemid);
            TF2Items_SetQuality(item, 6);
            TF2Items_SetLevel(item, 1);
            TF2Items_SetNumAttributes(item, 0);
            slotid[1] = TF2Items_GiveNamedItem(client, item);
            EquipPlayerWeapon(client, slotid[1]);
            CloseHandle(item);
        }
        slotid[2] = GetPlayerWeaponSlot(client, 2);
        if (slotid[2] == -1 && (GetConVarInt(disable_flags_demo) & 4) == 0)
        {
            new Handle:item = TF2Items_CreateItem(OVERRIDE_ALL | FORCE_GENERATION);
            TF2Items_SetClassname(item, "tf_weapon_sword");
            TF2Items_SetItemIndex(item, def_dem_mel_itemid);
            TF2Items_SetQuality(item, 6);
            TF2Items_SetLevel(item, 1);
            TF2Items_SetNumAttributes(item, 3);
            TF2Items_SetAttribute(item, 0, 15, 0.0);
            TF2Items_SetAttribute(item, 1, 125, -25.0);
            TF2Items_SetAttribute(item, 2, 219, 1.0);
            slotid[2] = TF2Items_GiveNamedItem(client, item);
            EquipPlayerWeapon(client, slotid[2]);
            CloseHandle(item);
        }
    } 


I just copy-pasted an old code block. I can give another example, if needed.

[Powerlord]

What's the value of def_dem_pri_itemid?

[CoolJosh3k]

It is 405, based on the initialization. Nothing changes it.

PHP Code:

new def_dem_pri_itemid = 405, def_dem_sec_itemid = 207, def_dem_mel_itemid = 132; 


[Powerlord]

Oh wait, didn't Asherkin say there were issues with FORCE_GENERATION and tf_wearable items before? Have you tried it without FORCE_GENERATION?

[CoolJosh3k]

Ah, yes. Sorry.

In my newer code, nothing uses FORCE_GENERATION, yet it still crashes with tf_wearable weapons.

[Powerlord]

I took a quick look at how [TF2Items] GiveWeapon does it. Apparently it special-cases tf_wearable, tf_wearable_demoshield, and tf_powerup_bottle... it doesn't call EquipPlayerWeapon, but instead makes a call to the server-side function CBasePlayer::EquipWearable (which has an offset included in a file). So, it's probably the EquipPlayerWeapon that's causing the crashes. (Fun fact: EquipPlayerWeapon is itself a wrapper for the server-side function CBasePlayer::Weapon_Equip)

Edit: The offsets for EquipWearable and RemoveWearable are in the automated offsets dump, too, in case you don't want to have to rely on another plugin's author to get the new values after an update.

[CoolJosh3k]

Any chance we might see an update to the tf2items, that updates how EquipPlayerWeapon works?

[asherkin]

Originally Posted by CoolJosh3k Any chance we might see an update to the tf2items, that updates how EquipPlayerWeapon works?

TF2Items is a low-level API, you'll always have to call the correct function for what you're doing.