[HamletEagle]

Please test if everything is working before posting a new version. Anyway:

Be consistent, use the same naming technique on all vars and functions, make sure every line has ;. Any style is ok as long as it's used everywhere in the plugin. Also make sure the spacing is correct(for example you should not have if(function()) and if( function( ) ) or if(function() ) or other variations at the same time).

Another thing:

PHP Code:

case WT_Weaponbox: call_think( ent );
                    
case WT_Shield: engfunc( EngFunc_RemoveEntity, ent );

case BT_BlockPickup: 
{    
        return PLUGIN_HANDLED; 
}
            default: 
            {
                return PLUGIN_CONTINUE; 
            } 


Use { } for single instructions nowhere or everywere, don't mix them.

pev_valid check should be the first one, not the last.

In cs_get_weaponbox_type you are still not using sizeof.

Fix above things, test and post if everything is working fine.

[Craxor]

Originally Posted by HamletEagle Please test if everything is working before posting a new version. Anyway: Be consistent, use the same naming technique on all vars and functions, make sure every line has ;. Any style is ok as long as it's used everywhere in the plugin. Also make sure the spacing is correct(for example you should not have if(function()) and if( function( ) ) or if(function() ) or other variations at the same time).

Ok, i checked everywhere and they are the same so you say 'where' you seee i'm using if(function()) insteand of my style if ( function( ) ); ... maybe i miss some but say where please

Another thing: PHP Code: case WT_Weaponbox: call_think( ent );                      case WT_Shield: engfunc( EngFunc_RemoveEntity, ent ); case BT_BlockPickup:  {             return PLUGIN_HANDLED;  }             default:              {                 return PLUGIN_CONTINUE;              }  Use { } for single instructions nowhere or everywere, don't mix them.

Done ... i use {} only on WT_Armoury .. sorry about this i observe it but i forgot to make the changes, thanks for reminder

pev_valid check should be the first one, not the last.

If you are talking about reset function where i have like that:

PHP Code:

if ( BlockType:get_pcvar_num( giTypeCvar ) == BT_Remove )
    {
        while ( ( iEntity = find_ent_by_class( iEntity , "armoury_entity" ) ) )
        {
            if ( ( g_ArmouryTypes[get_pdata_int( iEntity , m_iType , XoCArmoury ) ] ) && pev_valid( iEntity ) )
                ExecuteHam( Ham_CS_Restart , iEntity );
        }
    } 


It is not normaly to be there? if i'm taking the entity in the while after that i'm checking for entity ... or you're saying to leave the condition like that:

PHP Code:

if ( ( pev_valid( iEntity ) && g_ArmouryTypes[get_pdata_int( iEntity , m_iType , XoCArmoury ) ] ) ) 


In cs_get_weaponbox_type you are still not using sizeof.

Because it is a number there '5' sizeof is not returning the size from a variable ? So do you think i still should use it ?
sizeof 5; ... ??

Edit: Is not even compile Sizeof is not required there.

Fix above things, test and post if everything is working fine.

Ok

[HamletEagle]

Like that:

PHP Code:

if ( ( pev_valid( iEntity ) && g_ArmouryTypes[get_pdata_int( iEntity , m_iType , XoCArmoury ) ] ) ) 


PHP Code:

for ( new i = 1 ; i <sizeof m_rgpPlayerItems_CWeaponBox; i++ ) 


[Craxor]

All done, can you please check the source from first post? (also tested, it works!)

Now you can download , sorry about cs_get_weaponbox it is not my stock , i do your changes .. you can check the source now

[Craxor]

To do:
- ML.
- Find a solution to block also the kevlar.
- Create a the command 'amx_cspum' wich will show a list will cspum_ commands.

[HamletEagle]

The issue with kevlar not being loaded by nvault is that, in the gKeyList vest should have index 31, vesthelm will be 32 and shield 33. And on loading, when you do: ( 1 << i ) and i is 32 it goes back to 0 AFAIK(bugsy could explain more about this, I had always a hard time with bits). And 0 is to be ignored according with your gIgnoreWeapons. The solution is to remove that and simply check if gKeyList[i][0] is not EOS.

The const should look like this:

PHP Code:

new const gKeyList[][] = 
{ 
    "" , 
    "p228" , 
    "" , 
    "scout" , 
    "hegrenade" , 
    "xm1014" , 
    "c4" , 
    "mac10" , 
    "aug" , 
    "smokegrenade" , 
    "elite" , 
    "fiveseven" , 
    "ump45" , 
    "sg550" , 
    "galil" , 
    "famas" , 
    "usp" , 
    "glock18" , 
    "" , 
    "mp5navy" , 
    "m249" , 
    "m3" , 
    "m4a1" , 
    "tmp" , 
    "g3sg1" , 
    "flashbang" , 
    "deagle" , 
    "sg552" , 
    "ak47" , 
    "" , 
    "p90" , 
    "vest",
    "vesthelm",
    "shield"
}; 

const CSW_SHIELD = 33 


Also remove g_ArmouryTypes and use directly cs_get_armoury_type(ent) where needed.

[Craxor]

so the problem is with gBlockWeapons bitfield, it supports just 32 indexes or something like that?

Are you sure it should be vesthelm and not 'kevlar' ?
About gArmoury_Types:

Should look like this:

PHP Code:

cs_get_armoury_type( [get_pdata_int( iEntity , m_iType , XoCArmoury ) ] ) 


Or i directly put the entity ?

PHP Code:

cs_get_armoury_type( iEntity  ) 


[HamletEagle]

A cell has 32 bytes, so yeah. About what enums are you talking about?

[Craxor]

Check my edit ( forgot about what enum .. )

[Craxor]

Ok problem solved, now just to add ML for 'to do' list ... And also i waiting new ideas from bugsy&Hamlet and also others!