Raised This Month: $71 Target: $400
 17% 

[AMXX] CSGO Round End Events


Post New Thread Reply   
 
Thread Tools Display Modes
Black Rose
Veteran Member
Join Date: Feb 2011
Location: Upplands Väsby, Sweden
Old 08-04-2018 , 09:21   Re: [AMXX] CSGO Round End Events
Reply With Quote #91

Quote:
Originally Posted by OciXCrom View Post
Why not?
That is still determined when compiled using the includes and might not be the same version as the server running the plugin.
Everything compiled on this site using "Get Plugin" will be treated as 1.8.2 when compiled.

On topic:
Also, if this is changed (which I missed previously) the plugin can be compiled online.
Code:
#include <cl_buy>
->
Code:
forward client_buy(id, item);
__________________

Last edited by Black Rose; 08-04-2018 at 09:34.
Black Rose is offline
Send a message via Skype™ to Black Rose
OciXCrom
Veteran Member
Join Date: Oct 2013
Location: Macedonia
Old 08-04-2018 , 10:14   Re: [AMXX] CSGO Round End Events
Reply With Quote #92

That's exactly what I'm talking about. The compiler will determine if the function exists while compiling and will choose which code to execute. Here's a simple code that proves my point:

Code:
#include <cstrike> #if defined CS_OnBuy     #error test1 #else     #error test2 #endif

The code will output "test1" when compiled under a 1.8.3 compiler that has the CS_OnBuy function.
The code will output "test2" when compiled under a 1.8.2 compiler that doesn't have the CS_OnBuy function.

With that being said, he can simply do this:

Code:
#if defined CS_OnBuy public CS_OnBuy(id, iItem) #else public client_buy(id, iItem) #endif {     // Code... }
__________________
OciXCrom is offline
Send a message via Skype™ to OciXCrom
Black Rose
Veteran Member
Join Date: Feb 2011
Location: Upplands Väsby, Sweden
Old 08-04-2018 , 11:38   Re: [AMXX] CSGO Round End Events
Reply With Quote #93

I understand your point and you are right in theory if the compiler version and the AMXX version was exactly the same. However there's nothing guaranteeing that.

I have two servers, one with 1.8.2 and one with the latest dev version of 1.8.3. I don't have two sets of includes and compilers set up. I compile everything with 1.8.2 and make adjustments necessary if 1.8.3 functions are used. Why do I do this? Because this site has the exact same layout. I want everything I make being easily downloaded from this site, running without any issues and completely eliminated of all possible reasons for bugs.

If you compile this plugin using this website it will not have CS_OnBuy defined meaning it doesn't matter if you run 1.8.3 on your server. It's already gone as soon as you downloaded it and you are therefor required to use client_buy().

Don't get me wrong. There are things that should be checked while compiling but only to avoid compilation issues. You don't want to redefine or redeclare natives, constants or whatever. But it should never be used to determine variables in the runtime environment, the compiler doesn't have that information.

I'm doing a whole thread about this since I see this a lot. I'm just gathering information for it.
__________________

Last edited by Black Rose; 08-04-2018 at 11:42.
Black Rose is offline
Send a message via Skype™ to Black Rose
sekac
Senior Member
Join Date: Nov 2016
Old 09-05-2018 , 12:43   Re: [AMXX] CSGO Round End Events
Reply With Quote #94

I still haven't been able to get the ace message... There are 5 enemies and I kill all of them and instead of the ace message I get you killed x enemies.
sekac is offline
EFFx
Veteran Member
Join Date: Feb 2016
Location: SP, Brazil
Old 09-05-2018 , 13:39   Re: [AMXX] CSGO Round End Events
Reply With Quote #95

It's normal, it happens sometimes on CSGO too.
__________________
EFFx is offline
Send a message via Skype™ to EFFx
sekac
Senior Member
Join Date: Nov 2016
Old 09-05-2018 , 14:17   Re: [AMXX] CSGO Round End Events
Reply With Quote #96

No it doesn't happen in csgo. Also, I tried it like 20 times it still showed the same message.
sekac is offline
EFFx
Veteran Member
Join Date: Feb 2016
Location: SP, Brazil
Old 09-05-2018 , 19:03   Re: [AMXX] CSGO Round End Events
Reply With Quote #97

It does, I've watched all CSGO's events and that happened, don't know if they changed it.
__________________
EFFx is offline
Send a message via Skype™ to EFFx
sekac
Senior Member
Join Date: Nov 2016
Old 09-06-2018 , 03:12   Re: [AMXX] CSGO Round End Events
Reply With Quote #98

20 tries later still no ace message
sekac is offline
Reply


Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 07:07.


Powered by vBulletin®
Copyright ©2000 - 2018, vBulletin Solutions, Inc.
Theme made by Freecode