[Greyscale]

Do you guys have respawn enabled...

[KyleS]

I do.

[sp1fft]

I do not.

[rhelgeby]

Tested again with bot_quota set to 5 and 6. Still got some double infections (either me or some bots). Respawning was off.

Enabling disabling SourceTV had no effect, so that one isn't disrupting anything.

I also had zr_infect_spawntime_min set to 1 and the max set to 2 to get quick rounds. Ratio was 2, 3 or 4. Once mother zombies were infected I remembered the names and ended the round with the zr_infect @all command.

I tested for 40-50 rounds on my linux test server with the latest patch (r649).

Whether it's on windows or linux shouldn't matter, neither which random number generator that's used. Our code should prevent it, but it doesn't and I can't see why. I guess we could print a message to the chat in every event the flag is modified and dump data; event, client, type, data.

Update:
It turns out that the immunity flag is reset on every infect that isn't a mother zombie infect. So if all players do nothing and let the round end, it works. But as soon as someone infect a human, the human's immunity flag is reset. This also applies to the admin infect command.

It's a case in this logic when the immunity flag is supposed to be kept as it is (not changed). That is when a zombie infect a human, and when a admin infect command is used. We use the ternary operator to update the flag, but that won't work in this case.

[GoD-Tony]

Good to hear you were able to narrow it down.

Another issue related to infections is that sometimes the same players are infected every other round. This is due to GetRandomInt not being very "random". I did a quick find/replace with this stock from smlib and that solved the problem.

#define SIZE_OF_INT  2147483647      // without 0
/**
 * Returns a random, uniform Integer number in the specified (inclusive) range.
 * This is safe to use multiple times in a function.
 * The seed is set automatically for each plugin.
 * Rewritten by MatthiasVance, thanks.
 * 
 * @param min         Min value used as lower border
 * @param max         Max value used as upper border
 * @return        Random Integer number between min and max
 */
stock Math_GetRandomInt(min, max)
{
    new random = GetURandomInt();
    
    if (random == 0) {
        random++;
    }

    return RoundToCeil(float(random) / (float(SIZE_OF_INT) / float(max - min + 1))) + min - 1;
}

[rhelgeby]

Thanks for the tip. This one is much better.

See the latest patch for bug fixes: http://forums.alliedmods.net/showthread.php?t=111492

[-=Leb=-]

thank you gentlemen for taking your time to resolve the bug. Much respect.

Tusen Tack ;)

[GoD-Tony]

Originally Posted by rhelgeby See the latest patch for bug fixes: http://forums.alliedmods.net/showthread.php?t=111492

I'll get the new version running, thanks!

Originally Posted by -=Leb=- Tusen Tack ;)

I thought only Danes said this.

[Greyscale]

I asked about respawn because I figured out that if someone is infected again as a reg zombie, the mother flag will reset. So you ending the round with zr_infect @all reset all the flags. Though I don't know why it wasn't skipping clients that were already zombies.. I was doing mp_restartgame 1. Well anyway, problem solved.

[KyleS]

Nice job!