[Paimon]

Description:

This plugin makes tank's rock have something powerful.
As the name says, The Rock, it becomes odin's weapon, just like the "Gungnir".
If tank throws a rock, the rock will ignore the distance and the time, impact the target at once. No miss, no survivor.

Usage:

Put it into 'plugins' folder.
And you also need [L4D & L4D2] Left 4 DHooks Direct

Cvars:

odins_rock: Turn on/off the plugin.
odins_tp: If this convar is true, tank will teleport to player after the rock hit.
odins_rock_human: Can player tank use the odin's rock or not.
odins_time: AI tank will throw rock after this convar time, 0 is off.
odins_trick: Damage to the player hit by rock.
odins_rock_punch: Rock will impact the player, this is the speed on the xOy plane.
odins_rock_punch_h: Rock will impact the player, this is the speed at the z axis.

Source:

You can ALWAYS find latest source at my GitHub:
Paimon-Kawaii - L4D2-Plugins/MyPlugins/Odin's Rock

Download:

[Silvers]

PHP Code:

if (!IsFakeClient(tank) && !g_hOdinsHuman.BoolValue) 


Flip these checks around, more optimized.

PHP Code:

    if (IsTank(tank))
        target = GetClientAimTarget(tank); 


You already have the "IsTank" check above which will return if not. Again you have several "IsTank" checks below, these are not needed.

PHP Code:

    if (!IsTankRock(inflictor)) return Plugin_Continue;

    damage = g_hOdinsTrick.FloatValue;

    if (!IsTank(attacker)) return Plugin_Continue; 


Put the two checks together, assigning a value that maybe never used is not optimized.

PHP Code:

for (int i = 1; i < MaxClients; i++) 


All loops like this should be: i <= MaxClients

PHP Code:

char classname[MAX_NAME_LENGTH]; 


You assign a random length, this is player name length not the targetname length. Then you're only checking a string that is 9 chars long, so you should set as "char classname[10]" and I would even set as "static char classname[10]" so it doesn't create the string each time, since you're filling it with data before reading ever reading it.

PHP Code:

SDKHook(target, SDKHook_OnTakeDamage, OnTakeDamage); 


You will be hooking the same target multiple times on multiple throws. You never remove the damage hook. I suggest removing the hook in the post forward "L4D_TankRock_OnRelease_Post".

[Paimon]

Thank you, Silvers. You taught me a lot.
I will optimize them later.

[Paimon]

Originally Posted by Silvers PHP Code: SDKHook(target, SDKHook_OnTakeDamage, OnTakeDamage);  You will be hooking the same target multiple times on multiple throws. You never remove the damage hook. I suggest removing the hook in the post forward "L4D_TankRock_OnRelease_Post".

For this part I have some questions:
1. Will the multiple hook call OnTakeDamage multiple times even if they are the same target?
2. I have seen that the sdkhook.inc says SDKHook could "Unhooked automatically upon destruction/removal of the entity", so is unhook necessary?

[NekoYa4r]

Why i can't compile your plugin ?

//SourceMod Batch Compiler
// by the SourceMod Dev Team


//// odins_rock.sp
//
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 122: expected type expression
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 001: expected token: "function", but found ">"
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 122: expected type expression
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 001: expected token: "function", but found ">"
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\paiutils.inc(340) : error 001: expected token: ";", but found "-identifier-"
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\paiutils.inc(881) : error 001: expected token: ";", but found "return"
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\paiutils.inc(881) : warning 217: inconsistent indentation (did you mix tabs and spaces?)
//
// 6 Errors.
//
// Compilation Time: 1.14 sec
// ----------------------------------------

Press enter to exit ...

[Paimon]

Originally Posted by NekoYa4r Why i can't compile your plugin ? //SourceMod Batch Compiler // by the SourceMod Dev Team //// odins_rock.sp // // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 122: expected type expression // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 001: expected token: "function", but found ">" // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 122: expected type expression // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 001: expected token: "function", but found ">" // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\paiutils.inc(340) : error 001: expected token: ";", but found "-identifier-" // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\paiutils.inc(881) : error 001: expected token: ";", but found "return" // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\paiutils.inc(881) : warning 217: inconsistent indentation (did you mix tabs and spaces?) // // 6 Errors. // // Compilation Time: 1.14 sec // ---------------------------------------- Press enter to exit ...

Sorry I forgot to update the include file
Now try it again.

[Silvers]

Originally Posted by Paimon For this part I have some questions: 1. Will the multiple hook call OnTakeDamage multiple times even if they are the same target? 2. I have seen that the sdkhook.inc says SDKHook could "Unhooked automatically upon destruction/removal of the entity", so is unhook necessary?

1. Yes.
2. The client "entity" is never destroyed unless they disconnect.

[Paimon]

Originally Posted by Silvers 1. Yes. 2. The client "entity" is never destroyed unless they disconnect.

OK. Thanks for your kindly reply!

[NekoYa4r]

Originally Posted by Paimon Sorry I forgot to update the include file Now try it again.

Still the same....I'm using lastest Sourcemod Stable build

//SourceMod Batch Compiler
// by the SourceMod Dev Team


//// odins_rock.sp
//
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 122: expected type expression
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 001: expected token: "function", but found ">"
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 122: expected type expression
// D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 001: expected token: "function", but found ">"
//
// 4 Errors.
//
// Compilation Time: 1.16 sec
// ----------------------------------------

Press enter to exit ...

[Paimon]

Originally Posted by NekoYa4r Still the same....I'm using lastest Sourcemod Stable build //SourceMod Batch Compiler // by the SourceMod Dev Team //// odins_rock.sp // // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 122: expected type expression // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(324) : error 001: expected token: "function", but found ">" // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 122: expected type expression // D:\Dedicated\L4D2\left4dead2\addons\sourcemod\scripting\include\sdkhooks.inc(339) : error 001: expected token: "function", but found ">" // // 4 Errors. // // Compilation Time: 1.16 sec // ---------------------------------------- Press enter to exit ...

I know what happened now.
I have removed some defines from paiutils.inc.
Just try again.