[Solved] Get max array of X flags in the loop - Page 2

Shadows Adi · 01-28-2022 , 10:35 Re: Get max array of X flags in the loop

Quote:

Originally Posted by Natsheh

This might not work because iNum might not be the last vip index.

Ok, you got a point.

Supremache · *Last edited by Supremache; 01-28-2022 at 11:39.*

Quote:

Originally Posted by Natsheh

This might not work because iNum might not be the last vip index.

You are right but your way it is not work too.

iPlayer = Check how much numbers are found in the loop
EOS or szBuffer[ 0 ] = Like i added break to the loop it show only the last player

Also i tried to make the code more optimization by doing this but got bug:

PHP Code:


			
@OnVipsOnline( id )
{
    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iPlayer, iNum;

    get_players( szPlayers, iNum , "ch" );

    for( new iIndex, i; i < iNum; i++ )
    {
        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )
        {
            formatex( szBuffer, charsmax( szBuffer ), "%s, ", g_iPlayer[ ( iPlayer = iIndex ) ][ Name ] )
        }
    }
    
    szBuffer[ strlen( szBuffer ) - 2 ] = '.'
    CC_SendMessage( id, "&x04Online:&x01 %s", iPlayer ? szBuffer : "There are no vip's online." );
}

if there's not vips will not show this message "There are no vip's online." and send error log the reason is in szBuffer[ strlen( szBuffer ) - 2 ] = '.' but i dont have other way to do this so the final solution is:

PHP Code:


			
@OnVipsOnline( id )
{
    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iPlayer, iNum;

    get_players( szPlayers, iNum, "ch" );

    for( new iIndex, i; i < iNum; i++ )
    {
        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )
        {
            formatex( szBuffer, charsmax( szBuffer ), "%s, ", g_iPlayer[ ( iPlayer = iIndex ) ][ Name ] ) // More faster than format
        }
    }
    
    if( iPlayer )
    {
        szBuffer[ strlen( szBuffer ) - 2 ] = '.'
        CC_SendMessage( id, "&x04Online:&x01 %s", szBuffer );
    }
    else
    {
        CC_SendMessage( id, "&x04Online:&x01 There are no vip's online." );
    }
}

Natsheh · 01-28-2022 , 11:44 Re: Get max array of X flags in the loop

Quote:

Originally Posted by Supremache

You are right but your way it is not work too.

iPlayer = Check how much numbers are found in the loop
szBuffer = Show only the last player

Can you speak proper english, without making guessing the word game in each post, in the other hand you made iPlayer holds the last vip id and szBuffer is an array of charctures which holds the vips names. If the array is empty then there is no need to edit the buffer or print it.

Supremache · 01-28-2022 , 11:53 Re: Get max array of X flags in the loop

Quote:

Originally Posted by Natsheh

you made iPlayer holds the last vip id and szBuffer is an array of charctures which holds the vips names. If the array is empty then there is no need to edit the buffer or print it.

I had test it before answering you but it show only the last player id ْin contrast to what iPlayer does as example:

PHP Code:


			
get_vip_num( )

{

    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iPlayer, iNum;



    get_players( szPlayers, iNum )



    for( new iIndex, i; i < iNum; i++ )

    {

        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )

        {

            iPlayer = iIndex

        }

    }

    

    return iPlayer

}

Natsheh · 01-28-2022 , 13:24 Re: Get max array of X flags in the loop

this will return an invalid counts of players whom are vips.

Supremache · 01-28-2022 , 13:34 Re: Get max array of X flags in the loop

Quote:

Originally Posted by Natsheh

this will return an invalid counts of players whom are vips.

anyways, i tested your provided code and only show the last player id

Natsheh · *Last edited by Natsheh; 01-28-2022 at 13:40.*

Quote:

Originally Posted by Supremache

anyways, i tested your provided code and only show the last player id

PHP Code:


			

@OnVipsOnline( id )
{
    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iNum;

    get_players( szPlayers, iNum, "ch" );
    new istrlen
    for( new iIndex, i; i < iNum; i++  )
    {
        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )
        { 
            istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s, ",g_iPlayer[ iIndex ][ Name ]);
        }
    }

    if( szBuffer[0] != EOS )
    {
        szBuffer[ istrlen - 1 ] = EOS;
        szBuffer[ istrlen  - 2 ] = '.';
         CC_SendMessage(id, szBuffer);
    }
    else
    {
        CC_SendMessage( id, "There are no vip's online." );
    } 
}

Test again, if you don't modify the code without understanding no problems will happen.

Supremache · 01-28-2022 , 13:45 Re: Get max array of X flags in the loop

Quote:

Originally Posted by Natsheh

PHP Code:


			


@OnVipsOnline( id )

{

    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iNum;



    get_players( szPlayers, iNum, "ch" );

    new istrlen

    for( new iIndex, i; i < iNum; i++  )

    {

        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )

        { 

            istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s, ",g_iPlayer[ iIndex ][ Name ]);

        }

    }



    if( szBuffer[0] != EOS )

    {

        szBuffer[ istrlen - 1 ] = EOS;

        szBuffer[ istrlen  - 2 ] = '.';

         CC_SendMessage(id, szBuffer);

    }

    else

    {

        CC_SendMessage( id, "There are no vip's online." );

    } 

}

Test again, if you don't modify the code without understanding no problems will happen.

You have used this way " istrlen += formatex "

PHP Code:


			
  istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s, ",g_iPlayer[ iIndex ][ Name ]);

I was talking about native strlen

Supremache · *Last edited by Supremache; 01-28-2022 at 14:17.*

What is the difference ?
You have used same way, custom variable for return a format which holds the vips names

Is it better than other one ? and why ?

PHP Code:


			
@OnVipsOnline( id )

{

    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iNum;



    get_players( szPlayers, iNum, "ch" );

    new istrlen

    for( new iIndex, i; i < iNum; i++  )

    {

        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )

        { 

            istrlen += formatex( szBuffer[istrlen], charsmax(szBuffer) - istrlen, "%s, ",g_iPlayer[ iIndex ][ Name ]);

        }

    }



    if( szBuffer[0] != EOS )

    {

        szBuffer[ istrlen - 1 ] = EOS;

        szBuffer[ istrlen  - 2 ] = '.';

         CC_SendMessage(id, szBuffer);

    }

    else

    {

        CC_SendMessage( id, "There are no vip's online." );

    } 

}

I mean this one:

PHP Code:


			
@OnVipsOnline( id )

{

    new szBuffer[ MAX_TEXT_LENGTH ], szPlayers[ MAX_PLAYERS ], iPlayer, iNum;



    get_players( szPlayers, iNum, "ch" );



    for( new iIndex, i; i < iNum; i++ )

    {

        if( g_iPlayer[ ( iIndex = szPlayers[ i ] ) ][ VIP ] & g_iSettings[ Access_OnlineList ] )

        {

            formatex( szBuffer, charsmax( szBuffer ), "%s, ", g_iPlayer[ ( iPlayer = iIndex ) ][ Name ] ) // More faster than format

        }

    }

    

    if( iPlayer )

    {

        szBuffer[ strlen( szBuffer ) - 2 ] = '.'

        CC_SendMessage( id, "&x04Online:&x01 %s", szBuffer );

    }

    else

    {

        CC_SendMessage( id, "&x04Online:&x01 There are no vip's online." );

    }

}

Natsheh · 01-29-2022 , 07:49 Re: Get max array of X flags in the loop

The 2nd code in your post will output the last vip in the players array, test it with two vips and you will see what is happening.