[Leonardo]

WHAT_IS_THIS_WHAT_IS_HAPPENING

Announce everyone that player is timing out.

How it look like?

Known bugs?

* Render effects may work incorrectly; same for god mode.

CVars:

PHP Code:

sm_toa_version
sm_toa_enabled 1 // enable/disable plugin
sm_toa_renderfx 0 // change renderfx when timing out
sm_toa_godmode 0 


Changelogs:

28.10.2012: 
    Version: 1.0.3:
        * Some code changes 
        * Added sm_toa_godmode
02.08.2012: 
    Version: 1.0.2:
        * Once client is back (when RenderFx is enabled) RenderFx sets to that it was before timing out (what)
11.07.2012: 
    Version: 1.0.1:
        * Fixed '%username% is back!' message on connect
08.07.2012: 
    Version: 1.0.0:
        * Initial release

[Chanz]

Hi,
nice plugin so far, but...

1. Does it really need to be checked in OnGameFrame, isn't a timer every second enough?
2. Your plugin clears all other render effects when someone is timing out, may lead to incompatibility with other plugins/mods? But I guess that can be ignored as long no one reports anything about it.
3. Also you may want to change the following:

This:

PHP Code:

public OnConVarChanged(Handle:hConVar, const String:strOldValue[], const String:strNewValue[] )
{
    OnConfigsExecuted();
} 


To this:

PHP Code:

public OnConVarChanged_Enabled(Handle:convar, const String:oldValue[], const String:newValue[])
{
    bEnabled = StringToInt(newValue);
}
public OnConVarChanged_RenderFx(Handle:convar, const String:oldValue[], const String:newValue[])
{
    bRenderFx = StringToInt(newValue);
} 


Maybe some additional ideas:

• Remove players from the game like teleport them or moving to spectator.
• Make players completely invisible.
• God mode for players.
• Sounds? Like a beacon that a player emits?
• Kill players that are timing out (to prevent glitches with alt+tab)?
• Respawn a player, because he is killed anyways (unless he is the last player alive in the team).

Keep it up!

Cya,
Chanz

[Leonardo]

Originally Posted by Chanz 1/ Does it really need to be checked in OnGameFrame, isn't a timer every second enough?

y

Originally Posted by Chanz 2/ Your plugin clears all other render effects when someone is timing out, may lead to incompatibility with other plugins/mods? But I guess that can be ignored as long no one reports anything about it.

I through about that. Maybe with version 1.0.2 it'll be fixed. But there's no game-, event-specific checking functions

Originally Posted by Chanz 3/ Also you may want to change the following: This: PHP Code: public OnConVarChanged(Handle:hConVar, const String:strOldValue[], const String:strNewValue[] ) {     OnConfigsExecuted(); }  To this: PHP Code: public OnConVarChanged_Enabled(Handle:convar, const String:oldValue[], const String:newValue[]) {     bEnabled = StringToInt(newValue); } public OnConVarChanged_RenderFx(Handle:convar, const String:oldValue[], const String:newValue[]) {     bRenderFx = StringToInt(newValue); }

Why?

Originally Posted by Chanz Maybe some additional ideas: Remove players from the game like teleport them or moving to spectator. Make players completely invisible. God mode for players. Sounds? Like a beacon that a player emits? Kill players that are timing out (to prevent glitches with alt+tab)? Respawn a player, because he is killed anyways (unless he is the last player alive in the team).

• No.
• No. You still can see him/her/it with HUD element "TargetID"
• Maybe. But what if player has god mode already enabled?
• No.
• No. (What glitches? TF2's glitch was fixed, for example)
• No. (How he would be killed if he's invincible?)

[thetwistedpanda]

If it's possible to do something outside of OnGameFrame, do it outside of OnGameFrame. For this plugin, a repeating timer every 0.1-1.0 seconds for each player would easily suffice as compared to a loop of x players 66x a second.

[Leonardo]

it itakes 2-3 seconds for engine to understand that client is timing out
but I must know when client has stopped responding immediately! ON EACH FRAME

[thetwistedpanda]

If there's a two to three second delay, a check every 0.1 seconds will suffice. There's no reason to know every frame. Especially when all you're doing is messing with their render.

[eric0279]

Hello,

static bool:bTimedOut[MAXPLAYERS+1], RenderFx:iRenderFx[MAXPLAYERS+1];;

should be :

static bool:bTimedOut[MAXPLAYERS+1], RenderFx:iRenderFx[MAXPLAYERS+1];

[Leonardo]

... why this thing marked as error? :\

[Chanz]

The splitting of the OnConVarChanged functions, is better to read and more logical.
You want others to understand your code, also have a clear structure to track bugs.
Since this plugin ain't that big its not a problem, but continuing this style leads to a plugin that noone wants to read/understand, which is necessary if you'd like to see your plugin approved.
Just think about it. ;-)

The additional ideas I mentioned, sure make no sense when used all together.
I thought about using them separated with cvar switches as you did it with the render.

[Dr. McKay]

I don't see any reason to break apart cvar hooks. It's not that expensive to reload all cvars when one is changed, and it honestly makes it more readable in my opinion.