[jimmehh5]

Required extension "Socket" file("socket.ext") not running.

Help. I dont know what to do with GrooveShark.

[StrikerMan780]

This extension has been causing Source Engine servers to hang, waiting on a thread. The only plugin I use Socket with as far as I know, is SourceIRC.

01:54 StrikerMan780 Hey Asherkin, you know that dump I had posted on the tracker, right?
01:54 asherkin yes
01:54 StrikerMan780 I got a minidump now of another crash, hopefully as a proper 32-bit one... would you be alright with helping me look at it again?
01:55 asherkin I can, but not tonight, if you email it to me at [email protected] I'll take a look in the morning
01:55 StrikerMan780 Alright
01:59 StrikerMan780 Ok, I sent the e-mail.
01:59 StrikerMan780 Thanks, by the way. Much appreciated.
02:00 StrikerMan780 It's too bad Windows' server binaries don't include debugging symbols
02:00 asherkin you should at least setup Accelerator
02:00 StrikerMan780 I know Valve has shown no interest in adding them, but they should be Pestered like crazy until they finally break
02:00 asherkin it wont make one shred of difference
02:00 StrikerMan780 Will Accelerator work despite the server freezing rather than crash?
02:01 asherkin the people that don't want them provided are the ones that don't communicate
02:02 asherkin I've spent decent portions of the last year discussing it with their optimization/crash investigation guy
02:02 StrikerMan780 Damn
02:02 StrikerMan780 Kind of a stupid move on their part
02:02 StrikerMan780 they include them with Linux Builds as it is
02:02 StrikerMan780 Kind of pointless to not include them with the Windows Builds as well
02:03 StrikerMan780 makes solving crashes/problems with windows dedis a pain in the ass
02:03 asherkin it's mostly a lack of understanding, and an unwillingness / lack of time to learn
02:04 asherkin that dump is also stuck in sockets
02:04 asherkin (what can I say, I'm impatient)
02:05 StrikerMan780 perhaps it's something that should be reported to the creator of the socket extension?
02:05 asherkin he hasn't been around in years
02:05 StrikerMan780 is the source code still around for it?
02:06 asherkin best bet would be to compile it yourself, then give me the PDB (so I can add symbols to Throttle), then I can give you a stack trace with function names
02:06 asherkin yeah; if his site is down it's been posted in the thread
02:06 StrikerMan780 ah, found the source : http://player.to/gitweb/index.cgi?p=sm-ext-socket.git
02:06 StrikerMan780 So, how would I go about compiling extensions?
02:07 asherkin https://phabricator.alliedmods.net/P3
02:08 asherkin that... is something that is unreasonably complex for most 3rd party extensions, and is likely even worse for that one
02:08 asherkin at a more reasonable time of night (although he might still be around, try poking him in #sourcemod), psychonic would be the best person to ask; he may have built that one in the past
02:09 asherkin it's definitely not something I'm going to attempt unravelling at 5am
02:09 StrikerMan780 Ok, so
02:09 StrikerMan780 looking at that paste
02:09 StrikerMan780 It's an infinite loop?
02:09 asherkin no, it's waiting on a critical section (i.e. another thread)
02:09 StrikerMan780 Ah
02:10 asherkin (I don't know why I'm missing windows symbols there, poking that now >.< )
02:12 asherkin https://phabricator.alliedmods.net/P4 that's better
02:13 StrikerMan780 ah
02:14 StrikerMan780 Perhaps psychonic could help in that regard, going by what you said?

[K.K.Lv]

// native SocketSend(Handle:socket, String:command[], size);
cell_t SocketSend(IPluginContext *pContext, const cell_t *params) {
    SocketWrapper* sw = extension.GetSocketWrapperByHandle(static_cast<Handle_t>(params[1]));
    if (sw == NULL) return pContext->ThrowNativeError("Invalid handle: %i", params[1]);

    char* dataTmp = NULL;
    pContext->LocalToString(params[2], &dataTmp);
    std::string data;

    if (params[3] == -1) {
        data.assign(dataTmp);
    } else {
        data.assign(dataTmp, params[3]);
    }

    switch (sw->socketType) {
        case SM_SocketType_Tcp: {
            Socket<tcp>* socket = (Socket<tcp>*) sw->socket;
            if (!socket->IsOpen()) return pContext->ThrowNativeError("Can't send, socket is not connected");
            return socket->Send(data);
        }
        case SM_SocketType_Udp: {
            Socket<udp>* socket = (Socket<udp>*) sw->socket;
            if (!socket->IsOpen()) return pContext->ThrowNativeError("Can't send, socket is not connected");
            socket->incomingCallback = pContext->GetFunctionById(params[2]);
            return socket->Send(data);
        }
        default:
            return false;
    }
}

// native SocketSendTo(Handle:socket, const String:data[], size=-1, const String:hostname[], port);
cell_t SocketSendTo(IPluginContext *pContext, const cell_t *params) {
    SocketWrapper* sw = extension.GetSocketWrapperByHandle(static_cast<Handle_t>(params[1]));
    if (sw == NULL) return pContext->ThrowNativeError("Invalid handle: %i", params[1]);
    if (sw->socketType == SM_SocketType_Tcp) return pContext->ThrowNativeError("This native doesn't support connection orientated protocols");

    char* dataTmp = NULL;
    pContext->LocalToString(params[2], &dataTmp);
    std::string data;

    if (params[3] == -1) {
        data.assign(dataTmp);
    } else {
        data.assign(dataTmp, params[3]);
    }

    char* hostname = NULL;
    pContext->LocalToString(params[4], &hostname);

    switch (sw->socketType) {
        case SM_SocketType_Udp: {
            Socket<udp>* socket = (Socket<udp>*) sw->socket;
            //if (!socket->IsOpen()) return pContext->ThrowNativeError("Can't send, socket is not connected");
            socket->incomingCallback = pContext->GetFunctionById(params[2]);
            return socket->SendTo(data, hostname, params[5]);
        }
        default:
            return false;
    }
}

Hey !!
What was going on ?
Does anyone find that code ?

[WildCard65]

Seems like author is inactive for this
Anyone mind fixing this so +ip arguement of srcds_run launch(and possibly srcds.exe) plays nice to allow plugins like sourceirc to work?

[Dr. Greg House]

Originally Posted by StrikerMan780 This extension has been causing Source Engine servers to hang, waiting on a thread. The only plugin I use Socket with as far as I know, is SourceIRC.[...]

Any news on this? Have been having this issue on rare occasions, but consistently for quite a while now.

[StrikerMan780]

Originally Posted by Dr. Greg House Any news on this? Have been having this issue on rare occasions, but consistently for quite a while now.

No, unfortunately. I'm still getting the hang. I hope someone can fix this, or create a new drop-in alternative to Socket that won't hang a server if it's waiting on a connection (reminds me of Non-Threaded vs. Threaded SQL). I may put the Socket Extension sources on Bitbucket instead of the old page there where it can be more accessible to modification.

[pmk010]

Hello there. Firstly I would like to thank you for a super useful extension.

I am new to developing plugins and have been working on a project using socket, however have had this single error message that I can't fix when trying to compile, and I can't understand why it is happening.

SourcePawn Compiler 1.5.2
Copyright (c) 1997-2006, ITB CompuPhase, (C)2004-2008 AlliedModders, LLC

bot8.sp(157) : error 100: function prototypes do not match

1 Error.

That is the error I am getting, and this is line 157 of the code:

SocketConnect(r_socket, OnSocketConnected, OnSocketReceive, OnSocketDisconnected, botIp, StringToInt(botPort));

And the chunk of code that I think may be relevant to this:

    new Handle:r_socket = SocketCreate(SOCKET_TCP, OnSocketError);
    SocketConnect(r_socket, OnSocketConnected, OnSocketReceive, OnSocketDisconnected, botIp, StringToInt(botPort));
    SocketSetArg(r_socket, iClient);
    Format(requestStr, sizeof(requestStr), "GET /?communityid=%s HTTP/1.0\r\nHost: %s\r\nConnection: close\r\n\r\n", communityid, botIp);

Now, from my attempts to debug I haven't been able to locate which function prototype(s) do not match. I have spent quite a few hours on this to no avail and would really appreciate some help, and assume this is the best place to ask for help.

[Alex30555]

Hi

What is this error plz ?

[SERR] callback not executable (event=1)

And

[SERR] callback not executable (event=3)

Thanks @all

[weeb1e]

This extension is missing socket exception handling which causes very rare segfaults on servers using listening sockets.

I have patched the issue and will be testing it on a single server for a while, to make sure there are no issues before releasing a patch.

[Dr. Greg House]

I've had issues with the "size" parameter in the last few days. It seems to be ignored when certain special characters are used (gg nicknames), so as a result "more" data is being sent. So among the size I also null-terminate the buffer and it fixed the issue. I should note at this point that since I write raw data to it that there are actually 0-bytes before the message ends. So I have no idea why this actually works.