[Exxelence]

The point is, i am using a tiered vote. I have grouped my maps into 6 Tiers and of each section 1 invote. I know this is quite a lot, but it's working on other servers as well. So i don't quite get it

[Bittersweet]

Originally Posted by Exxelence The point is, i am using a tiered vote. I have grouped my maps into 6 Tiers and of each section 1 invote. I know this is quite a lot, but it's working on other servers as well. So i don't quite get it

Well, it could be a performance issue with the server machine, or it could be a memory leak in one of your other plugins. If your plugin setup is the same on other servers, I'd check to see what is different on this particular server that you are having the issue with. I would create a temporary umc-mapcycle file that is much smaller, just a few maps (only 1 page in the vote) and see if you still get the lag. If so, the issue is probably something outside of UMC. If not, start adding maps back a few at a time and find that sweet spot with a maximum amount of maps without lag.

[Powerlord]

I'm not sure why, but at least on TF2, if you try add a workshop map to a vote, UMC will default the max number of players to 0 instead of MaxClients.

Ran into this while trying to see if the SM 1.8 workshop stuff was working properly.

Edit: Even manually specifying the max_players is forcing it to 0. Trying to figure out why this is now.

[Powerlord]

The reason is because the SourceMod KeyValues stuff is choking on having / in the map name. Meaning that this is going to choke on CS:GO Linux and TF2 all platforms for workshop maps.

Looking into workarounds now.

[Bittersweet]

Originally Posted by Powerlord The reason is because the SourceMod KeyValues stuff is choking on having / in the map name. Meaning that this is going to choke on CS:GO Windows and TF2 all platforms for workshop maps. Looking into workarounds now.

Good to know, I'm sure this will come up. I assume you've already tried substituting a \ for the /s.

[Powerlord]

Originally Posted by Bittersweet Good to know, I'm sure this will come up. I assume you've already tried substituting a \ for the /s.

When I was implementing GetMapDisplayName in SM 1.8, I found out the hard way that specific games and OSes require specific slashes to recognize maps.

Specifically:

CS:GO Windows requires Workshop maps to be in workshop\[map id] format.
CS:GO Linux and TF2 all platforms require Workshop maps to be in workshop/[map id] format.

Note that [map id] can either be the workshop ID number or the long-format name (which is different in CS:GO than it is in TF2).

Side note: This is why GetMapDisplayName is a native instead of a stock. That way, when more games are added, we can add special cases for their specific formats.

I'm also not sure exactly *which* KeyValues command is doing it. I have other keyvalues files that work with / in key names (TF2's PropHunt does this for models). I suspect it's the one that jumps to a particular keyvalue, but it could just as easily be the one that copies a bunch of subkeys to a new KeyValues instance.

[Bittersweet]

Originally Posted by Powerlord When I was implementing GetMapDisplayName in SM 1.8, I found out the hard way that specific games and OSes require specific slashes to recognize maps. Specifically: CS:GO Windows requires Workshop maps to be in workshop\[map id] format. CS:GO Linux and TF2 all platforms require Workshop maps to be in workshop/[map id] format. Note that [map id] can either be the workshop ID number or the long-format name (which is different in CS:GO than it is in TF2). Side note: This is why GetMapDisplayName is a native instead of a stock. That way, when more games are added, we can add special cases for their specific formats. I'm also not sure exactly *which* KeyValues command is doing it. I have other keyvalues files that work with / in key names (TF2's PropHunt does this for models). I suspect it's the one that jumps to a particular keyvalue, but it could just as easily be the one that copies a bunch of subkeys to a new KeyValues instance.

Yeah, I thought / was a reserved character for SM,or it may be the source code of SourcePawn that I'm thinking of. Seems like I had to insert some into some of my SQL statements to get them to work, and I believe some of the older text stuff (that I think they've gotten rid of) made some special use of that character. Not the best character to pick to reserve when it's already reserved by the OS.

You say it's choking. What exactly does that mean? Is it locking up/crashing the server? I suppose there is no error report.

[Powerlord]

Originally Posted by Bittersweet Yeah, I thought / was a reserved character for SM,or it may be the source code of SourcePawn that I'm thinking of. Seems like I had to insert some into some of my SQL statements to get them to work, and I believe some of the older text stuff (that I think they've gotten rid of) made some special use of that character. Not the best character to pick to reserve when it's already reserved by the OS. You say it's choking. What exactly does that mean? Is it locking up/crashing the server? I suppose there is no error report.

Something asherkin said made me realize what the real problem is:

Valve's KeyValues parser treats a lookup for the key "workshop/123456789" as a lookup for the key "123456789" inside the key "workshop".

Which makes me wonder why KeyValues doesn't toss some sort of error and/or do automatic replacements when it runs into keys that contain a forward slash since it doesn't actually support them.

[Bittersweet]

Originally Posted by Powerlord Something asherkin said made me realize what the real problem is: Valve's KeyValues parser treats a lookup for the key "workshop/123456789" as a lookup for the key "123456789" inside the key "workshop". Which makes me wonder why KeyValues doesn't toss some sort of error and/or do automatic replacements when it runs into keys that contain a forward slash since it doesn't actually support them.

I wish I had more time to figure this stuff out. I need a refresher course, but this piqued my interest, because there is no error handling:

static cell_t smn_CreateKeyValues(IPluginContext *pCtx, const cell_t *params)
{
	KeyValueStack *pStk;
	char *name, *firstkey, *firstvalue;
	bool is_empty;

	pCtx->LocalToString(params[1], &name);
	pCtx->LocalToString(params[2], &firstkey);
	pCtx->LocalToString(params[3], &firstvalue);

	is_empty = (firstkey[0] == '\0');
	pStk = new KeyValueStack;
	pStk->pBase = new KeyValues(name, is_empty ? NULL : firstkey, (is_empty||(firstvalue[0]=='\0')) ? NULL : firstvalue);
	pStk->pCurRoot.push(pStk->pBase);

	return handlesys->CreateHandle(g_KeyValueType, pStk, pCtx->GetIdentity(), g_pCoreIdent, NULL);
}

[8guawong]

any1 know how to stop nominated maps from showing up in tiered vote?
ie. player nominate cs_assault
but players voted for defuse mode
but cs_assault still shows up in 2nd part of the vote :/